diff options
author | Gavin Shan <shangw@linux.vnet.ibm.com> | 2012-09-11 18:59:46 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2012-09-11 18:59:46 -0400 |
commit | 462d93030628a598bc440dcd35c89fb7fc63f58c (patch) | |
tree | f1e562043b6e141e861aff1d85dda40e9164941e /drivers | |
parent | ac5ad93e92c3ffca4c7ba386aaa34244e27b7759 (diff) |
PCI: Align P2P windows using pcibios_window_alignment()
This patch changes pbus_size_io() and pbus_size_mem() to do window (I/O,
memory and prefetchable memory) reassignment based on the minimal
alignments for the P2P bridge, which was retrieved by window_alignment().
[bhelgaas: changelog]
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/pci/setup-bus.c | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 896f06e3e793..a66cf0905a15 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c | |||
@@ -749,17 +749,12 @@ static void pbus_size_io(struct pci_bus *bus, resource_size_t min_size, | |||
749 | struct resource *b_res = find_free_bus_resource(bus, IORESOURCE_IO); | 749 | struct resource *b_res = find_free_bus_resource(bus, IORESOURCE_IO); |
750 | unsigned long size = 0, size0 = 0, size1 = 0; | 750 | unsigned long size = 0, size0 = 0, size1 = 0; |
751 | resource_size_t children_add_size = 0; | 751 | resource_size_t children_add_size = 0; |
752 | resource_size_t min_align = 4096, align; | 752 | resource_size_t min_align, io_align, align; |
753 | 753 | ||
754 | if (!b_res) | 754 | if (!b_res) |
755 | return; | 755 | return; |
756 | 756 | ||
757 | /* | 757 | io_align = min_align = window_alignment(bus, IORESOURCE_IO); |
758 | * Per spec, I/O windows are 4K-aligned, but some bridges have an | ||
759 | * extension to support 1K alignment. | ||
760 | */ | ||
761 | if (bus->self->io_window_1k) | ||
762 | min_align = 1024; | ||
763 | list_for_each_entry(dev, &bus->devices, bus_list) { | 758 | list_for_each_entry(dev, &bus->devices, bus_list) { |
764 | int i; | 759 | int i; |
765 | 760 | ||
@@ -786,8 +781,8 @@ static void pbus_size_io(struct pci_bus *bus, resource_size_t min_size, | |||
786 | } | 781 | } |
787 | } | 782 | } |
788 | 783 | ||
789 | if (min_align > 4096) | 784 | if (min_align > io_align) |
790 | min_align = 4096; | 785 | min_align = io_align; |
791 | 786 | ||
792 | size0 = calculate_iosize(size, min_size, size1, | 787 | size0 = calculate_iosize(size, min_size, size1, |
793 | resource_size(b_res), min_align); | 788 | resource_size(b_res), min_align); |
@@ -909,6 +904,8 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask, | |||
909 | min_align = align1 >> 1; | 904 | min_align = align1 >> 1; |
910 | align += aligns[order]; | 905 | align += aligns[order]; |
911 | } | 906 | } |
907 | |||
908 | min_align = max(min_align, window_alignment(bus, b_res->flags & mask)); | ||
912 | size0 = calculate_memsize(size, min_size, 0, resource_size(b_res), min_align); | 909 | size0 = calculate_memsize(size, min_size, 0, resource_size(b_res), min_align); |
913 | if (children_add_size > add_size) | 910 | if (children_add_size > add_size) |
914 | add_size = children_add_size; | 911 | add_size = children_add_size; |