diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2009-10-14 04:18:26 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-10-14 04:18:26 -0400 |
commit | 03717e3d12b625268848414e39beda25e4515692 (patch) | |
tree | 8f5b80f26b8c473675aab6dcd63f5a0cfb518794 /drivers | |
parent | c58543c869606532c2382f027d6466f4672ea756 (diff) |
watchdog: Fix rio watchdog probe function
After sucessfully registering the misc device the driver iounmaps the
hardware registers and kfree's the device data structure. Ouch !
This was introduced with commit e42311d75 (riowatchdog: Convert to
pure OF driver) and went unnoticed for more than a year :)
Return success instead of dropping into the error cleanup code path.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/watchdog/riowd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/watchdog/riowd.c b/drivers/watchdog/riowd.c index 1e8f02f440e6..d3c824dc2358 100644 --- a/drivers/watchdog/riowd.c +++ b/drivers/watchdog/riowd.c | |||
@@ -206,7 +206,7 @@ static int __devinit riowd_probe(struct of_device *op, | |||
206 | 206 | ||
207 | dev_set_drvdata(&op->dev, p); | 207 | dev_set_drvdata(&op->dev, p); |
208 | riowd_device = p; | 208 | riowd_device = p; |
209 | err = 0; | 209 | return 0; |
210 | 210 | ||
211 | out_iounmap: | 211 | out_iounmap: |
212 | of_iounmap(&op->resource[0], p->regs, 2); | 212 | of_iounmap(&op->resource[0], p->regs, 2); |