diff options
author | Tejun Heo <htejun@gmail.com> | 2006-05-31 05:27:32 -0400 |
---|---|---|
committer | Tejun Heo <htejun@gmail.com> | 2006-05-31 05:27:32 -0400 |
commit | 72fa4b742b327bd1b07985d79a61c61dbd9fd4e6 (patch) | |
tree | 50d95fcf58e709b12510151e8e1cae8d8cb2538e /drivers | |
parent | 3ef3b43d5633d30fa3f033f62094ec2e9c5b8376 (diff) |
[PATCH] libata-hp-prep: make some ata_device fields persistent
Lifetimes of some fields span over device plugging/unplugging. This
patch moves such persistent fields to the top of ata_device and
separate them with ATA_DEVICE_CLEAR_OFFSET. Fields above the offset
are initialized once during host initializatino while all other fields
are cleared before hotplugging. Currently ->ap, devno and part of
flags are persistent.
Note that flags is partially cleared while holding host_set lock.
This is to synchronize with later warm plug implementation which will
record hotplug request in dev->flags.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/scsi/libata-core.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c index 8fda8228159c..a07ab77d32d6 100644 --- a/drivers/scsi/libata-core.c +++ b/drivers/scsi/libata-core.c | |||
@@ -5153,9 +5153,18 @@ static void ata_host_remove(struct ata_port *ap, unsigned int do_unregister) | |||
5153 | void ata_dev_init(struct ata_device *dev) | 5153 | void ata_dev_init(struct ata_device *dev) |
5154 | { | 5154 | { |
5155 | struct ata_port *ap = dev->ap; | 5155 | struct ata_port *ap = dev->ap; |
5156 | unsigned long flags; | ||
5157 | |||
5158 | /* High bits of dev->flags are used to record warm plug | ||
5159 | * requests which occur asynchronously. Synchronize using | ||
5160 | * host_set lock. | ||
5161 | */ | ||
5162 | spin_lock_irqsave(&ap->host_set->lock, flags); | ||
5163 | dev->flags &= ~ATA_DFLAG_INIT_MASK; | ||
5164 | spin_unlock_irqrestore(&ap->host_set->lock, flags); | ||
5156 | 5165 | ||
5157 | memset((void *)dev, 0, sizeof(*dev)); | 5166 | memset((void *)dev + ATA_DEVICE_CLEAR_OFFSET, 0, |
5158 | dev->devno = dev - ap->device; | 5167 | sizeof(*dev) - ATA_DEVICE_CLEAR_OFFSET); |
5159 | dev->pio_mask = UINT_MAX; | 5168 | dev->pio_mask = UINT_MAX; |
5160 | dev->mwdma_mask = UINT_MAX; | 5169 | dev->mwdma_mask = UINT_MAX; |
5161 | dev->udma_mask = UINT_MAX; | 5170 | dev->udma_mask = UINT_MAX; |
@@ -5218,6 +5227,7 @@ static void ata_host_init(struct ata_port *ap, struct Scsi_Host *host, | |||
5218 | for (i = 0; i < ATA_MAX_DEVICES; i++) { | 5227 | for (i = 0; i < ATA_MAX_DEVICES; i++) { |
5219 | struct ata_device *dev = &ap->device[i]; | 5228 | struct ata_device *dev = &ap->device[i]; |
5220 | dev->ap = ap; | 5229 | dev->ap = ap; |
5230 | dev->devno = i; | ||
5221 | ata_dev_init(dev); | 5231 | ata_dev_init(dev); |
5222 | } | 5232 | } |
5223 | 5233 | ||