Merge branch 'master'

15 files changed, 71 insertions, 98 deletions

diff --git a/drivers/i2c/busses/i2c-ixp2000.c b/drivers/i2c/busses/i2c-ixp2000.c
index cef024a7d048..cd6f45d186ab 100644
--- a/drivers/i2c/busses/i2c-ixp2000.c
+++ b/drivers/i2c/busses/i2c-ixp2000.c
@@ -36,8 +36,6 @@
 #include <asm/hardware.h>       /* Pick up IXP2000-specific bits */
 #include <asm/arch/gpio.h>
 
-static struct device_driver ixp2000_i2c_driver;
-
 static inline int ixp2000_scl_pin(void *data)
 {
         return ((struct ixp2000_i2c_pins*)data)->scl_pin;
@@ -120,7 +118,7 @@ static int ixp2000_i2c_probe(struct platform_device *plat_dev)
         drv_data->algo_data.timeout = 100;
 
         drv_data->adapter.id = I2C_HW_B_IXP2000,
-        strlcpy(drv_data->adapter.name, ixp2000_i2c_driver.name,
+        strlcpy(drv_data->adapter.name, plat_dev->dev.driver->name,
                 I2C_NAME_SIZE);
         drv_data->adapter.algo_data = &drv_data->algo_data,
 
@@ -132,7 +130,7 @@ static int ixp2000_i2c_probe(struct platform_device *plat_dev)
         gpio_line_set(gpio->sda_pin, 0);
 
         if ((err = i2c_bit_add_bus(&drv_data->adapter)) != 0) {
-                dev_err(dev, "Could not install, error %d\n", err);
+                dev_err(&plat_dev->dev, "Could not install, error %d\n", err);
                 kfree(drv_data);
                 return err;
         } 
diff --git a/drivers/i2c/busses/i2c-ixp4xx.c b/drivers/i2c/busses/i2c-ixp4xx.c
index f87220be3c87..e422d8b2d4d6 100644
--- a/drivers/i2c/busses/i2c-ixp4xx.c
+++ b/drivers/i2c/busses/i2c-ixp4xx.c
@@ -35,8 +35,6 @@
 
 #include <asm/hardware.h>       /* Pick up IXP4xx-specific bits */
 
-static struct platform_driver ixp4xx_i2c_driver;
-
 static inline int ixp4xx_scl_pin(void *data)
 {
         return ((struct ixp4xx_i2c_pins*)data)->scl_pin;
@@ -128,7 +126,7 @@ static int ixp4xx_i2c_probe(struct platform_device *plat_dev)
         drv_data->algo_data.timeout = 100;
 
         drv_data->adapter.id = I2C_HW_B_IXP4XX;
-        strlcpy(drv_data->adapter.name, ixp4xx_i2c_driver.driver.name,
+        strlcpy(drv_data->adapter.name, plat_dev->dev.driver->name,
                 I2C_NAME_SIZE);
         drv_data->adapter.algo_data = &drv_data->algo_data;
 
@@ -140,8 +138,7 @@ static int ixp4xx_i2c_probe(struct platform_device *plat_dev)
         gpio_line_set(gpio->sda_pin, 0);
 
         if ((err = i2c_bit_add_bus(&drv_data->adapter) != 0)) {
-                printk(KERN_ERR "ERROR: Could not install %s\n", 
-                                plat_dev->dev.bus_id);
+                printk(KERN_ERR "ERROR: Could not install %s\n", plat_dev->dev.bus_id);
 
                 kfree(drv_data);
                 return err;
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 421b62d900af..9455e42abb23 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -3510,8 +3510,8 @@ static void __exit ide_cdrom_exit(void)
 {
         driver_unregister(&ide_cdrom_driver.gen_driver);
 }
- 
-static int ide_cdrom_init(void)
+
+static int __init ide_cdrom_init(void)
 {
         return driver_register(&ide_cdrom_driver.gen_driver);
 }
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 1a45f75dc9b2..f4e3d3527b0e 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -1266,7 +1266,7 @@ static void __exit idedisk_exit (void)
         driver_unregister(&idedisk_driver.gen_driver);
 }
 
-static int idedisk_init (void)
+static int __init idedisk_init(void)
 {
         return driver_register(&idedisk_driver.gen_driver);
 }
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 94c147b79a49..9e293c8063dc 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -2191,10 +2191,7 @@ static void __exit idefloppy_exit (void)
         driver_unregister(&idefloppy_driver.gen_driver);
 }
 
-/*
- *      idefloppy_init will register the driver for each floppy.
- */
-static int idefloppy_init (void)
+static int __init idefloppy_init(void)
 {
         printk("ide-floppy driver " IDEFLOPPY_VERSION "\n");
         return driver_register(&idefloppy_driver.gen_driver);
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 5275cbb1afe9..ecfafcdafea4 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -1629,12 +1629,6 @@ EXPORT_SYMBOL(ide_init_drive_cmd);
  *      for the new rq to be completed.  This is VERY DANGEROUS, and is
  *      intended for careful use by the ATAPI tape/cdrom driver code.
  *
- *      If action is ide_next, then the rq is queued immediately after
- *      the currently-being-processed-request (if any), and the function
- *      returns without waiting for the new rq to be completed.  As above,
- *      This is VERY DANGEROUS, and is intended for careful use by the
- *      ATAPI tape/cdrom driver code.
- *
  *      If action is ide_end, then the rq is queued at the end of the
  *      request queue, and the function returns immediately without waiting
  *      for the new rq to be completed. This is again intended for careful
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 2069dd693c9f..7d7944ed4158 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -4916,10 +4916,7 @@ static void __exit idetape_exit (void)
         unregister_chrdev(IDETAPE_MAJOR, "ht");
 }
 
-/*
- *      idetape_init will register the driver for each tape.
- */
-static int idetape_init (void)
+static int __init idetape_init(void)
 {
         int error = 1;
         idetape_sysfs_class = class_create(THIS_MODULE, "ide_tape");
diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
index 54f9639c2a8c..62ebefd6394a 100644
--- a/drivers/ide/ide-taskfile.c
+++ b/drivers/ide/ide-taskfile.c
@@ -51,8 +51,6 @@
 #include <asm/uaccess.h>
 #include <asm/io.h>
 
-#define DEBUG_TASKFILE  0       /* unset when fixed */
-
 static void ata_bswap_data (void *buffer, int wcount)
 {
         u16 *p = buffer;
@@ -765,9 +763,6 @@ ide_startstop_t flagged_taskfile (ide_drive_t *drive, ide_task_t *task)
         ide_hwif_t *hwif        = HWIF(drive);
         task_struct_t *taskfile = (task_struct_t *) task->tfRegister;
         hob_struct_t *hobfile   = (hob_struct_t *) task->hobRegister;
-#if DEBUG_TASKFILE
-        u8 status;
-#endif
 
         if (task->data_phase == TASKFILE_MULTI_IN ||
             task->data_phase == TASKFILE_MULTI_OUT) {
@@ -778,19 +773,13 @@ ide_startstop_t flagged_taskfile (ide_drive_t *drive, ide_task_t *task)
         }
 
         /*
-         * (ks) Check taskfile in/out flags.
+         * (ks) Check taskfile in flags.
          * If set, then execute as it is defined.
          * If not set, then define default settings.
          * The default values are:
-         *      write and read all taskfile registers (except data) 
-         *      write and read the hob registers (sector,nsector,lcyl,hcyl)
+         *      read all taskfile registers (except data)
+         *      read the hob registers (sector, nsector, lcyl, hcyl)
          */
-        if (task->tf_out_flags.all == 0) {
-                task->tf_out_flags.all = IDE_TASKFILE_STD_OUT_FLAGS;
-                if (drive->addressing == 1)
-                        task->tf_out_flags.all |= (IDE_HOB_STD_OUT_FLAGS << 8);
-        }
-
         if (task->tf_in_flags.all == 0) {
                 task->tf_in_flags.all = IDE_TASKFILE_STD_IN_FLAGS;
                 if (drive->addressing == 1)
@@ -803,16 +792,6 @@ ide_startstop_t flagged_taskfile (ide_drive_t *drive, ide_task_t *task)
                 hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
         SELECT_MASK(drive, 0);
 
-#if DEBUG_TASKFILE
-        status = hwif->INB(IDE_STATUS_REG);
-        if (status & 0x80) {
-                printk("flagged_taskfile -> Bad status. Status = %02x. wait 100 usec ...\n", status);
-                udelay(100);
-                status = hwif->INB(IDE_STATUS_REG);
-                printk("flagged_taskfile -> Status = %02x\n", status);
-        }
-#endif
-
         if (task->tf_out_flags.b.data) {
                 u16 data =  taskfile->data + (hobfile->data << 8);
                 hwif->OUTW(data, IDE_DATA_REG);
diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
index 16b3e2d8bfb1..75a2253a3e68 100644
--- a/drivers/ide/pci/sis5513.c
+++ b/drivers/ide/pci/sis5513.c
@@ -87,6 +87,7 @@ static const struct {
         u8 chipset_family;
         u8 flags;
 } SiSHostChipInfo[] = {
+        { "SiS965",     PCI_DEVICE_ID_SI_965,   ATA_133  },
         { "SiS745",     PCI_DEVICE_ID_SI_745,   ATA_100  },
         { "SiS735",     PCI_DEVICE_ID_SI_735,   ATA_100  },
         { "SiS733",     PCI_DEVICE_ID_SI_733,   ATA_100  },
diff --git a/drivers/ide/pci/via82cxxx.c b/drivers/ide/pci/via82cxxx.c
index cee2c374cd2f..7161ce0ef5aa 100644
--- a/drivers/ide/pci/via82cxxx.c
+++ b/drivers/ide/pci/via82cxxx.c
@@ -79,6 +79,7 @@ static struct via_isa_bridge {
         u8 rev_max;
         u16 flags;
 } via_isa_bridges[] = {
+        { "vt6410",     PCI_DEVICE_ID_VIA_6410,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
         { "vt8237",     PCI_DEVICE_ID_VIA_8237,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
         { "vt8235",     PCI_DEVICE_ID_VIA_8235,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
         { "vt8233a",    PCI_DEVICE_ID_VIA_8233A,    0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
@@ -467,24 +468,35 @@ static void __devinit init_hwif_via82cxxx(ide_hwif_t *hwif)
         hwif->drives[1].autodma = hwif->autodma;
 }
 
-static ide_pci_device_t via82cxxx_chipset __devinitdata = {
-        .name           = "VP_IDE",
-        .init_chipset   = init_chipset_via82cxxx,
-        .init_hwif      = init_hwif_via82cxxx,
-        .channels       = 2,
-        .autodma        = NOAUTODMA,
-        .enablebits     = {{0x40,0x02,0x02}, {0x40,0x01,0x01}},
-        .bootable       = ON_BOARD,
+static ide_pci_device_t via82cxxx_chipsets[] __devinitdata = {
+        {       /* 0 */
+                .name           = "VP_IDE",
+                .init_chipset   = init_chipset_via82cxxx,
+                .init_hwif      = init_hwif_via82cxxx,
+                .channels       = 2,
+                .autodma        = NOAUTODMA,
+                .enablebits     = {{0x40,0x02,0x02}, {0x40,0x01,0x01}},
+                .bootable       = ON_BOARD
+        },{     /* 1 */
+                .name           = "VP_IDE",
+                .init_chipset   = init_chipset_via82cxxx,
+                .init_hwif      = init_hwif_via82cxxx,
+                .channels       = 2,
+                .autodma        = AUTODMA,
+                .enablebits     = {{0x00,0x00,0x00}, {0x00,0x00,0x00}},
+                .bootable       = ON_BOARD,
+        }
 };
 
 static int __devinit via_init_one(struct pci_dev *dev, const struct pci_device_id *id)
 {
-        return ide_setup_pci_device(dev, &via82cxxx_chipset);
+        return ide_setup_pci_device(dev, &via82cxxx_chipsets[id->driver_data]);
 }
 
 static struct pci_device_id via_pci_tbl[] = {
         { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C576_1, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
         { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+        { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_6410,     PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
         { 0, },
 };
 MODULE_DEVICE_TABLE(pci, via_pci_tbl);
diff --git a/drivers/mtd/maps/ipaq-flash.c b/drivers/mtd/maps/ipaq-flash.c
index 35097c9bbf50..b8ccb0a95789 100644
--- a/drivers/mtd/maps/ipaq-flash.c
+++ b/drivers/mtd/maps/ipaq-flash.c
@@ -246,7 +246,7 @@ int __init ipaq_mtd_init(void)
                         ipaq_map[i].size = h3xxx_max_flash_size;
                         ipaq_map[i].set_vpp = h3xxx_set_vpp;
                         ipaq_map[i].phys = cs_phys[i];
-                        ipaq_map[i].virt = __ioremap(cs_phys[i], 0x04000000, 0, 1);
+                        ipaq_map[i].virt = ioremap(cs_phys[i], 0x04000000);
                         if (machine_is_h3100 () || machine_is_h1900())
                                 ipaq_map[i].bankwidth = 2;
                 }
@@ -280,7 +280,7 @@ int __init ipaq_mtd_init(void)
                 nb_parts = ARRAY_SIZE(jornada_partitions);
                 ipaq_map[0].size = jornada_max_flash_size;
                 ipaq_map[0].set_vpp = jornada56x_set_vpp;
-                ipaq_map[0].virt = (__u32)__ioremap(0x0, 0x04000000, 0, 1);
+                ipaq_map[0].virt = (__u32)ioremap(0x0, 0x04000000);
         }
 #endif
 #ifdef CONFIG_SA1100_JORNADA720
@@ -442,7 +442,7 @@ static int __init h1900_special_case(void)
         ipaq_map[0].size = 0x80000;
         ipaq_map[0].set_vpp = h3xxx_set_vpp;
         ipaq_map[0].phys = 0x0;
-        ipaq_map[0].virt = __ioremap(0x0, 0x04000000, 0, 1);
+        ipaq_map[0].virt = ioremap(0x0, 0x04000000);
         ipaq_map[0].bankwidth = 2;
 
         printk(KERN_NOTICE "iPAQ flash: probing %d-bit flash bus, window=%lx with JEDEC.\n", ipaq_map[0].bankwidth*8, ipaq_map[0].virt);
diff --git a/drivers/mtd/maps/ixp2000.c b/drivers/mtd/maps/ixp2000.c
index fc7a78e31735..2c9cc7f37e92 100644
--- a/drivers/mtd/maps/ixp2000.c
+++ b/drivers/mtd/maps/ixp2000.c
@@ -159,12 +159,12 @@ static int ixp2000_flash_probe(struct platform_device *dev)
                 return -ENODEV;
 
         window_size = dev->resource->end - dev->resource->start + 1;
-        dev_info(_dev, "Probe of IXP2000 flash(%d banks x %dMiB)\n",
-                        ixp_data->nr_banks, ((u32)window_size >> 20));
+        dev_info(&dev->dev, "Probe of IXP2000 flash(%d banks x %dMiB)\n",
+                 ixp_data->nr_banks, ((u32)window_size >> 20));
 
         if (plat->width != 1) {
-                dev_err(_dev, "IXP2000 MTD map only supports 8-bit mode, asking for %d\n",
-                                plat->width * 8);
+                dev_err(&dev->dev, "IXP2000 MTD map only supports 8-bit mode, asking for %d\n",
+                        plat->width * 8);
                 return -EIO;
         }
 
@@ -202,7 +202,7 @@ static int ixp2000_flash_probe(struct platform_device *dev)
                         dev->resource->end - dev->resource->start + 1,
                         dev->dev.bus_id);
         if (!info->res) {
-                dev_err(_dev, "Could not reserve memory region\n");
+                dev_err(&dev->dev, "Could not reserve memory region\n");
                 err = -ENOMEM;
                 goto Error;
         }
@@ -210,7 +210,7 @@ static int ixp2000_flash_probe(struct platform_device *dev)
         info->map.map_priv_1 = (unsigned long) ioremap(dev->resource->start,
                                 dev->resource->end - dev->resource->start + 1);
         if (!info->map.map_priv_1) {
-                dev_err(_dev, "Failed to ioremap flash region\n");
+                dev_err(&dev->dev, "Failed to ioremap flash region\n");
                 err = -EIO;
                 goto Error;
         }
@@ -221,13 +221,13 @@ static int ixp2000_flash_probe(struct platform_device *dev)
          */
 
         erratum44_workaround = ixp2000_has_broken_slowport();
-        dev_info(_dev, "Erratum 44 workaround %s\n",
+        dev_info(&dev->dev, "Erratum 44 workaround %s\n",
                erratum44_workaround ? "enabled" : "disabled");
 #endif
 
         info->mtd = do_map_probe(plat->map_name, &info->map);
         if (!info->mtd) {
-                dev_err(_dev, "map_probe failed\n");
+                dev_err(&dev->dev, "map_probe failed\n");
                 err = -ENXIO;
                 goto Error;
         }
@@ -237,7 +237,7 @@ static int ixp2000_flash_probe(struct platform_device *dev)
         if (err > 0) {
                 err = add_mtd_partitions(info->mtd, info->partitions, err);
                 if(err)
-                        dev_err(_dev, "Could not parse partitions\n");
+                        dev_err(&dev->dev, "Could not parse partitions\n");
         }
 
         if (err)
@@ -251,8 +251,8 @@ Error:
 }
 
 static struct platform_driver ixp2000_flash_driver = {
-        .probe          = &ixp2000_flash_probe,
-        .remove         = &ixp2000_flash_remove
+        .probe          = ixp2000_flash_probe,
+        .remove         = ixp2000_flash_remove,
         .driver         = {
                 .name   = "IXP2000-Flash",
         },
diff --git a/drivers/mtd/nand/h1910.c b/drivers/mtd/nand/h1910.c
index 041e4b3358fb..f68f7a99a630 100644
--- a/drivers/mtd/nand/h1910.c
+++ b/drivers/mtd/nand/h1910.c
@@ -112,7 +112,7 @@ static int __init h1910_init (void)
         if (!machine_is_h1900())
                 return -ENODEV;
 
-        nandaddr = __ioremap(0x08000000, 0x1000, 0, 1);
+        nandaddr = ioremap(0x08000000, 0x1000);
         if (!nandaddr) {
                 printk("Failed to ioremap nand flash.\n");
                 return -ENOMEM;
diff --git a/drivers/serial/amba-pl011.c b/drivers/serial/amba-pl011.c
index 938d185841c9..89d7bd3eaee3 100644
--- a/drivers/serial/amba-pl011.c
+++ b/drivers/serial/amba-pl011.c
@@ -49,7 +49,6 @@
 #include <linux/serial.h>
 
 #include <asm/io.h>
-#include <asm/irq.h>
 #include <asm/sizes.h>
 #include <asm/hardware/amba.h>
 #include <asm/hardware/clock.h>
@@ -63,7 +62,8 @@
 
 #define AMBA_ISR_PASS_LIMIT     256
 
-#define UART_DUMMY_RSR_RX       256
+#define UART_DR_ERROR           (UART011_DR_OE|UART011_DR_BE|UART011_DR_PE|UART011_DR_FE)
+#define UART_DUMMY_DR_RX        (1 << 16)
 
 /*
  * We wrap our port structure around the generic uart_port.
@@ -116,7 +116,7 @@ pl011_rx_chars(struct uart_amba_port *uap)
 #endif
 {
         struct tty_struct *tty = uap->port.info->tty;
-        unsigned int status, ch, flag, rsr, max_count = 256;
+        unsigned int status, ch, flag, max_count = 256;
 
         status = readw(uap->port.membase + UART01x_FR);
         while ((status & UART01x_FR_RXFE) == 0 && max_count--) {
@@ -129,7 +129,7 @@ pl011_rx_chars(struct uart_amba_port *uap)
                          */
                 }
 
-                ch = readw(uap->port.membase + UART01x_DR);
+                ch = readw(uap->port.membase + UART01x_DR) | UART_DUMMY_DR_RX;
                 flag = TTY_NORMAL;
                 uap->port.icount.rx++;
 
@@ -137,34 +137,33 @@ pl011_rx_chars(struct uart_amba_port *uap)
                  * Note that the error handling code is
                  * out of the main execution path
                  */
-                rsr = readw(uap->port.membase + UART01x_RSR) | UART_DUMMY_RSR_RX;
-                if (unlikely(rsr & UART01x_RSR_ANY)) {
-                        if (rsr & UART01x_RSR_BE) {
-                                rsr &= ~(UART01x_RSR_FE | UART01x_RSR_PE);
+                if (unlikely(ch & UART_DR_ERROR)) {
+                        if (ch & UART011_DR_BE) {
+                                ch &= ~(UART011_DR_FE | UART011_DR_PE);
                                 uap->port.icount.brk++;
                                 if (uart_handle_break(&uap->port))
                                         goto ignore_char;
-                        } else if (rsr & UART01x_RSR_PE)
+                        } else if (ch & UART011_DR_PE)
                                 uap->port.icount.parity++;
-                        else if (rsr & UART01x_RSR_FE)
+                        else if (ch & UART011_DR_FE)
                                 uap->port.icount.frame++;
-                        if (rsr & UART01x_RSR_OE)
+                        if (ch & UART011_DR_OE)
                                 uap->port.icount.overrun++;
 
-                        rsr &= uap->port.read_status_mask;
+                        ch &= uap->port.read_status_mask;
 
-                        if (rsr & UART01x_RSR_BE)
+                        if (ch & UART011_DR_BE)
                                 flag = TTY_BREAK;
-                        else if (rsr & UART01x_RSR_PE)
+                        else if (ch & UART011_DR_PE)
                                 flag = TTY_PARITY;
-                        else if (rsr & UART01x_RSR_FE)
+                        else if (ch & UART011_DR_FE)
                                 flag = TTY_FRAME;
                 }
 
                 if (uart_handle_sysrq_char(&uap->port, ch, regs))
                         goto ignore_char;
 
-                uart_insert_char(&uap->port, rsr, UART01x_RSR_OE, ch, flag);
+                uart_insert_char(&uap->port, ch, UART011_DR_OE, ch, flag);
 
         ignore_char:
                 status = readw(uap->port.membase + UART01x_FR);
@@ -476,33 +475,33 @@ pl011_set_termios(struct uart_port *port, struct termios *termios,
          */
         uart_update_timeout(port, termios->c_cflag, baud);
 
-        port->read_status_mask = UART01x_RSR_OE;
+        port->read_status_mask = UART011_DR_OE | 255;
         if (termios->c_iflag & INPCK)
-                port->read_status_mask |= UART01x_RSR_FE | UART01x_RSR_PE;
+                port->read_status_mask |= UART011_DR_FE | UART011_DR_PE;
         if (termios->c_iflag & (BRKINT | PARMRK))
-                port->read_status_mask |= UART01x_RSR_BE;
+                port->read_status_mask |= UART011_DR_BE;
 
         /*
          * Characters to ignore
          */
         port->ignore_status_mask = 0;
         if (termios->c_iflag & IGNPAR)
-                port->ignore_status_mask |= UART01x_RSR_FE | UART01x_RSR_PE;
+                port->ignore_status_mask |= UART011_DR_FE | UART011_DR_PE;
         if (termios->c_iflag & IGNBRK) {
-                port->ignore_status_mask |= UART01x_RSR_BE;
+                port->ignore_status_mask |= UART011_DR_BE;
                 /*
                  * If we're ignoring parity and break indicators,
                  * ignore overruns too (for real raw support).
                  */
                 if (termios->c_iflag & IGNPAR)
-                        port->ignore_status_mask |= UART01x_RSR_OE;
+                        port->ignore_status_mask |= UART011_DR_OE;
         }
 
         /*
          * Ignore all characters if CREAD is not set.
          */
         if ((termios->c_cflag & CREAD) == 0)
-                port->ignore_status_mask |= UART_DUMMY_RSR_RX;
+                port->ignore_status_mask |= UART_DUMMY_DR_RX;
 
         if (UART_ENABLE_MS(port, termios->c_cflag))
                 pl011_enable_ms(port);
diff --git a/drivers/serial/sa1100.c b/drivers/serial/sa1100.c
index 0e3daf6d7b50..25a086458ab9 100644
--- a/drivers/serial/sa1100.c
+++ b/drivers/serial/sa1100.c
@@ -161,7 +161,6 @@ static void sa1100_stop_tx(struct uart_port *port)
 static void sa1100_start_tx(struct uart_port *port)
 {
         struct sa1100_port *sport = (struct sa1100_port *)port;
-        unsigned long flags;
         u32 utcr3;
 
         utcr3 = UART_GET_UTCR3(sport);