aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorWolfram Sang <w.sang@pengutronix.de>2010-11-15 16:40:38 -0500
committerJean Delvare <khali@endymion.delvare>2010-11-15 16:40:38 -0500
commitdc6641be0ea8819ef095fdcefc2b695611999a21 (patch)
tree24ec163d5ec01cd7b65811b738a3024ea6c5fef1 /drivers
parent0143832cc96d0bf78486297aad5c8fb2c2ead02a (diff)
i2c: Remove obsolete cleanup for clientdata
A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit. This is obsolete meanwhile, so fix it and hope the word will spread. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Acked-by: Alan Cox <alan@linux.intel.com> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/media/video/imx074.c2
-rw-r--r--drivers/media/video/ov6650.c2
-rw-r--r--drivers/misc/apds9802als.c1
-rw-r--r--drivers/staging/olpc_dcon/olpc_dcon.c3
4 files changed, 0 insertions, 8 deletions
diff --git a/drivers/media/video/imx074.c b/drivers/media/video/imx074.c
index 380e459f899d..27b5dfdfbb93 100644
--- a/drivers/media/video/imx074.c
+++ b/drivers/media/video/imx074.c
@@ -451,7 +451,6 @@ static int imx074_probe(struct i2c_client *client,
451 ret = imx074_video_probe(icd, client); 451 ret = imx074_video_probe(icd, client);
452 if (ret < 0) { 452 if (ret < 0) {
453 icd->ops = NULL; 453 icd->ops = NULL;
454 i2c_set_clientdata(client, NULL);
455 kfree(priv); 454 kfree(priv);
456 return ret; 455 return ret;
457 } 456 }
@@ -468,7 +467,6 @@ static int imx074_remove(struct i2c_client *client)
468 icd->ops = NULL; 467 icd->ops = NULL;
469 if (icl->free_bus) 468 if (icl->free_bus)
470 icl->free_bus(icl); 469 icl->free_bus(icl);
471 i2c_set_clientdata(client, NULL);
472 client->driver = NULL; 470 client->driver = NULL;
473 kfree(priv); 471 kfree(priv);
474 472
diff --git a/drivers/media/video/ov6650.c b/drivers/media/video/ov6650.c
index 31f19373bbae..cf93de988068 100644
--- a/drivers/media/video/ov6650.c
+++ b/drivers/media/video/ov6650.c
@@ -1174,7 +1174,6 @@ static int ov6650_probe(struct i2c_client *client,
1174 1174
1175 if (ret) { 1175 if (ret) {
1176 icd->ops = NULL; 1176 icd->ops = NULL;
1177 i2c_set_clientdata(client, NULL);
1178 kfree(priv); 1177 kfree(priv);
1179 } 1178 }
1180 1179
@@ -1185,7 +1184,6 @@ static int ov6650_remove(struct i2c_client *client)
1185{ 1184{
1186 struct ov6650 *priv = to_ov6650(client); 1185 struct ov6650 *priv = to_ov6650(client);
1187 1186
1188 i2c_set_clientdata(client, NULL);
1189 kfree(priv); 1187 kfree(priv);
1190 return 0; 1188 return 0;
1191} 1189}
diff --git a/drivers/misc/apds9802als.c b/drivers/misc/apds9802als.c
index 0ed09358027e..644d4cd071cc 100644
--- a/drivers/misc/apds9802als.c
+++ b/drivers/misc/apds9802als.c
@@ -251,7 +251,6 @@ static int apds9802als_probe(struct i2c_client *client,
251 251
252 return res; 252 return res;
253als_error1: 253als_error1:
254 i2c_set_clientdata(client, NULL);
255 kfree(data); 254 kfree(data);
256 return res; 255 return res;
257} 256}
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
index 75aa7a36307d..f286a4c56f66 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -733,7 +733,6 @@ static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)
733 edev: 733 edev:
734 platform_device_unregister(dcon_device); 734 platform_device_unregister(dcon_device);
735 dcon_device = NULL; 735 dcon_device = NULL;
736 i2c_set_clientdata(client, NULL);
737 eirq: 736 eirq:
738 free_irq(DCON_IRQ, &dcon_driver); 737 free_irq(DCON_IRQ, &dcon_driver);
739 einit: 738 einit:
@@ -757,8 +756,6 @@ static int dcon_remove(struct i2c_client *client)
757 platform_device_unregister(dcon_device); 756 platform_device_unregister(dcon_device);
758 cancel_work_sync(&dcon_work); 757 cancel_work_sync(&dcon_work);
759 758
760 i2c_set_clientdata(client, NULL);
761
762 return 0; 759 return 0;
763} 760}
764 761