diff options
author | Chris Metcalf <cmetcalf@tilera.com> | 2010-07-06 04:03:16 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2010-07-08 21:28:24 -0400 |
commit | 4455b1191cabbf7ecada800b7cfeccddb0af2b3a (patch) | |
tree | 3c9ddd34f60718085050f63b59a51a90b596d806 /drivers | |
parent | 32d8ad4e621d6620e925cf540ef1d35aa6fa5a7b (diff) |
hvc_console: use "*_console" nomenclature to avoid modpost warning.
The use of "hvc_con_driver" as the name for a file-static "struct
console" with a ".setup" field pointing to an __init function causes
a modpost warning, since a non-initdata structure points to init code.
Using "hvc_console" as the name triggers the hacky "*_console"
workaround in modpost to silence the warning, and is the same thing
that most of the other console drivers already do.
I made the same change in hvsi.c since I happened to notice it was
likely to suffer from the same problem.
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/char/hvc_console.c | 12 | ||||
-rw-r--r-- | drivers/char/hvsi.c | 4 |
2 files changed, 8 insertions, 8 deletions
diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c index 35cca4c7fb18..fa27d1676ee5 100644 --- a/drivers/char/hvc_console.c +++ b/drivers/char/hvc_console.c | |||
@@ -194,7 +194,7 @@ static int __init hvc_console_setup(struct console *co, char *options) | |||
194 | return 0; | 194 | return 0; |
195 | } | 195 | } |
196 | 196 | ||
197 | static struct console hvc_con_driver = { | 197 | static struct console hvc_console = { |
198 | .name = "hvc", | 198 | .name = "hvc", |
199 | .write = hvc_console_print, | 199 | .write = hvc_console_print, |
200 | .device = hvc_console_device, | 200 | .device = hvc_console_device, |
@@ -220,7 +220,7 @@ static struct console hvc_con_driver = { | |||
220 | */ | 220 | */ |
221 | static int __init hvc_console_init(void) | 221 | static int __init hvc_console_init(void) |
222 | { | 222 | { |
223 | register_console(&hvc_con_driver); | 223 | register_console(&hvc_console); |
224 | return 0; | 224 | return 0; |
225 | } | 225 | } |
226 | console_initcall(hvc_console_init); | 226 | console_initcall(hvc_console_init); |
@@ -276,8 +276,8 @@ int hvc_instantiate(uint32_t vtermno, int index, const struct hv_ops *ops) | |||
276 | * now (setup won't fail at this point). It's ok to just | 276 | * now (setup won't fail at this point). It's ok to just |
277 | * call register again if previously .setup failed. | 277 | * call register again if previously .setup failed. |
278 | */ | 278 | */ |
279 | if (index == hvc_con_driver.index) | 279 | if (index == hvc_console.index) |
280 | register_console(&hvc_con_driver); | 280 | register_console(&hvc_console); |
281 | 281 | ||
282 | return 0; | 282 | return 0; |
283 | } | 283 | } |
@@ -641,7 +641,7 @@ int hvc_poll(struct hvc_struct *hp) | |||
641 | } | 641 | } |
642 | for (i = 0; i < n; ++i) { | 642 | for (i = 0; i < n; ++i) { |
643 | #ifdef CONFIG_MAGIC_SYSRQ | 643 | #ifdef CONFIG_MAGIC_SYSRQ |
644 | if (hp->index == hvc_con_driver.index) { | 644 | if (hp->index == hvc_console.index) { |
645 | /* Handle the SysRq Hack */ | 645 | /* Handle the SysRq Hack */ |
646 | /* XXX should support a sequence */ | 646 | /* XXX should support a sequence */ |
647 | if (buf[i] == '\x0f') { /* ^O */ | 647 | if (buf[i] == '\x0f') { /* ^O */ |
@@ -909,7 +909,7 @@ static void __exit hvc_exit(void) | |||
909 | tty_unregister_driver(hvc_driver); | 909 | tty_unregister_driver(hvc_driver); |
910 | /* return tty_struct instances allocated in hvc_init(). */ | 910 | /* return tty_struct instances allocated in hvc_init(). */ |
911 | put_tty_driver(hvc_driver); | 911 | put_tty_driver(hvc_driver); |
912 | unregister_console(&hvc_con_driver); | 912 | unregister_console(&hvc_console); |
913 | } | 913 | } |
914 | } | 914 | } |
915 | module_exit(hvc_exit); | 915 | module_exit(hvc_exit); |
diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c index d4b14ff1c4c1..1f4b6de65a2d 100644 --- a/drivers/char/hvsi.c +++ b/drivers/char/hvsi.c | |||
@@ -1255,7 +1255,7 @@ static int __init hvsi_console_setup(struct console *console, char *options) | |||
1255 | return 0; | 1255 | return 0; |
1256 | } | 1256 | } |
1257 | 1257 | ||
1258 | static struct console hvsi_con_driver = { | 1258 | static struct console hvsi_console = { |
1259 | .name = "hvsi", | 1259 | .name = "hvsi", |
1260 | .write = hvsi_console_print, | 1260 | .write = hvsi_console_print, |
1261 | .device = hvsi_console_device, | 1261 | .device = hvsi_console_device, |
@@ -1308,7 +1308,7 @@ static int __init hvsi_console_init(void) | |||
1308 | } | 1308 | } |
1309 | 1309 | ||
1310 | if (hvsi_count) | 1310 | if (hvsi_count) |
1311 | register_console(&hvsi_con_driver); | 1311 | register_console(&hvsi_console); |
1312 | return 0; | 1312 | return 0; |
1313 | } | 1313 | } |
1314 | console_initcall(hvsi_console_init); | 1314 | console_initcall(hvsi_console_init); |