aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorChristian Lamparter <chunkeey@web.de>2008-12-17 06:04:43 -0500
committerJohn W. Linville <linville@tuxdriver.com>2008-12-19 15:23:47 -0500
commit6110781af080c007b2202187a8518920e03d5748 (patch)
treeaff117dc62ebad2ba545668c9d15ae6dffdfd24a /drivers
parent6ace2891a1d632303283816ae050849da48df142 (diff)
p54usb: bring first generation devices back to life
This patch fixes a serious regression (introduced by: "p54: fix memory management") that affected isl3886+net2280 usb devices operation. Signed-off-by: Christian Lamparter <chunkeey@web.de> Tested-by: Artur Skawina <art.08.09@gmail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/wireless/p54/p54usb.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb.c
index 17f89c7eb098..c44a200059d2 100644
--- a/drivers/net/wireless/p54/p54usb.c
+++ b/drivers/net/wireless/p54/p54usb.c
@@ -301,6 +301,8 @@ static void p54u_tx_net2280(struct ieee80211_hw *dev, struct sk_buff *skb)
301 struct net2280_tx_hdr *hdr; 301 struct net2280_tx_hdr *hdr;
302 struct net2280_reg_write *reg; 302 struct net2280_reg_write *reg;
303 int err = 0; 303 int err = 0;
304 __le32 addr = ((struct p54_hdr *) skb->data)->req_id;
305 __le16 len = cpu_to_le16(skb->len);
304 306
305 reg = kmalloc(sizeof(*reg), GFP_ATOMIC); 307 reg = kmalloc(sizeof(*reg), GFP_ATOMIC);
306 if (!reg) 308 if (!reg)
@@ -325,8 +327,8 @@ static void p54u_tx_net2280(struct ieee80211_hw *dev, struct sk_buff *skb)
325 327
326 hdr = (void *)skb_push(skb, sizeof(*hdr)); 328 hdr = (void *)skb_push(skb, sizeof(*hdr));
327 memset(hdr, 0, sizeof(*hdr)); 329 memset(hdr, 0, sizeof(*hdr));
328 hdr->device_addr = ((struct p54_hdr *)skb->data)->req_id; 330 hdr->len = len;
329 hdr->len = cpu_to_le16(skb->len + sizeof(struct p54_hdr)); 331 hdr->device_addr = addr;
330 332
331 usb_fill_bulk_urb(int_urb, priv->udev, 333 usb_fill_bulk_urb(int_urb, priv->udev,
332 usb_sndbulkpipe(priv->udev, P54U_PIPE_DEV), reg, sizeof(*reg), 334 usb_sndbulkpipe(priv->udev, P54U_PIPE_DEV), reg, sizeof(*reg),