aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-08-12 03:40:30 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2010-10-22 13:21:19 -0400
commitc6a76781da6b7ee2589a6ec87be30abdbc303384 (patch)
tree84443f9144aa0d260086e640fd0c9298b26e9ff3 /drivers
parent912c93d1606f60932de3e2f31db3722a9f069ed9 (diff)
USB: gadget: dbgp: cleanup: remove unneeded check
len is always greater than or equal to zero here. First of all, it's type is unsigned and also we only assign it numbers which are greater than or equal to zero. Removing the check lets us pull everything in an indent level. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Stephane duverger <stephane.duverger@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/gadget/dbgp.c16
1 files changed, 7 insertions, 9 deletions
diff --git a/drivers/usb/gadget/dbgp.c b/drivers/usb/gadget/dbgp.c
index 0ed50a2c0a36..abe4a2ec5625 100644
--- a/drivers/usb/gadget/dbgp.c
+++ b/drivers/usb/gadget/dbgp.c
@@ -386,15 +386,13 @@ static int dbgp_setup(struct usb_gadget *gadget,
386 } else 386 } else
387 goto fail; 387 goto fail;
388 388
389 if (len >= 0) { 389 req->length = min(length, len);
390 req->length = min(length, len); 390 req->zero = len < req->length;
391 req->zero = len < req->length; 391 if (data && req->length)
392 if (data && req->length) 392 memcpy(req->buf, data, req->length);
393 memcpy(req->buf, data, req->length); 393
394 394 req->complete = dbgp_setup_complete;
395 req->complete = dbgp_setup_complete; 395 return usb_ep_queue(gadget->ep0, req, GFP_ATOMIC);
396 return usb_ep_queue(gadget->ep0, req, GFP_ATOMIC);
397 }
398 396
399fail: 397fail:
400 dev_dbg(&dbgp.gadget->dev, 398 dev_dbg(&dbgp.gadget->dev,