diff options
author | Linus Torvalds <torvalds@g5.osdl.org> | 2006-04-02 15:58:45 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-04-02 15:58:45 -0400 |
commit | 63589ed0785ffc715777a54ccb96cdfaea9edbc0 (patch) | |
tree | 8ef3e50b7f87a5a2f5b0d96d1e22a1277c2381c0 /drivers | |
parent | 24c7cd0630f76f0eb081d539c53893d9f15787e8 (diff) | |
parent | a580290c3e64bb695158a090d02d1232d9609311 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial
* git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial: (48 commits)
Documentation: fix minor kernel-doc warnings
BUG_ON() Conversion in drivers/net/
BUG_ON() Conversion in drivers/s390/net/lcs.c
BUG_ON() Conversion in mm/slab.c
BUG_ON() Conversion in mm/highmem.c
BUG_ON() Conversion in kernel/signal.c
BUG_ON() Conversion in kernel/signal.c
BUG_ON() Conversion in kernel/ptrace.c
BUG_ON() Conversion in ipc/shm.c
BUG_ON() Conversion in fs/freevxfs/
BUG_ON() Conversion in fs/udf/
BUG_ON() Conversion in fs/sysv/
BUG_ON() Conversion in fs/inode.c
BUG_ON() Conversion in fs/fcntl.c
BUG_ON() Conversion in fs/dquot.c
BUG_ON() Conversion in md/raid10.c
BUG_ON() Conversion in md/raid6main.c
BUG_ON() Conversion in md/raid5.c
Fix minor documentation typo
BFP->BPF in Documentation/networking/tuntap.txt
...
Diffstat (limited to 'drivers')
29 files changed, 68 insertions, 148 deletions
diff --git a/drivers/md/dm-target.c b/drivers/md/dm-target.c index aecd9e0c2616..64fd8e79ea4c 100644 --- a/drivers/md/dm-target.c +++ b/drivers/md/dm-target.c | |||
@@ -78,8 +78,7 @@ void dm_put_target_type(struct target_type *t) | |||
78 | if (--ti->use == 0) | 78 | if (--ti->use == 0) |
79 | module_put(ti->tt.module); | 79 | module_put(ti->tt.module); |
80 | 80 | ||
81 | if (ti->use < 0) | 81 | BUG_ON(ti->use < 0); |
82 | BUG(); | ||
83 | up_read(&_lock); | 82 | up_read(&_lock); |
84 | 83 | ||
85 | return; | 84 | return; |
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 9b374c91db66..6081941de1b3 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c | |||
@@ -1558,8 +1558,7 @@ static int init_resync(conf_t *conf) | |||
1558 | int buffs; | 1558 | int buffs; |
1559 | 1559 | ||
1560 | buffs = RESYNC_WINDOW / RESYNC_BLOCK_SIZE; | 1560 | buffs = RESYNC_WINDOW / RESYNC_BLOCK_SIZE; |
1561 | if (conf->r1buf_pool) | 1561 | BUG_ON(conf->r1buf_pool); |
1562 | BUG(); | ||
1563 | conf->r1buf_pool = mempool_create(buffs, r1buf_pool_alloc, r1buf_pool_free, | 1562 | conf->r1buf_pool = mempool_create(buffs, r1buf_pool_alloc, r1buf_pool_free, |
1564 | conf->poolinfo); | 1563 | conf->poolinfo); |
1565 | if (!conf->r1buf_pool) | 1564 | if (!conf->r1buf_pool) |
@@ -1732,8 +1731,7 @@ static sector_t sync_request(mddev_t *mddev, sector_t sector_nr, int *skipped, i | |||
1732 | !conf->fullsync && | 1731 | !conf->fullsync && |
1733 | !test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery)) | 1732 | !test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery)) |
1734 | break; | 1733 | break; |
1735 | if (sync_blocks < (PAGE_SIZE>>9)) | 1734 | BUG_ON(sync_blocks < (PAGE_SIZE>>9)); |
1736 | BUG(); | ||
1737 | if (len > (sync_blocks<<9)) | 1735 | if (len > (sync_blocks<<9)) |
1738 | len = sync_blocks<<9; | 1736 | len = sync_blocks<<9; |
1739 | } | 1737 | } |
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index ab90a6d12020..617012bc107a 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c | |||
@@ -1117,8 +1117,7 @@ static int end_sync_read(struct bio *bio, unsigned int bytes_done, int error) | |||
1117 | for (i=0; i<conf->copies; i++) | 1117 | for (i=0; i<conf->copies; i++) |
1118 | if (r10_bio->devs[i].bio == bio) | 1118 | if (r10_bio->devs[i].bio == bio) |
1119 | break; | 1119 | break; |
1120 | if (i == conf->copies) | 1120 | BUG_ON(i == conf->copies); |
1121 | BUG(); | ||
1122 | update_head_pos(i, r10_bio); | 1121 | update_head_pos(i, r10_bio); |
1123 | d = r10_bio->devs[i].devnum; | 1122 | d = r10_bio->devs[i].devnum; |
1124 | 1123 | ||
@@ -1518,8 +1517,7 @@ static int init_resync(conf_t *conf) | |||
1518 | int buffs; | 1517 | int buffs; |
1519 | 1518 | ||
1520 | buffs = RESYNC_WINDOW / RESYNC_BLOCK_SIZE; | 1519 | buffs = RESYNC_WINDOW / RESYNC_BLOCK_SIZE; |
1521 | if (conf->r10buf_pool) | 1520 | BUG_ON(conf->r10buf_pool); |
1522 | BUG(); | ||
1523 | conf->r10buf_pool = mempool_create(buffs, r10buf_pool_alloc, r10buf_pool_free, conf); | 1521 | conf->r10buf_pool = mempool_create(buffs, r10buf_pool_alloc, r10buf_pool_free, conf); |
1524 | if (!conf->r10buf_pool) | 1522 | if (!conf->r10buf_pool) |
1525 | return -ENOMEM; | 1523 | return -ENOMEM; |
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index dae740adaf65..31843604049c 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c | |||
@@ -73,10 +73,8 @@ static void print_raid5_conf (raid5_conf_t *conf); | |||
73 | static void __release_stripe(raid5_conf_t *conf, struct stripe_head *sh) | 73 | static void __release_stripe(raid5_conf_t *conf, struct stripe_head *sh) |
74 | { | 74 | { |
75 | if (atomic_dec_and_test(&sh->count)) { | 75 | if (atomic_dec_and_test(&sh->count)) { |
76 | if (!list_empty(&sh->lru)) | 76 | BUG_ON(!list_empty(&sh->lru)); |
77 | BUG(); | 77 | BUG_ON(atomic_read(&conf->active_stripes)==0); |
78 | if (atomic_read(&conf->active_stripes)==0) | ||
79 | BUG(); | ||
80 | if (test_bit(STRIPE_HANDLE, &sh->state)) { | 78 | if (test_bit(STRIPE_HANDLE, &sh->state)) { |
81 | if (test_bit(STRIPE_DELAYED, &sh->state)) | 79 | if (test_bit(STRIPE_DELAYED, &sh->state)) |
82 | list_add_tail(&sh->lru, &conf->delayed_list); | 80 | list_add_tail(&sh->lru, &conf->delayed_list); |
@@ -184,10 +182,8 @@ static void init_stripe(struct stripe_head *sh, sector_t sector, int pd_idx, int | |||
184 | raid5_conf_t *conf = sh->raid_conf; | 182 | raid5_conf_t *conf = sh->raid_conf; |
185 | int i; | 183 | int i; |
186 | 184 | ||
187 | if (atomic_read(&sh->count) != 0) | 185 | BUG_ON(atomic_read(&sh->count) != 0); |
188 | BUG(); | 186 | BUG_ON(test_bit(STRIPE_HANDLE, &sh->state)); |
189 | if (test_bit(STRIPE_HANDLE, &sh->state)) | ||
190 | BUG(); | ||
191 | 187 | ||
192 | CHECK_DEVLOCK(); | 188 | CHECK_DEVLOCK(); |
193 | PRINTK("init_stripe called, stripe %llu\n", | 189 | PRINTK("init_stripe called, stripe %llu\n", |
@@ -269,8 +265,7 @@ static struct stripe_head *get_active_stripe(raid5_conf_t *conf, sector_t sector | |||
269 | init_stripe(sh, sector, pd_idx, disks); | 265 | init_stripe(sh, sector, pd_idx, disks); |
270 | } else { | 266 | } else { |
271 | if (atomic_read(&sh->count)) { | 267 | if (atomic_read(&sh->count)) { |
272 | if (!list_empty(&sh->lru)) | 268 | BUG_ON(!list_empty(&sh->lru)); |
273 | BUG(); | ||
274 | } else { | 269 | } else { |
275 | if (!test_bit(STRIPE_HANDLE, &sh->state)) | 270 | if (!test_bit(STRIPE_HANDLE, &sh->state)) |
276 | atomic_inc(&conf->active_stripes); | 271 | atomic_inc(&conf->active_stripes); |
@@ -465,8 +460,7 @@ static int drop_one_stripe(raid5_conf_t *conf) | |||
465 | spin_unlock_irq(&conf->device_lock); | 460 | spin_unlock_irq(&conf->device_lock); |
466 | if (!sh) | 461 | if (!sh) |
467 | return 0; | 462 | return 0; |
468 | if (atomic_read(&sh->count)) | 463 | BUG_ON(atomic_read(&sh->count)); |
469 | BUG(); | ||
470 | shrink_buffers(sh, conf->pool_size); | 464 | shrink_buffers(sh, conf->pool_size); |
471 | kmem_cache_free(conf->slab_cache, sh); | 465 | kmem_cache_free(conf->slab_cache, sh); |
472 | atomic_dec(&conf->active_stripes); | 466 | atomic_dec(&conf->active_stripes); |
@@ -882,8 +876,7 @@ static void compute_parity(struct stripe_head *sh, int method) | |||
882 | ptr[0] = page_address(sh->dev[pd_idx].page); | 876 | ptr[0] = page_address(sh->dev[pd_idx].page); |
883 | switch(method) { | 877 | switch(method) { |
884 | case READ_MODIFY_WRITE: | 878 | case READ_MODIFY_WRITE: |
885 | if (!test_bit(R5_UPTODATE, &sh->dev[pd_idx].flags)) | 879 | BUG_ON(!test_bit(R5_UPTODATE, &sh->dev[pd_idx].flags)); |
886 | BUG(); | ||
887 | for (i=disks ; i-- ;) { | 880 | for (i=disks ; i-- ;) { |
888 | if (i==pd_idx) | 881 | if (i==pd_idx) |
889 | continue; | 882 | continue; |
@@ -896,7 +889,7 @@ static void compute_parity(struct stripe_head *sh, int method) | |||
896 | if (test_and_clear_bit(R5_Overlap, &sh->dev[i].flags)) | 889 | if (test_and_clear_bit(R5_Overlap, &sh->dev[i].flags)) |
897 | wake_up(&conf->wait_for_overlap); | 890 | wake_up(&conf->wait_for_overlap); |
898 | 891 | ||
899 | if (sh->dev[i].written) BUG(); | 892 | BUG_ON(sh->dev[i].written); |
900 | sh->dev[i].written = chosen; | 893 | sh->dev[i].written = chosen; |
901 | check_xor(); | 894 | check_xor(); |
902 | } | 895 | } |
@@ -912,7 +905,7 @@ static void compute_parity(struct stripe_head *sh, int method) | |||
912 | if (test_and_clear_bit(R5_Overlap, &sh->dev[i].flags)) | 905 | if (test_and_clear_bit(R5_Overlap, &sh->dev[i].flags)) |
913 | wake_up(&conf->wait_for_overlap); | 906 | wake_up(&conf->wait_for_overlap); |
914 | 907 | ||
915 | if (sh->dev[i].written) BUG(); | 908 | BUG_ON(sh->dev[i].written); |
916 | sh->dev[i].written = chosen; | 909 | sh->dev[i].written = chosen; |
917 | } | 910 | } |
918 | break; | 911 | break; |
@@ -995,8 +988,7 @@ static int add_stripe_bio(struct stripe_head *sh, struct bio *bi, int dd_idx, in | |||
995 | if (*bip && (*bip)->bi_sector < bi->bi_sector + ((bi->bi_size)>>9)) | 988 | if (*bip && (*bip)->bi_sector < bi->bi_sector + ((bi->bi_size)>>9)) |
996 | goto overlap; | 989 | goto overlap; |
997 | 990 | ||
998 | if (*bip && bi->bi_next && (*bip) != bi->bi_next) | 991 | BUG_ON(*bip && bi->bi_next && (*bip) != bi->bi_next); |
999 | BUG(); | ||
1000 | if (*bip) | 992 | if (*bip) |
1001 | bi->bi_next = *bip; | 993 | bi->bi_next = *bip; |
1002 | *bip = bi; | 994 | *bip = bi; |
@@ -1430,8 +1422,7 @@ static void handle_stripe(struct stripe_head *sh) | |||
1430 | set_bit(STRIPE_HANDLE, &sh->state); | 1422 | set_bit(STRIPE_HANDLE, &sh->state); |
1431 | if (failed == 0) { | 1423 | if (failed == 0) { |
1432 | char *pagea; | 1424 | char *pagea; |
1433 | if (uptodate != disks) | 1425 | BUG_ON(uptodate != disks); |
1434 | BUG(); | ||
1435 | compute_parity(sh, CHECK_PARITY); | 1426 | compute_parity(sh, CHECK_PARITY); |
1436 | uptodate--; | 1427 | uptodate--; |
1437 | pagea = page_address(sh->dev[sh->pd_idx].page); | 1428 | pagea = page_address(sh->dev[sh->pd_idx].page); |
@@ -2096,8 +2087,7 @@ static void raid5d (mddev_t *mddev) | |||
2096 | 2087 | ||
2097 | list_del_init(first); | 2088 | list_del_init(first); |
2098 | atomic_inc(&sh->count); | 2089 | atomic_inc(&sh->count); |
2099 | if (atomic_read(&sh->count)!= 1) | 2090 | BUG_ON(atomic_read(&sh->count)!= 1); |
2100 | BUG(); | ||
2101 | spin_unlock_irq(&conf->device_lock); | 2091 | spin_unlock_irq(&conf->device_lock); |
2102 | 2092 | ||
2103 | handled++; | 2093 | handled++; |
diff --git a/drivers/md/raid6main.c b/drivers/md/raid6main.c index ab64b37e4996..bc69355e0100 100644 --- a/drivers/md/raid6main.c +++ b/drivers/md/raid6main.c | |||
@@ -91,10 +91,8 @@ static void print_raid6_conf (raid6_conf_t *conf); | |||
91 | static void __release_stripe(raid6_conf_t *conf, struct stripe_head *sh) | 91 | static void __release_stripe(raid6_conf_t *conf, struct stripe_head *sh) |
92 | { | 92 | { |
93 | if (atomic_dec_and_test(&sh->count)) { | 93 | if (atomic_dec_and_test(&sh->count)) { |
94 | if (!list_empty(&sh->lru)) | 94 | BUG_ON(!list_empty(&sh->lru)); |
95 | BUG(); | 95 | BUG_ON(atomic_read(&conf->active_stripes)==0); |
96 | if (atomic_read(&conf->active_stripes)==0) | ||
97 | BUG(); | ||
98 | if (test_bit(STRIPE_HANDLE, &sh->state)) { | 96 | if (test_bit(STRIPE_HANDLE, &sh->state)) { |
99 | if (test_bit(STRIPE_DELAYED, &sh->state)) | 97 | if (test_bit(STRIPE_DELAYED, &sh->state)) |
100 | list_add_tail(&sh->lru, &conf->delayed_list); | 98 | list_add_tail(&sh->lru, &conf->delayed_list); |
@@ -202,10 +200,8 @@ static void init_stripe(struct stripe_head *sh, sector_t sector, int pd_idx) | |||
202 | raid6_conf_t *conf = sh->raid_conf; | 200 | raid6_conf_t *conf = sh->raid_conf; |
203 | int disks = conf->raid_disks, i; | 201 | int disks = conf->raid_disks, i; |
204 | 202 | ||
205 | if (atomic_read(&sh->count) != 0) | 203 | BUG_ON(atomic_read(&sh->count) != 0); |
206 | BUG(); | 204 | BUG_ON(test_bit(STRIPE_HANDLE, &sh->state)); |
207 | if (test_bit(STRIPE_HANDLE, &sh->state)) | ||
208 | BUG(); | ||
209 | 205 | ||
210 | CHECK_DEVLOCK(); | 206 | CHECK_DEVLOCK(); |
211 | PRINTK("init_stripe called, stripe %llu\n", | 207 | PRINTK("init_stripe called, stripe %llu\n", |
@@ -284,13 +280,11 @@ static struct stripe_head *get_active_stripe(raid6_conf_t *conf, sector_t sector | |||
284 | init_stripe(sh, sector, pd_idx); | 280 | init_stripe(sh, sector, pd_idx); |
285 | } else { | 281 | } else { |
286 | if (atomic_read(&sh->count)) { | 282 | if (atomic_read(&sh->count)) { |
287 | if (!list_empty(&sh->lru)) | 283 | BUG_ON(!list_empty(&sh->lru)); |
288 | BUG(); | ||
289 | } else { | 284 | } else { |
290 | if (!test_bit(STRIPE_HANDLE, &sh->state)) | 285 | if (!test_bit(STRIPE_HANDLE, &sh->state)) |
291 | atomic_inc(&conf->active_stripes); | 286 | atomic_inc(&conf->active_stripes); |
292 | if (list_empty(&sh->lru)) | 287 | BUG_ON(list_empty(&sh->lru)); |
293 | BUG(); | ||
294 | list_del_init(&sh->lru); | 288 | list_del_init(&sh->lru); |
295 | } | 289 | } |
296 | } | 290 | } |
@@ -353,8 +347,7 @@ static int drop_one_stripe(raid6_conf_t *conf) | |||
353 | spin_unlock_irq(&conf->device_lock); | 347 | spin_unlock_irq(&conf->device_lock); |
354 | if (!sh) | 348 | if (!sh) |
355 | return 0; | 349 | return 0; |
356 | if (atomic_read(&sh->count)) | 350 | BUG_ON(atomic_read(&sh->count)); |
357 | BUG(); | ||
358 | shrink_buffers(sh, conf->raid_disks); | 351 | shrink_buffers(sh, conf->raid_disks); |
359 | kmem_cache_free(conf->slab_cache, sh); | 352 | kmem_cache_free(conf->slab_cache, sh); |
360 | atomic_dec(&conf->active_stripes); | 353 | atomic_dec(&conf->active_stripes); |
@@ -780,7 +773,7 @@ static void compute_parity(struct stripe_head *sh, int method) | |||
780 | if (test_and_clear_bit(R5_Overlap, &sh->dev[i].flags)) | 773 | if (test_and_clear_bit(R5_Overlap, &sh->dev[i].flags)) |
781 | wake_up(&conf->wait_for_overlap); | 774 | wake_up(&conf->wait_for_overlap); |
782 | 775 | ||
783 | if (sh->dev[i].written) BUG(); | 776 | BUG_ON(sh->dev[i].written); |
784 | sh->dev[i].written = chosen; | 777 | sh->dev[i].written = chosen; |
785 | } | 778 | } |
786 | break; | 779 | break; |
@@ -970,8 +963,7 @@ static int add_stripe_bio(struct stripe_head *sh, struct bio *bi, int dd_idx, in | |||
970 | if (*bip && (*bip)->bi_sector < bi->bi_sector + ((bi->bi_size)>>9)) | 963 | if (*bip && (*bip)->bi_sector < bi->bi_sector + ((bi->bi_size)>>9)) |
971 | goto overlap; | 964 | goto overlap; |
972 | 965 | ||
973 | if (*bip && bi->bi_next && (*bip) != bi->bi_next) | 966 | BUG_ON(*bip && bi->bi_next && (*bip) != bi->bi_next); |
974 | BUG(); | ||
975 | if (*bip) | 967 | if (*bip) |
976 | bi->bi_next = *bip; | 968 | bi->bi_next = *bip; |
977 | *bip = bi; | 969 | *bip = bi; |
@@ -1906,8 +1898,7 @@ static void raid6d (mddev_t *mddev) | |||
1906 | 1898 | ||
1907 | list_del_init(first); | 1899 | list_del_init(first); |
1908 | atomic_inc(&sh->count); | 1900 | atomic_inc(&sh->count); |
1909 | if (atomic_read(&sh->count)!= 1) | 1901 | BUG_ON(atomic_read(&sh->count)!= 1); |
1910 | BUG(); | ||
1911 | spin_unlock_irq(&conf->device_lock); | 1902 | spin_unlock_irq(&conf->device_lock); |
1912 | 1903 | ||
1913 | handled++; | 1904 | handled++; |
diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig index 0f6bb2e625d8..a7ec5954caf5 100644 --- a/drivers/mtd/chips/Kconfig +++ b/drivers/mtd/chips/Kconfig | |||
@@ -200,27 +200,6 @@ config MTD_CFI_AMDSTD | |||
200 | provides support for one of those command sets, used on chips | 200 | provides support for one of those command sets, used on chips |
201 | including the AMD Am29LV320. | 201 | including the AMD Am29LV320. |
202 | 202 | ||
203 | config MTD_CFI_AMDSTD_RETRY | ||
204 | int "Retry failed commands (erase/program)" | ||
205 | depends on MTD_CFI_AMDSTD | ||
206 | default "0" | ||
207 | help | ||
208 | Some chips, when attached to a shared bus, don't properly filter | ||
209 | bus traffic that is destined to other devices. This broken | ||
210 | behavior causes erase and program sequences to be aborted when | ||
211 | the sequences are mixed with traffic for other devices. | ||
212 | |||
213 | SST49LF040 (and related) chips are know to be broken. | ||
214 | |||
215 | config MTD_CFI_AMDSTD_RETRY_MAX | ||
216 | int "Max retries of failed commands (erase/program)" | ||
217 | depends on MTD_CFI_AMDSTD_RETRY | ||
218 | default "0" | ||
219 | help | ||
220 | If you have an SST49LF040 (or related chip) then this value should | ||
221 | be set to at least 1. This can also be adjusted at driver load | ||
222 | time with the retry_cmd_max module parameter. | ||
223 | |||
224 | config MTD_CFI_STAA | 203 | config MTD_CFI_STAA |
225 | tristate "Support for ST (Advanced Architecture) flash chips" | 204 | tristate "Support for ST (Advanced Architecture) flash chips" |
226 | depends on MTD_GEN_PROBE | 205 | depends on MTD_GEN_PROBE |
diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c index ce99845d8266..066e22b01a94 100644 --- a/drivers/net/8139cp.c +++ b/drivers/net/8139cp.c | |||
@@ -539,8 +539,7 @@ rx_status_loop: | |||
539 | unsigned buflen; | 539 | unsigned buflen; |
540 | 540 | ||
541 | skb = cp->rx_skb[rx_tail].skb; | 541 | skb = cp->rx_skb[rx_tail].skb; |
542 | if (!skb) | 542 | BUG_ON(!skb); |
543 | BUG(); | ||
544 | 543 | ||
545 | desc = &cp->rx_ring[rx_tail]; | 544 | desc = &cp->rx_ring[rx_tail]; |
546 | status = le32_to_cpu(desc->opts1); | 545 | status = le32_to_cpu(desc->opts1); |
@@ -723,8 +722,7 @@ static void cp_tx (struct cp_private *cp) | |||
723 | break; | 722 | break; |
724 | 723 | ||
725 | skb = cp->tx_skb[tx_tail].skb; | 724 | skb = cp->tx_skb[tx_tail].skb; |
726 | if (!skb) | 725 | BUG_ON(!skb); |
727 | BUG(); | ||
728 | 726 | ||
729 | pci_unmap_single(cp->pdev, cp->tx_skb[tx_tail].mapping, | 727 | pci_unmap_single(cp->pdev, cp->tx_skb[tx_tail].mapping, |
730 | cp->tx_skb[tx_tail].len, PCI_DMA_TODEVICE); | 728 | cp->tx_skb[tx_tail].len, PCI_DMA_TODEVICE); |
@@ -1550,8 +1548,7 @@ static void cp_get_ethtool_stats (struct net_device *dev, | |||
1550 | tmp_stats[i++] = le16_to_cpu(nic_stats->tx_abort); | 1548 | tmp_stats[i++] = le16_to_cpu(nic_stats->tx_abort); |
1551 | tmp_stats[i++] = le16_to_cpu(nic_stats->tx_underrun); | 1549 | tmp_stats[i++] = le16_to_cpu(nic_stats->tx_underrun); |
1552 | tmp_stats[i++] = cp->cp_stats.rx_frags; | 1550 | tmp_stats[i++] = cp->cp_stats.rx_frags; |
1553 | if (i != CP_NUM_STATS) | 1551 | BUG_ON(i != CP_NUM_STATS); |
1554 | BUG(); | ||
1555 | 1552 | ||
1556 | pci_free_consistent(cp->pdev, sizeof(*nic_stats), nic_stats, dma); | 1553 | pci_free_consistent(cp->pdev, sizeof(*nic_stats), nic_stats, dma); |
1557 | } | 1554 | } |
@@ -1856,8 +1853,7 @@ static void cp_remove_one (struct pci_dev *pdev) | |||
1856 | struct net_device *dev = pci_get_drvdata(pdev); | 1853 | struct net_device *dev = pci_get_drvdata(pdev); |
1857 | struct cp_private *cp = netdev_priv(dev); | 1854 | struct cp_private *cp = netdev_priv(dev); |
1858 | 1855 | ||
1859 | if (!dev) | 1856 | BUG_ON(!dev); |
1860 | BUG(); | ||
1861 | unregister_netdev(dev); | 1857 | unregister_netdev(dev); |
1862 | iounmap(cp->regs); | 1858 | iounmap(cp->regs); |
1863 | if (cp->wol_enabled) pci_set_power_state (pdev, PCI_D0); | 1859 | if (cp->wol_enabled) pci_set_power_state (pdev, PCI_D0); |
diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c index 64e2caf3083d..fabc0607b0f1 100644 --- a/drivers/net/arcnet/arcnet.c +++ b/drivers/net/arcnet/arcnet.c | |||
@@ -765,8 +765,7 @@ irqreturn_t arcnet_interrupt(int irq, void *dev_id, struct pt_regs *regs) | |||
765 | BUGMSG(D_DURING, "in arcnet_interrupt\n"); | 765 | BUGMSG(D_DURING, "in arcnet_interrupt\n"); |
766 | 766 | ||
767 | lp = dev->priv; | 767 | lp = dev->priv; |
768 | if (!lp) | 768 | BUG_ON(!lp); |
769 | BUG(); | ||
770 | 769 | ||
771 | spin_lock(&lp->lock); | 770 | spin_lock(&lp->lock); |
772 | 771 | ||
diff --git a/drivers/net/b44.c b/drivers/net/b44.c index 15032f2c7817..c4e12b5cbb92 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c | |||
@@ -608,8 +608,7 @@ static void b44_tx(struct b44 *bp) | |||
608 | struct ring_info *rp = &bp->tx_buffers[cons]; | 608 | struct ring_info *rp = &bp->tx_buffers[cons]; |
609 | struct sk_buff *skb = rp->skb; | 609 | struct sk_buff *skb = rp->skb; |
610 | 610 | ||
611 | if (unlikely(skb == NULL)) | 611 | BUG_ON(skb == NULL); |
612 | BUG(); | ||
613 | 612 | ||
614 | pci_unmap_single(bp->pdev, | 613 | pci_unmap_single(bp->pdev, |
615 | pci_unmap_addr(rp, mapping), | 614 | pci_unmap_addr(rp, mapping), |
diff --git a/drivers/net/chelsio/sge.c b/drivers/net/chelsio/sge.c index 30ff8ea1a402..4391bf4bf573 100644 --- a/drivers/net/chelsio/sge.c +++ b/drivers/net/chelsio/sge.c | |||
@@ -1093,8 +1093,7 @@ static int process_responses(struct adapter *adapter, int budget) | |||
1093 | if (likely(e->DataValid)) { | 1093 | if (likely(e->DataValid)) { |
1094 | struct freelQ *fl = &sge->freelQ[e->FreelistQid]; | 1094 | struct freelQ *fl = &sge->freelQ[e->FreelistQid]; |
1095 | 1095 | ||
1096 | if (unlikely(!e->Sop || !e->Eop)) | 1096 | BUG_ON(!e->Sop || !e->Eop); |
1097 | BUG(); | ||
1098 | if (unlikely(e->Offload)) | 1097 | if (unlikely(e->Offload)) |
1099 | unexpected_offload(adapter, fl); | 1098 | unexpected_offload(adapter, fl); |
1100 | else | 1099 | else |
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 49cd096a3c3d..add8dc4aa7b0 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c | |||
@@ -3308,8 +3308,7 @@ e1000_clean(struct net_device *poll_dev, int *budget) | |||
3308 | 3308 | ||
3309 | while (poll_dev != &adapter->polling_netdev[i]) { | 3309 | while (poll_dev != &adapter->polling_netdev[i]) { |
3310 | i++; | 3310 | i++; |
3311 | if (unlikely(i == adapter->num_rx_queues)) | 3311 | BUG_ON(i == adapter->num_rx_queues); |
3312 | BUG(); | ||
3313 | } | 3312 | } |
3314 | 3313 | ||
3315 | if (likely(adapter->num_tx_queues == 1)) { | 3314 | if (likely(adapter->num_tx_queues == 1)) { |
diff --git a/drivers/net/eql.c b/drivers/net/eql.c index aa1569182fd6..815436c6170f 100644 --- a/drivers/net/eql.c +++ b/drivers/net/eql.c | |||
@@ -203,8 +203,7 @@ static int eql_open(struct net_device *dev) | |||
203 | printk(KERN_INFO "%s: remember to turn off Van-Jacobson compression on " | 203 | printk(KERN_INFO "%s: remember to turn off Van-Jacobson compression on " |
204 | "your slave devices.\n", dev->name); | 204 | "your slave devices.\n", dev->name); |
205 | 205 | ||
206 | if (!list_empty(&eql->queue.all_slaves)) | 206 | BUG_ON(!list_empty(&eql->queue.all_slaves)); |
207 | BUG(); | ||
208 | 207 | ||
209 | eql->min_slaves = 1; | 208 | eql->min_slaves = 1; |
210 | eql->max_slaves = EQL_DEFAULT_MAX_SLAVES; /* 4 usually... */ | 209 | eql->max_slaves = EQL_DEFAULT_MAX_SLAVES; /* 4 usually... */ |
diff --git a/drivers/net/irda/sa1100_ir.c b/drivers/net/irda/sa1100_ir.c index 63d38fbbd04e..f530686bd09f 100644 --- a/drivers/net/irda/sa1100_ir.c +++ b/drivers/net/irda/sa1100_ir.c | |||
@@ -695,8 +695,7 @@ static int sa1100_irda_hard_xmit(struct sk_buff *skb, struct net_device *dev) | |||
695 | /* | 695 | /* |
696 | * We must not be transmitting... | 696 | * We must not be transmitting... |
697 | */ | 697 | */ |
698 | if (si->txskb) | 698 | BUG_ON(si->txskb); |
699 | BUG(); | ||
700 | 699 | ||
701 | netif_stop_queue(dev); | 700 | netif_stop_queue(dev); |
702 | 701 | ||
diff --git a/drivers/net/ne2k-pci.c b/drivers/net/ne2k-pci.c index d11821dd86ed..ced9fdb8335c 100644 --- a/drivers/net/ne2k-pci.c +++ b/drivers/net/ne2k-pci.c | |||
@@ -645,9 +645,7 @@ static void __devexit ne2k_pci_remove_one (struct pci_dev *pdev) | |||
645 | { | 645 | { |
646 | struct net_device *dev = pci_get_drvdata(pdev); | 646 | struct net_device *dev = pci_get_drvdata(pdev); |
647 | 647 | ||
648 | if (!dev) | 648 | BUG_ON(!dev); |
649 | BUG(); | ||
650 | |||
651 | unregister_netdev(dev); | 649 | unregister_netdev(dev); |
652 | release_region(dev->base_addr, NE_IO_EXTENT); | 650 | release_region(dev->base_addr, NE_IO_EXTENT); |
653 | free_netdev(dev); | 651 | free_netdev(dev); |
diff --git a/drivers/net/ns83820.c b/drivers/net/ns83820.c index 8e9b1a537dee..706aed7d717f 100644 --- a/drivers/net/ns83820.c +++ b/drivers/net/ns83820.c | |||
@@ -568,8 +568,7 @@ static inline int ns83820_add_rx_skb(struct ns83820 *dev, struct sk_buff *skb) | |||
568 | #endif | 568 | #endif |
569 | 569 | ||
570 | sg = dev->rx_info.descs + (next_empty * DESC_SIZE); | 570 | sg = dev->rx_info.descs + (next_empty * DESC_SIZE); |
571 | if (unlikely(NULL != dev->rx_info.skbs[next_empty])) | 571 | BUG_ON(NULL != dev->rx_info.skbs[next_empty]); |
572 | BUG(); | ||
573 | dev->rx_info.skbs[next_empty] = skb; | 572 | dev->rx_info.skbs[next_empty] = skb; |
574 | 573 | ||
575 | dev->rx_info.next_empty = (next_empty + 1) % NR_RX_DESC; | 574 | dev->rx_info.next_empty = (next_empty + 1) % NR_RX_DESC; |
diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c index 35b18057fbdd..45ad036733e2 100644 --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c | |||
@@ -2122,8 +2122,7 @@ static void __devexit starfire_remove_one (struct pci_dev *pdev) | |||
2122 | struct net_device *dev = pci_get_drvdata(pdev); | 2122 | struct net_device *dev = pci_get_drvdata(pdev); |
2123 | struct netdev_private *np = netdev_priv(dev); | 2123 | struct netdev_private *np = netdev_priv(dev); |
2124 | 2124 | ||
2125 | if (!dev) | 2125 | BUG_ON(!dev); |
2126 | BUG(); | ||
2127 | 2126 | ||
2128 | unregister_netdev(dev); | 2127 | unregister_netdev(dev); |
2129 | 2128 | ||
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 770e6b6cec60..0b5358072172 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c | |||
@@ -2959,9 +2959,7 @@ static void tg3_tx(struct tg3 *tp) | |||
2959 | struct sk_buff *skb = ri->skb; | 2959 | struct sk_buff *skb = ri->skb; |
2960 | int i; | 2960 | int i; |
2961 | 2961 | ||
2962 | if (unlikely(skb == NULL)) | 2962 | BUG_ON(skb == NULL); |
2963 | BUG(); | ||
2964 | |||
2965 | pci_unmap_single(tp->pdev, | 2963 | pci_unmap_single(tp->pdev, |
2966 | pci_unmap_addr(ri, mapping), | 2964 | pci_unmap_addr(ri, mapping), |
2967 | skb_headlen(skb), | 2965 | skb_headlen(skb), |
@@ -2972,12 +2970,10 @@ static void tg3_tx(struct tg3 *tp) | |||
2972 | sw_idx = NEXT_TX(sw_idx); | 2970 | sw_idx = NEXT_TX(sw_idx); |
2973 | 2971 | ||
2974 | for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { | 2972 | for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { |
2975 | if (unlikely(sw_idx == hw_idx)) | 2973 | BUG_ON(sw_idx == hw_idx); |
2976 | BUG(); | ||
2977 | 2974 | ||
2978 | ri = &tp->tx_buffers[sw_idx]; | 2975 | ri = &tp->tx_buffers[sw_idx]; |
2979 | if (unlikely(ri->skb != NULL)) | 2976 | BUG_ON(ri->skb != NULL); |
2980 | BUG(); | ||
2981 | 2977 | ||
2982 | pci_unmap_page(tp->pdev, | 2978 | pci_unmap_page(tp->pdev, |
2983 | pci_unmap_addr(ri, mapping), | 2979 | pci_unmap_addr(ri, mapping), |
@@ -4928,9 +4924,8 @@ static int tg3_halt_cpu(struct tg3 *tp, u32 offset) | |||
4928 | { | 4924 | { |
4929 | int i; | 4925 | int i; |
4930 | 4926 | ||
4931 | if (offset == TX_CPU_BASE && | 4927 | BUG_ON(offset == TX_CPU_BASE && |
4932 | (tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) | 4928 | (tp->tg3_flags2 & TG3_FLG2_5705_PLUS)); |
4933 | BUG(); | ||
4934 | 4929 | ||
4935 | if (offset == RX_CPU_BASE) { | 4930 | if (offset == RX_CPU_BASE) { |
4936 | for (i = 0; i < 10000; i++) { | 4931 | for (i = 0; i < 10000; i++) { |
diff --git a/drivers/net/tokenring/abyss.c b/drivers/net/tokenring/abyss.c index 9345e68c451e..649d8ea354f5 100644 --- a/drivers/net/tokenring/abyss.c +++ b/drivers/net/tokenring/abyss.c | |||
@@ -438,8 +438,7 @@ static void __devexit abyss_detach (struct pci_dev *pdev) | |||
438 | { | 438 | { |
439 | struct net_device *dev = pci_get_drvdata(pdev); | 439 | struct net_device *dev = pci_get_drvdata(pdev); |
440 | 440 | ||
441 | if (!dev) | 441 | BUG_ON(!dev); |
442 | BUG(); | ||
443 | unregister_netdev(dev); | 442 | unregister_netdev(dev); |
444 | release_region(dev->base_addr-0x10, ABYSS_IO_EXTENT); | 443 | release_region(dev->base_addr-0x10, ABYSS_IO_EXTENT); |
445 | free_irq(dev->irq, dev); | 444 | free_irq(dev->irq, dev); |
diff --git a/drivers/net/tokenring/madgemc.c b/drivers/net/tokenring/madgemc.c index 3a25d191ea4a..19e6f4dfd69c 100644 --- a/drivers/net/tokenring/madgemc.c +++ b/drivers/net/tokenring/madgemc.c | |||
@@ -735,8 +735,7 @@ static int __devexit madgemc_remove(struct device *device) | |||
735 | struct net_local *tp; | 735 | struct net_local *tp; |
736 | struct card_info *card; | 736 | struct card_info *card; |
737 | 737 | ||
738 | if (!dev) | 738 | BUG_ON(!dev); |
739 | BUG(); | ||
740 | 739 | ||
741 | tp = dev->priv; | 740 | tp = dev->priv; |
742 | card = tp->tmspriv; | 741 | card = tp->tmspriv; |
diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c index 9dce522526c5..bca89cff85a6 100644 --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c | |||
@@ -5573,8 +5573,7 @@ static void ipw_adhoc_create(struct ipw_priv *priv, | |||
5573 | case IEEE80211_52GHZ_BAND: | 5573 | case IEEE80211_52GHZ_BAND: |
5574 | network->mode = IEEE_A; | 5574 | network->mode = IEEE_A; |
5575 | i = ieee80211_channel_to_index(priv->ieee, priv->channel); | 5575 | i = ieee80211_channel_to_index(priv->ieee, priv->channel); |
5576 | if (i == -1) | 5576 | BUG_ON(i == -1); |
5577 | BUG(); | ||
5578 | if (geo->a[i].flags & IEEE80211_CH_PASSIVE_ONLY) { | 5577 | if (geo->a[i].flags & IEEE80211_CH_PASSIVE_ONLY) { |
5579 | IPW_WARNING("Overriding invalid channel\n"); | 5578 | IPW_WARNING("Overriding invalid channel\n"); |
5580 | priv->channel = geo->a[0].channel; | 5579 | priv->channel = geo->a[0].channel; |
@@ -5587,8 +5586,7 @@ static void ipw_adhoc_create(struct ipw_priv *priv, | |||
5587 | else | 5586 | else |
5588 | network->mode = IEEE_B; | 5587 | network->mode = IEEE_B; |
5589 | i = ieee80211_channel_to_index(priv->ieee, priv->channel); | 5588 | i = ieee80211_channel_to_index(priv->ieee, priv->channel); |
5590 | if (i == -1) | 5589 | BUG_ON(i == -1); |
5591 | BUG(); | ||
5592 | if (geo->bg[i].flags & IEEE80211_CH_PASSIVE_ONLY) { | 5590 | if (geo->bg[i].flags & IEEE80211_CH_PASSIVE_ONLY) { |
5593 | IPW_WARNING("Overriding invalid channel\n"); | 5591 | IPW_WARNING("Overriding invalid channel\n"); |
5594 | priv->channel = geo->bg[0].channel; | 5592 | priv->channel = geo->bg[0].channel; |
@@ -6715,8 +6713,7 @@ static int ipw_qos_association(struct ipw_priv *priv, | |||
6715 | 6713 | ||
6716 | switch (priv->ieee->iw_mode) { | 6714 | switch (priv->ieee->iw_mode) { |
6717 | case IW_MODE_ADHOC: | 6715 | case IW_MODE_ADHOC: |
6718 | if (!(network->capability & WLAN_CAPABILITY_IBSS)) | 6716 | BUG_ON(!(network->capability & WLAN_CAPABILITY_IBSS)); |
6719 | BUG(); | ||
6720 | 6717 | ||
6721 | qos_data = &ibss_data; | 6718 | qos_data = &ibss_data; |
6722 | break; | 6719 | break; |
diff --git a/drivers/net/yellowfin.c b/drivers/net/yellowfin.c index 75d56bfef0ee..fd0f43b7db5b 100644 --- a/drivers/net/yellowfin.c +++ b/drivers/net/yellowfin.c | |||
@@ -1441,8 +1441,7 @@ static void __devexit yellowfin_remove_one (struct pci_dev *pdev) | |||
1441 | struct net_device *dev = pci_get_drvdata(pdev); | 1441 | struct net_device *dev = pci_get_drvdata(pdev); |
1442 | struct yellowfin_private *np; | 1442 | struct yellowfin_private *np; |
1443 | 1443 | ||
1444 | if (!dev) | 1444 | BUG_ON(!dev); |
1445 | BUG(); | ||
1446 | np = netdev_priv(dev); | 1445 | np = netdev_priv(dev); |
1447 | 1446 | ||
1448 | pci_free_consistent(pdev, STATUS_TOTAL_SIZE, np->tx_status, | 1447 | pci_free_consistent(pdev, STATUS_TOTAL_SIZE, np->tx_status, |
diff --git a/drivers/s390/block/dasd_erp.c b/drivers/s390/block/dasd_erp.c index 8fd71ab02ef0..b842377cb0c6 100644 --- a/drivers/s390/block/dasd_erp.c +++ b/drivers/s390/block/dasd_erp.c | |||
@@ -32,9 +32,8 @@ dasd_alloc_erp_request(char *magic, int cplength, int datasize, | |||
32 | int size; | 32 | int size; |
33 | 33 | ||
34 | /* Sanity checks */ | 34 | /* Sanity checks */ |
35 | if ( magic == NULL || datasize > PAGE_SIZE || | 35 | BUG_ON( magic == NULL || datasize > PAGE_SIZE || |
36 | (cplength*sizeof(struct ccw1)) > PAGE_SIZE) | 36 | (cplength*sizeof(struct ccw1)) > PAGE_SIZE); |
37 | BUG(); | ||
38 | 37 | ||
39 | size = (sizeof(struct dasd_ccw_req) + 7L) & -8L; | 38 | size = (sizeof(struct dasd_ccw_req) + 7L) & -8L; |
40 | if (cplength > 0) | 39 | if (cplength > 0) |
@@ -125,8 +124,7 @@ dasd_default_erp_postaction(struct dasd_ccw_req * cqr) | |||
125 | struct dasd_device *device; | 124 | struct dasd_device *device; |
126 | int success; | 125 | int success; |
127 | 126 | ||
128 | if (cqr->refers == NULL || cqr->function == NULL) | 127 | BUG_ON(cqr->refers == NULL || cqr->function == NULL); |
129 | BUG(); | ||
130 | 128 | ||
131 | device = cqr->device; | 129 | device = cqr->device; |
132 | success = cqr->status == DASD_CQR_DONE; | 130 | success = cqr->status == DASD_CQR_DONE; |
diff --git a/drivers/s390/char/sclp_rw.c b/drivers/s390/char/sclp_rw.c index ac10dfb20a62..91e93c78f57a 100644 --- a/drivers/s390/char/sclp_rw.c +++ b/drivers/s390/char/sclp_rw.c | |||
@@ -24,7 +24,7 @@ | |||
24 | 24 | ||
25 | /* | 25 | /* |
26 | * The room for the SCCB (only for writing) is not equal to a pages size | 26 | * The room for the SCCB (only for writing) is not equal to a pages size |
27 | * (as it is specified as the maximum size in the the SCLP ducumentation) | 27 | * (as it is specified as the maximum size in the the SCLP documentation) |
28 | * because of the additional data structure described above. | 28 | * because of the additional data structure described above. |
29 | */ | 29 | */ |
30 | #define MAX_SCCB_ROOM (PAGE_SIZE - sizeof(struct sclp_buffer)) | 30 | #define MAX_SCCB_ROOM (PAGE_SIZE - sizeof(struct sclp_buffer)) |
diff --git a/drivers/s390/char/tape_block.c b/drivers/s390/char/tape_block.c index 5ced2725d6c7..5c65cf3e5cc0 100644 --- a/drivers/s390/char/tape_block.c +++ b/drivers/s390/char/tape_block.c | |||
@@ -198,9 +198,7 @@ tapeblock_request_fn(request_queue_t *queue) | |||
198 | 198 | ||
199 | device = (struct tape_device *) queue->queuedata; | 199 | device = (struct tape_device *) queue->queuedata; |
200 | DBF_LH(6, "tapeblock_request_fn(device=%p)\n", device); | 200 | DBF_LH(6, "tapeblock_request_fn(device=%p)\n", device); |
201 | if (device == NULL) | 201 | BUG_ON(device == NULL); |
202 | BUG(); | ||
203 | |||
204 | tapeblock_trigger_requeue(device); | 202 | tapeblock_trigger_requeue(device); |
205 | } | 203 | } |
206 | 204 | ||
@@ -307,8 +305,7 @@ tapeblock_revalidate_disk(struct gendisk *disk) | |||
307 | int rc; | 305 | int rc; |
308 | 306 | ||
309 | device = (struct tape_device *) disk->private_data; | 307 | device = (struct tape_device *) disk->private_data; |
310 | if (!device) | 308 | BUG_ON(!device); |
311 | BUG(); | ||
312 | 309 | ||
313 | if (!device->blk_data.medium_changed) | 310 | if (!device->blk_data.medium_changed) |
314 | return 0; | 311 | return 0; |
@@ -440,11 +437,9 @@ tapeblock_ioctl( | |||
440 | 437 | ||
441 | rc = 0; | 438 | rc = 0; |
442 | disk = inode->i_bdev->bd_disk; | 439 | disk = inode->i_bdev->bd_disk; |
443 | if (!disk) | 440 | BUG_ON(!disk); |
444 | BUG(); | ||
445 | device = disk->private_data; | 441 | device = disk->private_data; |
446 | if (!device) | 442 | BUG_ON(!device); |
447 | BUG(); | ||
448 | minor = iminor(inode); | 443 | minor = iminor(inode); |
449 | 444 | ||
450 | DBF_LH(6, "tapeblock_ioctl(0x%0x)\n", command); | 445 | DBF_LH(6, "tapeblock_ioctl(0x%0x)\n", command); |
diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c index edcf05d5d568..5d6b7a57b02f 100644 --- a/drivers/s390/net/lcs.c +++ b/drivers/s390/net/lcs.c | |||
@@ -675,9 +675,8 @@ lcs_ready_buffer(struct lcs_channel *channel, struct lcs_buffer *buffer) | |||
675 | int index, rc; | 675 | int index, rc; |
676 | 676 | ||
677 | LCS_DBF_TEXT(5, trace, "rdybuff"); | 677 | LCS_DBF_TEXT(5, trace, "rdybuff"); |
678 | if (buffer->state != BUF_STATE_LOCKED && | 678 | BUG_ON(buffer->state != BUF_STATE_LOCKED && |
679 | buffer->state != BUF_STATE_PROCESSED) | 679 | buffer->state != BUF_STATE_PROCESSED); |
680 | BUG(); | ||
681 | spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags); | 680 | spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags); |
682 | buffer->state = BUF_STATE_READY; | 681 | buffer->state = BUF_STATE_READY; |
683 | index = buffer - channel->iob; | 682 | index = buffer - channel->iob; |
@@ -701,8 +700,7 @@ __lcs_processed_buffer(struct lcs_channel *channel, struct lcs_buffer *buffer) | |||
701 | int index, prev, next; | 700 | int index, prev, next; |
702 | 701 | ||
703 | LCS_DBF_TEXT(5, trace, "prcsbuff"); | 702 | LCS_DBF_TEXT(5, trace, "prcsbuff"); |
704 | if (buffer->state != BUF_STATE_READY) | 703 | BUG_ON(buffer->state != BUF_STATE_READY); |
705 | BUG(); | ||
706 | buffer->state = BUF_STATE_PROCESSED; | 704 | buffer->state = BUF_STATE_PROCESSED; |
707 | index = buffer - channel->iob; | 705 | index = buffer - channel->iob; |
708 | prev = (index - 1) & (LCS_NUM_BUFFS - 1); | 706 | prev = (index - 1) & (LCS_NUM_BUFFS - 1); |
@@ -734,9 +732,8 @@ lcs_release_buffer(struct lcs_channel *channel, struct lcs_buffer *buffer) | |||
734 | unsigned long flags; | 732 | unsigned long flags; |
735 | 733 | ||
736 | LCS_DBF_TEXT(5, trace, "relbuff"); | 734 | LCS_DBF_TEXT(5, trace, "relbuff"); |
737 | if (buffer->state != BUF_STATE_LOCKED && | 735 | BUG_ON(buffer->state != BUF_STATE_LOCKED && |
738 | buffer->state != BUF_STATE_PROCESSED) | 736 | buffer->state != BUF_STATE_PROCESSED); |
739 | BUG(); | ||
740 | spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags); | 737 | spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags); |
741 | buffer->state = BUF_STATE_EMPTY; | 738 | buffer->state = BUF_STATE_EMPTY; |
742 | spin_unlock_irqrestore(get_ccwdev_lock(channel->ccwdev), flags); | 739 | spin_unlock_irqrestore(get_ccwdev_lock(channel->ccwdev), flags); |
diff --git a/drivers/scsi/aic7xxx/Kconfig.aic7xxx b/drivers/scsi/aic7xxx/Kconfig.aic7xxx index 6c2c395554ff..5517da5855f0 100644 --- a/drivers/scsi/aic7xxx/Kconfig.aic7xxx +++ b/drivers/scsi/aic7xxx/Kconfig.aic7xxx | |||
@@ -86,7 +86,7 @@ config AIC7XXX_DEBUG_MASK | |||
86 | default "0" | 86 | default "0" |
87 | help | 87 | help |
88 | Bit mask of debug options that is only valid if the | 88 | Bit mask of debug options that is only valid if the |
89 | CONFIG_AIC7XXX_DEBUG_ENBLE option is enabled. The bits in this mask | 89 | CONFIG_AIC7XXX_DEBUG_ENABLE option is enabled. The bits in this mask |
90 | are defined in the drivers/scsi/aic7xxx/aic7xxx.h - search for the | 90 | are defined in the drivers/scsi/aic7xxx/aic7xxx.h - search for the |
91 | variable ahc_debug in that file to find them. | 91 | variable ahc_debug in that file to find them. |
92 | 92 | ||
diff --git a/drivers/serial/jsm/jsm.h b/drivers/serial/jsm/jsm.h index dfc1e86d3aa1..043f50b1d10c 100644 --- a/drivers/serial/jsm/jsm.h +++ b/drivers/serial/jsm/jsm.h | |||
@@ -20,7 +20,7 @@ | |||
20 | * | 20 | * |
21 | * Contact Information: | 21 | * Contact Information: |
22 | * Scott H Kilau <Scott_Kilau@digi.com> | 22 | * Scott H Kilau <Scott_Kilau@digi.com> |
23 | * Wendy Xiong <wendyx@us.ltcfwd.linux.ibm.com> | 23 | * Wendy Xiong <wendyx@us.ibm.com> |
24 | * | 24 | * |
25 | ***********************************************************************/ | 25 | ***********************************************************************/ |
26 | 26 | ||
diff --git a/drivers/serial/jsm/jsm_driver.c b/drivers/serial/jsm/jsm_driver.c index b1b66e71d281..b3e1f71be4da 100644 --- a/drivers/serial/jsm/jsm_driver.c +++ b/drivers/serial/jsm/jsm_driver.c | |||
@@ -20,7 +20,7 @@ | |||
20 | * | 20 | * |
21 | * Contact Information: | 21 | * Contact Information: |
22 | * Scott H Kilau <Scott_Kilau@digi.com> | 22 | * Scott H Kilau <Scott_Kilau@digi.com> |
23 | * Wendy Xiong <wendyx@us.ltcfwd.linux.ibm.com> | 23 | * Wendy Xiong <wendyx@us.ibm.com> |
24 | * | 24 | * |
25 | * | 25 | * |
26 | ***********************************************************************/ | 26 | ***********************************************************************/ |
diff --git a/drivers/serial/jsm/jsm_neo.c b/drivers/serial/jsm/jsm_neo.c index 87e4e2cf8ce7..a5fc589d6ef5 100644 --- a/drivers/serial/jsm/jsm_neo.c +++ b/drivers/serial/jsm/jsm_neo.c | |||
@@ -20,7 +20,7 @@ | |||
20 | * | 20 | * |
21 | * Contact Information: | 21 | * Contact Information: |
22 | * Scott H Kilau <Scott_Kilau@digi.com> | 22 | * Scott H Kilau <Scott_Kilau@digi.com> |
23 | * Wendy Xiong <wendyx@us.ltcfwd.linux.ibm.com> | 23 | * Wendy Xiong <wendyx@us.ibm.com> |
24 | * | 24 | * |
25 | ***********************************************************************/ | 25 | ***********************************************************************/ |
26 | #include <linux/delay.h> /* For udelay */ | 26 | #include <linux/delay.h> /* For udelay */ |