diff options
author | Johannes Berg <johannes.berg@intel.com> | 2011-02-04 09:57:45 -0500 |
---|---|---|
committer | Wey-Yi Guy <wey-yi.w.guy@intel.com> | 2011-02-06 12:30:54 -0500 |
commit | 2f115cf24ea3f5010f7361d2098545edf7a07add (patch) | |
tree | e545611c15def73064504feb1825715dd5712acb /drivers | |
parent | b23b025fe246f3acc2988eb6d400df34c27cb8ae (diff) |
iwlwifi: remove unnecessary locking
This code, and the places that set the variable
is_internal_short_scan and the vif pointers are
all protected by the mutex, there's no point in
locking the spinlock here as well (any more).
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-agn-lib.c | 3 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl3945-base.c | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c index d4ba3357b628..3aa486437509 100644 --- a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c +++ b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c | |||
@@ -1395,15 +1395,12 @@ int iwlagn_request_scan(struct iwl_priv *priv, struct ieee80211_vif *vif) | |||
1395 | u32 extra; | 1395 | u32 extra; |
1396 | u32 suspend_time = 100; | 1396 | u32 suspend_time = 100; |
1397 | u32 scan_suspend_time = 100; | 1397 | u32 scan_suspend_time = 100; |
1398 | unsigned long flags; | ||
1399 | 1398 | ||
1400 | IWL_DEBUG_INFO(priv, "Scanning while associated...\n"); | 1399 | IWL_DEBUG_INFO(priv, "Scanning while associated...\n"); |
1401 | spin_lock_irqsave(&priv->lock, flags); | ||
1402 | if (priv->is_internal_short_scan) | 1400 | if (priv->is_internal_short_scan) |
1403 | interval = 0; | 1401 | interval = 0; |
1404 | else | 1402 | else |
1405 | interval = vif->bss_conf.beacon_int; | 1403 | interval = vif->bss_conf.beacon_int; |
1406 | spin_unlock_irqrestore(&priv->lock, flags); | ||
1407 | 1404 | ||
1408 | scan->suspend_time = 0; | 1405 | scan->suspend_time = 0; |
1409 | scan->max_out_time = cpu_to_le32(200 * 1024); | 1406 | scan->max_out_time = cpu_to_le32(200 * 1024); |
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c index 76fae81ddc4b..adcef735180a 100644 --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c | |||
@@ -2860,16 +2860,13 @@ int iwl3945_request_scan(struct iwl_priv *priv, struct ieee80211_vif *vif) | |||
2860 | u32 extra; | 2860 | u32 extra; |
2861 | u32 suspend_time = 100; | 2861 | u32 suspend_time = 100; |
2862 | u32 scan_suspend_time = 100; | 2862 | u32 scan_suspend_time = 100; |
2863 | unsigned long flags; | ||
2864 | 2863 | ||
2865 | IWL_DEBUG_INFO(priv, "Scanning while associated...\n"); | 2864 | IWL_DEBUG_INFO(priv, "Scanning while associated...\n"); |
2866 | 2865 | ||
2867 | spin_lock_irqsave(&priv->lock, flags); | ||
2868 | if (priv->is_internal_short_scan) | 2866 | if (priv->is_internal_short_scan) |
2869 | interval = 0; | 2867 | interval = 0; |
2870 | else | 2868 | else |
2871 | interval = vif->bss_conf.beacon_int; | 2869 | interval = vif->bss_conf.beacon_int; |
2872 | spin_unlock_irqrestore(&priv->lock, flags); | ||
2873 | 2870 | ||
2874 | scan->suspend_time = 0; | 2871 | scan->suspend_time = 0; |
2875 | scan->max_out_time = cpu_to_le32(200 * 1024); | 2872 | scan->max_out_time = cpu_to_le32(200 * 1024); |