diff options
author | Julia Lawall <julia@diku.dk> | 2010-05-30 16:27:46 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-06-04 16:38:57 -0400 |
commit | 0aa3f139cd5123ffb8f397b91d777635e9761c24 (patch) | |
tree | 0f0c6b590dba5a2a1b0872e8fd0962a31dc35e9e /drivers | |
parent | ebe8622342f12bed387f7de4b5fb7c52005ccb29 (diff) |
staging: Use GFP_ATOMIC when a lock is held
In each case, the containing function is only called from one place, where
a spin lock is held.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@gfp exists@
identifier fn;
position p;
@@
fn(...) {
... when != spin_unlock
when any
GFP_KERNEL@p
... when any
}
@locked@
identifier gfp.fn;
@@
spin_lock(...)
... when != spin_unlock
fn(...)
@depends on locked@
position gfp.p;
@@
- GFP_KERNEL@p
+ GFP_ATOMIC
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Cc: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/staging/iio/ring_sw.c | 2 | ||||
-rw-r--r-- | drivers/staging/vme/bridges/vme_ca91cx42.c | 2 | ||||
-rw-r--r-- | drivers/staging/vme/bridges/vme_tsi148.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/staging/iio/ring_sw.c b/drivers/staging/iio/ring_sw.c index 1f14cd4770e7..294272d0619f 100644 --- a/drivers/staging/iio/ring_sw.c +++ b/drivers/staging/iio/ring_sw.c | |||
@@ -20,7 +20,7 @@ static inline int __iio_allocate_sw_ring_buffer(struct iio_sw_ring_buffer *ring, | |||
20 | if ((length == 0) || (bytes_per_datum == 0)) | 20 | if ((length == 0) || (bytes_per_datum == 0)) |
21 | return -EINVAL; | 21 | return -EINVAL; |
22 | __iio_update_ring_buffer(&ring->buf, bytes_per_datum, length); | 22 | __iio_update_ring_buffer(&ring->buf, bytes_per_datum, length); |
23 | ring->data = kmalloc(length*ring->buf.bpd, GFP_KERNEL); | 23 | ring->data = kmalloc(length*ring->buf.bpd, GFP_ATOMIC); |
24 | ring->read_p = NULL; | 24 | ring->read_p = NULL; |
25 | ring->write_p = NULL; | 25 | ring->write_p = NULL; |
26 | ring->last_written_p = NULL; | 26 | ring->last_written_p = NULL; |
diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c index 0c82eb47a28d..0f9ea58ff717 100644 --- a/drivers/staging/vme/bridges/vme_ca91cx42.c +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c | |||
@@ -523,7 +523,7 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image, | |||
523 | } | 523 | } |
524 | 524 | ||
525 | if (image->bus_resource.name == NULL) { | 525 | if (image->bus_resource.name == NULL) { |
526 | image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_KERNEL); | 526 | image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_ATOMIC); |
527 | if (image->bus_resource.name == NULL) { | 527 | if (image->bus_resource.name == NULL) { |
528 | dev_err(ca91cx42_bridge->parent, "Unable to allocate " | 528 | dev_err(ca91cx42_bridge->parent, "Unable to allocate " |
529 | "memory for resource name\n"); | 529 | "memory for resource name\n"); |
diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c index abe88a380b72..f09cac163139 100644 --- a/drivers/staging/vme/bridges/vme_tsi148.c +++ b/drivers/staging/vme/bridges/vme_tsi148.c | |||
@@ -828,7 +828,7 @@ static int tsi148_alloc_resource(struct vme_master_resource *image, | |||
828 | return 0; | 828 | return 0; |
829 | 829 | ||
830 | if (image->bus_resource.name == NULL) { | 830 | if (image->bus_resource.name == NULL) { |
831 | image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_KERNEL); | 831 | image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_ATOMIC); |
832 | if (image->bus_resource.name == NULL) { | 832 | if (image->bus_resource.name == NULL) { |
833 | dev_err(tsi148_bridge->parent, "Unable to allocate " | 833 | dev_err(tsi148_bridge->parent, "Unable to allocate " |
834 | "memory for resource name\n"); | 834 | "memory for resource name\n"); |