aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/zorro
diff options
context:
space:
mode:
authorGeert Uytterhoeven <geert@linux-m68k.org>2013-06-29 04:40:20 -0400
committerGeert Uytterhoeven <geert@linux-m68k.org>2013-11-26 05:09:03 -0500
commitc293738e6d8dfb9c941759855b5161fde449644d (patch)
tree3c2d4b2041af3e2fe5a8a4702cdfe49fca3e1f7f /drivers/zorro
parent1ea636eb68322198e08aebdede141244d98e8299 (diff)
zorro: Do not allocate zorro_autocon[] statically
Currently the array of Zorro devices is allocated statically, wasting up to 4.5 KiB when running an Amiga or multi-platform kernel on a machine with no or a handful of Zorro expansion cards. Convert it to conditional dynamic memory allocation to fix this. amiga_parse_bootinfo() still needs to store some information about the detected Zorro devices, at a time even the bootmem allocator is not yet available. This is now handled using a much smaller array (typically less than 0.5 KiB), which is __initdata and thus freed later. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Diffstat (limited to 'drivers/zorro')
-rw-r--r--drivers/zorro/zorro.c19
1 files changed, 16 insertions, 3 deletions
diff --git a/drivers/zorro/zorro.c b/drivers/zorro/zorro.c
index 858c9714b2f3..10c7f77aec08 100644
--- a/drivers/zorro/zorro.c
+++ b/drivers/zorro/zorro.c
@@ -29,7 +29,8 @@
29 */ 29 */
30 30
31unsigned int zorro_num_autocon; 31unsigned int zorro_num_autocon;
32struct zorro_dev zorro_autocon[ZORRO_NUM_AUTO]; 32struct zorro_dev_init zorro_autocon_init[ZORRO_NUM_AUTO] __initdata;
33struct zorro_dev *zorro_autocon;
33 34
34 35
35 /* 36 /*
@@ -38,6 +39,7 @@ struct zorro_dev zorro_autocon[ZORRO_NUM_AUTO];
38 39
39struct zorro_bus { 40struct zorro_bus {
40 struct device dev; 41 struct device dev;
42 struct zorro_dev devices[0];
41}; 43};
42 44
43 45
@@ -125,16 +127,20 @@ static struct resource __init *zorro_find_parent_resource(
125static int __init amiga_zorro_probe(struct platform_device *pdev) 127static int __init amiga_zorro_probe(struct platform_device *pdev)
126{ 128{
127 struct zorro_bus *bus; 129 struct zorro_bus *bus;
130 struct zorro_dev_init *zi;
128 struct zorro_dev *z; 131 struct zorro_dev *z;
129 struct resource *r; 132 struct resource *r;
130 unsigned int i; 133 unsigned int i;
131 int error; 134 int error;
132 135
133 /* Initialize the Zorro bus */ 136 /* Initialize the Zorro bus */
134 bus = kzalloc(sizeof(*bus), GFP_KERNEL); 137 bus = kzalloc(sizeof(*bus) +
138 zorro_num_autocon * sizeof(bus->devices[0]),
139 GFP_KERNEL);
135 if (!bus) 140 if (!bus)
136 return -ENOMEM; 141 return -ENOMEM;
137 142
143 zorro_autocon = bus->devices;
138 bus->dev.parent = &pdev->dev; 144 bus->dev.parent = &pdev->dev;
139 dev_set_name(&bus->dev, "zorro"); 145 dev_set_name(&bus->dev, "zorro");
140 error = device_register(&bus->dev); 146 error = device_register(&bus->dev);
@@ -151,15 +157,22 @@ static int __init amiga_zorro_probe(struct platform_device *pdev)
151 157
152 /* First identify all devices ... */ 158 /* First identify all devices ... */
153 for (i = 0; i < zorro_num_autocon; i++) { 159 for (i = 0; i < zorro_num_autocon; i++) {
160 zi = &zorro_autocon_init[i];
154 z = &zorro_autocon[i]; 161 z = &zorro_autocon[i];
162
163 z->rom = zi->rom;
155 z->id = (z->rom.er_Manufacturer<<16) | (z->rom.er_Product<<8); 164 z->id = (z->rom.er_Manufacturer<<16) | (z->rom.er_Product<<8);
156 if (z->id == ZORRO_PROD_GVP_EPC_BASE) { 165 if (z->id == ZORRO_PROD_GVP_EPC_BASE) {
157 /* GVP quirk */ 166 /* GVP quirk */
158 unsigned long magic = zorro_resource_start(z)+0x8000; 167 unsigned long magic = zi->boardaddr + 0x8000;
159 z->id |= *(u16 *)ZTWO_VADDR(magic) & GVP_PRODMASK; 168 z->id |= *(u16 *)ZTWO_VADDR(magic) & GVP_PRODMASK;
160 } 169 }
170 z->slotaddr = zi->slotaddr;
171 z->slotsize = zi->slotsize;
161 sprintf(z->name, "Zorro device %08x", z->id); 172 sprintf(z->name, "Zorro device %08x", z->id);
162 zorro_name_device(z); 173 zorro_name_device(z);
174 z->resource.start = zi->boardaddr;
175 z->resource.end = zi->boardaddr + zi->boardsize - 1;
163 z->resource.name = z->name; 176 z->resource.name = z->name;
164 r = zorro_find_parent_resource(pdev, z); 177 r = zorro_find_parent_resource(pdev, z);
165 error = request_resource(r, &z->resource); 178 error = request_resource(r, &z->resource);