diff options
author | Stefano Stabellini <stefano.stabellini@eu.citrix.com> | 2012-05-21 11:54:10 -0400 |
---|---|---|
committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2012-05-21 14:11:36 -0400 |
commit | 68c2c39a76b094e9b2773e5846424ea674bf2c46 (patch) | |
tree | b3959303806a6228adbbab234c474e16c81738ba /drivers/xen | |
parent | 201a52bea928687b7557728b176ac4f8a37d5cbd (diff) |
xen: do not map the same GSI twice in PVHVM guests.
PV on HVM guests map GSIs into event channels. At restore time the
event channels are resumed by restore_pirqs.
Device drivers might try to register the same GSI again through ACPI at
restore time, but the GSI has already been mapped and bound by
restore_pirqs. This patch detects these situations and avoids
mapping the same GSI multiple times.
Without this patch we get:
(XEN) irq.c:2235: dom4: pirq 23 or emuirq 28 already mapped
and waste a pirq.
CC: stable@kernel.org
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'drivers/xen')
-rw-r--r-- | drivers/xen/events.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/xen/events.c b/drivers/xen/events.c index 4b33acd8ed4e..faae2f910ad2 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c | |||
@@ -611,7 +611,7 @@ static void disable_pirq(struct irq_data *data) | |||
611 | disable_dynirq(data); | 611 | disable_dynirq(data); |
612 | } | 612 | } |
613 | 613 | ||
614 | static int find_irq_by_gsi(unsigned gsi) | 614 | int xen_irq_from_gsi(unsigned gsi) |
615 | { | 615 | { |
616 | struct irq_info *info; | 616 | struct irq_info *info; |
617 | 617 | ||
@@ -625,6 +625,7 @@ static int find_irq_by_gsi(unsigned gsi) | |||
625 | 625 | ||
626 | return -1; | 626 | return -1; |
627 | } | 627 | } |
628 | EXPORT_SYMBOL_GPL(xen_irq_from_gsi); | ||
628 | 629 | ||
629 | /* | 630 | /* |
630 | * Do not make any assumptions regarding the relationship between the | 631 | * Do not make any assumptions regarding the relationship between the |
@@ -644,7 +645,7 @@ int xen_bind_pirq_gsi_to_irq(unsigned gsi, | |||
644 | 645 | ||
645 | mutex_lock(&irq_mapping_update_lock); | 646 | mutex_lock(&irq_mapping_update_lock); |
646 | 647 | ||
647 | irq = find_irq_by_gsi(gsi); | 648 | irq = xen_irq_from_gsi(gsi); |
648 | if (irq != -1) { | 649 | if (irq != -1) { |
649 | printk(KERN_INFO "xen_map_pirq_gsi: returning irq %d for gsi %u\n", | 650 | printk(KERN_INFO "xen_map_pirq_gsi: returning irq %d for gsi %u\n", |
650 | irq, gsi); | 651 | irq, gsi); |