ACPI / scan: Add acpi_device objects for all device nodes in the namespace

Modify the ACPI namespace scanning code to register a struct
acpi_device object for every namespace node representing a device,
processor and so on, even if the device represented by that namespace
node is reported to be not present and not functional by _STA.

There are multiple reasons to do that.  First of all, it avoids
quite a lot of overhead when struct acpi_device objects are
deleted every time acpi_bus_trim() is run and then added again
by a subsequent acpi_bus_scan() for the same scope, although the
namespace objects they correspond to stay in memory all the time
(which always is the case on a vast majority of systems).

Second, it will allow user space to see that there are namespace
nodes representing devices that are not present at the moment and may
be added to the system.  It will also allow user space to evaluate
_SUN for those nodes to check what physical slots the "missing"
devices may be put into and it will make sense to add a sysfs
attribute for _STA evaluation after this change (that will be
useful for thermal management on some systems).

Next, it will help to consolidate the ACPI hotplug handling among
subsystems by making it possible to store hotplug-related information
in struct acpi_device objects in a standard common way.

Finally, it will help to avoid a race condition related to the
deletion of ACPI namespace nodes.  Namely, namespace nodes may be
deleted as a result of a table unload triggered by _EJ0 or _DCK.
If a hotplug notification for one of those nodes is triggered
right before the deletion and it executes a hotplug callback
via acpi_hotplug_execute(), the ACPI handle passed to that
callback may be stale when the callback actually runs.  One way
to work around that is to always pass struct acpi_device pointers
to hotplug callbacks after doing a get_device() on the objects in
question which eliminates the use-after-free possibility (the ACPI
handles in those objects are invalidated by acpi_scan_drop_device(),
so they will trigger ACPICA errors on attempts to use them).

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>

2 files changed, 9 insertions, 6 deletions

diff --git a/drivers/xen/xen-acpi-cpuhotplug.c b/drivers/xen/xen-acpi-cpuhotplug.c
index 8dae6c13063a..73496c3d18ae 100644
--- a/drivers/xen/xen-acpi-cpuhotplug.c
+++ b/drivers/xen/xen-acpi-cpuhotplug.c
@@ -269,7 +269,8 @@ static void acpi_processor_hotplug_notify(acpi_handle handle,
                 if (!is_processor_present(handle))
                         break;
 
-                if (!acpi_bus_get_device(handle, &device))
+                acpi_bus_get_device(handle, &device);
+                if (acpi_device_enumerated(device))
                         break;
 
                 result = acpi_bus_scan(handle);
@@ -277,8 +278,9 @@ static void acpi_processor_hotplug_notify(acpi_handle handle,
                         pr_err(PREFIX "Unable to add the device\n");
                         break;
                 }
-                result = acpi_bus_get_device(handle, &device);
-                if (result) {
+                device = NULL;
+                acpi_bus_get_device(handle, &device);
+                if (!acpi_device_enumerated(device)) {
                         pr_err(PREFIX "Missing device object\n");
                         break;
                 }
diff --git a/drivers/xen/xen-acpi-memhotplug.c b/drivers/xen/xen-acpi-memhotplug.c
index 9083f1e474f8..9b056f06691f 100644
--- a/drivers/xen/xen-acpi-memhotplug.c
+++ b/drivers/xen/xen-acpi-memhotplug.c
@@ -169,7 +169,7 @@ static int acpi_memory_get_device(acpi_handle handle,
         acpi_scan_lock_acquire();
 
         acpi_bus_get_device(handle, &device);
-        if (device)
+        if (acpi_device_enumerated(device))
                 goto end;
 
         /*
@@ -182,8 +182,9 @@ static int acpi_memory_get_device(acpi_handle handle,
                 result = -EINVAL;
                 goto out;
         }
-        result = acpi_bus_get_device(handle, &device);
-        if (result) {
+        device = NULL;
+        acpi_bus_get_device(handle, &device);
+        if (!acpi_device_enumerated(device)) {
                 pr_warn(PREFIX "Missing device object\n");
                 result = -EINVAL;
                 goto out;