diff options
author | David Vrabel <david.vrabel@citrix.com> | 2014-09-08 12:30:41 -0400 |
---|---|---|
committer | David Vrabel <david.vrabel@citrix.com> | 2014-10-06 05:27:57 -0400 |
commit | 95afae481414cbdb0567bf82d5e5077c3ac9da20 (patch) | |
tree | 653ae2fae22966dd2a634ac4865ead3c6937eee9 /drivers/xen/xenbus | |
parent | 305559f16538708b603ceeb317ebaed9c4da9ce9 (diff) |
xen: remove DEFINE_XENBUS_DRIVER() macro
The DEFINE_XENBUS_DRIVER() macro looks a bit weird and causes sparse
errors.
Replace the uses with standard structure definitions instead. This is
similar to pci and usb device registration.
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Diffstat (limited to 'drivers/xen/xenbus')
-rw-r--r-- | drivers/xen/xenbus/xenbus_probe.c | 6 | ||||
-rw-r--r-- | drivers/xen/xenbus/xenbus_probe.h | 4 | ||||
-rw-r--r-- | drivers/xen/xenbus/xenbus_probe_backend.c | 8 | ||||
-rw-r--r-- | drivers/xen/xenbus/xenbus_probe_frontend.c | 8 |
4 files changed, 18 insertions, 8 deletions
diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index 3c0a74b3e9b1..564b31584860 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c | |||
@@ -297,9 +297,13 @@ void xenbus_dev_shutdown(struct device *_dev) | |||
297 | EXPORT_SYMBOL_GPL(xenbus_dev_shutdown); | 297 | EXPORT_SYMBOL_GPL(xenbus_dev_shutdown); |
298 | 298 | ||
299 | int xenbus_register_driver_common(struct xenbus_driver *drv, | 299 | int xenbus_register_driver_common(struct xenbus_driver *drv, |
300 | struct xen_bus_type *bus) | 300 | struct xen_bus_type *bus, |
301 | struct module *owner, const char *mod_name) | ||
301 | { | 302 | { |
303 | drv->driver.name = drv->name ? drv->name : drv->ids[0].devicetype; | ||
302 | drv->driver.bus = &bus->bus; | 304 | drv->driver.bus = &bus->bus; |
305 | drv->driver.owner = owner; | ||
306 | drv->driver.mod_name = mod_name; | ||
303 | 307 | ||
304 | return driver_register(&drv->driver); | 308 | return driver_register(&drv->driver); |
305 | } | 309 | } |
diff --git a/drivers/xen/xenbus/xenbus_probe.h b/drivers/xen/xenbus/xenbus_probe.h index 1085ec294a19..c9ec7ca1f7ab 100644 --- a/drivers/xen/xenbus/xenbus_probe.h +++ b/drivers/xen/xenbus/xenbus_probe.h | |||
@@ -60,7 +60,9 @@ extern int xenbus_match(struct device *_dev, struct device_driver *_drv); | |||
60 | extern int xenbus_dev_probe(struct device *_dev); | 60 | extern int xenbus_dev_probe(struct device *_dev); |
61 | extern int xenbus_dev_remove(struct device *_dev); | 61 | extern int xenbus_dev_remove(struct device *_dev); |
62 | extern int xenbus_register_driver_common(struct xenbus_driver *drv, | 62 | extern int xenbus_register_driver_common(struct xenbus_driver *drv, |
63 | struct xen_bus_type *bus); | 63 | struct xen_bus_type *bus, |
64 | struct module *owner, | ||
65 | const char *mod_name); | ||
64 | extern int xenbus_probe_node(struct xen_bus_type *bus, | 66 | extern int xenbus_probe_node(struct xen_bus_type *bus, |
65 | const char *type, | 67 | const char *type, |
66 | const char *nodename); | 68 | const char *nodename); |
diff --git a/drivers/xen/xenbus/xenbus_probe_backend.c b/drivers/xen/xenbus/xenbus_probe_backend.c index 5125dce11a60..04f7f85a5edf 100644 --- a/drivers/xen/xenbus/xenbus_probe_backend.c +++ b/drivers/xen/xenbus/xenbus_probe_backend.c | |||
@@ -234,13 +234,15 @@ int xenbus_dev_is_online(struct xenbus_device *dev) | |||
234 | } | 234 | } |
235 | EXPORT_SYMBOL_GPL(xenbus_dev_is_online); | 235 | EXPORT_SYMBOL_GPL(xenbus_dev_is_online); |
236 | 236 | ||
237 | int xenbus_register_backend(struct xenbus_driver *drv) | 237 | int __xenbus_register_backend(struct xenbus_driver *drv, struct module *owner, |
238 | const char *mod_name) | ||
238 | { | 239 | { |
239 | drv->read_otherend_details = read_frontend_details; | 240 | drv->read_otherend_details = read_frontend_details; |
240 | 241 | ||
241 | return xenbus_register_driver_common(drv, &xenbus_backend); | 242 | return xenbus_register_driver_common(drv, &xenbus_backend, |
243 | owner, mod_name); | ||
242 | } | 244 | } |
243 | EXPORT_SYMBOL_GPL(xenbus_register_backend); | 245 | EXPORT_SYMBOL_GPL(__xenbus_register_backend); |
244 | 246 | ||
245 | static int backend_probe_and_watch(struct notifier_block *notifier, | 247 | static int backend_probe_and_watch(struct notifier_block *notifier, |
246 | unsigned long event, | 248 | unsigned long event, |
diff --git a/drivers/xen/xenbus/xenbus_probe_frontend.c b/drivers/xen/xenbus/xenbus_probe_frontend.c index cb385c10d2b1..bcb53bdc469c 100644 --- a/drivers/xen/xenbus/xenbus_probe_frontend.c +++ b/drivers/xen/xenbus/xenbus_probe_frontend.c | |||
@@ -317,13 +317,15 @@ static void wait_for_devices(struct xenbus_driver *xendrv) | |||
317 | print_device_status); | 317 | print_device_status); |
318 | } | 318 | } |
319 | 319 | ||
320 | int xenbus_register_frontend(struct xenbus_driver *drv) | 320 | int __xenbus_register_frontend(struct xenbus_driver *drv, struct module *owner, |
321 | const char *mod_name) | ||
321 | { | 322 | { |
322 | int ret; | 323 | int ret; |
323 | 324 | ||
324 | drv->read_otherend_details = read_backend_details; | 325 | drv->read_otherend_details = read_backend_details; |
325 | 326 | ||
326 | ret = xenbus_register_driver_common(drv, &xenbus_frontend); | 327 | ret = xenbus_register_driver_common(drv, &xenbus_frontend, |
328 | owner, mod_name); | ||
327 | if (ret) | 329 | if (ret) |
328 | return ret; | 330 | return ret; |
329 | 331 | ||
@@ -332,7 +334,7 @@ int xenbus_register_frontend(struct xenbus_driver *drv) | |||
332 | 334 | ||
333 | return 0; | 335 | return 0; |
334 | } | 336 | } |
335 | EXPORT_SYMBOL_GPL(xenbus_register_frontend); | 337 | EXPORT_SYMBOL_GPL(__xenbus_register_frontend); |
336 | 338 | ||
337 | static DECLARE_WAIT_QUEUE_HEAD(backend_state_wq); | 339 | static DECLARE_WAIT_QUEUE_HEAD(backend_state_wq); |
338 | static int backend_state; | 340 | static int backend_state; |