diff options
author | Jan Beulich <JBeulich@suse.com> | 2011-09-21 16:22:11 -0400 |
---|---|---|
committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2011-09-21 18:17:59 -0400 |
commit | 402c5e15b44070461dcc2f41536c16d0cfbca9c3 (patch) | |
tree | 71802460e80198e591a7946cfd0d943b2951f68c /drivers/xen/xen-pciback/conf_space_quirks.c | |
parent | 04df355227fa75c015491153cfc93e7ea7a80112 (diff) |
xen/pciback: miscellaneous adjustments
This is a minor bugfix and a set of small cleanups; as it is not clear
whether this needs splitting into pieces (and if so, at what
granularity), it is a single combined patch.
- add a missing return statement to an error path in
kill_domain_by_device()
- use pci_is_enabled() rather than raw atomic_read()
- remove a bogus attempt to zero-terminate an already zero-terminated
string
- #define DRV_NAME once uniformly in the shared local header
- make DRIVER_ATTR() variables static
- eliminate a pointless use of list_for_each_entry_safe()
- add MODULE_ALIAS()
- a little bit of constification
- adjust a few messages
- remove stray semicolons from inline function definitions
Signed-off-by: Jan Beulich <jbeulich@suse.com>
[v1: Dropped the resource_size fix, altered the description]
[v2: Fixed cleanpatch.pl comments]
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'drivers/xen/xen-pciback/conf_space_quirks.c')
-rw-r--r-- | drivers/xen/xen-pciback/conf_space_quirks.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/xen/xen-pciback/conf_space_quirks.c b/drivers/xen/xen-pciback/conf_space_quirks.c index 921a889e65eb..7476791cab40 100644 --- a/drivers/xen/xen-pciback/conf_space_quirks.c +++ b/drivers/xen/xen-pciback/conf_space_quirks.c | |||
@@ -12,7 +12,6 @@ | |||
12 | #include "conf_space_quirks.h" | 12 | #include "conf_space_quirks.h" |
13 | 13 | ||
14 | LIST_HEAD(xen_pcibk_quirks); | 14 | LIST_HEAD(xen_pcibk_quirks); |
15 | #define DRV_NAME "xen-pciback" | ||
16 | static inline const struct pci_device_id * | 15 | static inline const struct pci_device_id * |
17 | match_one_device(const struct pci_device_id *id, const struct pci_dev *dev) | 16 | match_one_device(const struct pci_device_id *id, const struct pci_dev *dev) |
18 | { | 17 | { |
@@ -36,7 +35,7 @@ static struct xen_pcibk_config_quirk *xen_pcibk_find_quirk(struct pci_dev *dev) | |||
36 | goto out; | 35 | goto out; |
37 | tmp_quirk = NULL; | 36 | tmp_quirk = NULL; |
38 | printk(KERN_DEBUG DRV_NAME | 37 | printk(KERN_DEBUG DRV_NAME |
39 | ":quirk didn't match any device xen_pciback knows about\n"); | 38 | ": quirk didn't match any device known\n"); |
40 | out: | 39 | out: |
41 | return tmp_quirk; | 40 | return tmp_quirk; |
42 | } | 41 | } |