diff options
author | Roland Dreier <rdreier@cisco.com> | 2008-02-28 12:48:10 -0500 |
---|---|---|
committer | Wim Van Sebroeck <wim@iguana.be> | 2008-03-06 06:10:44 -0500 |
commit | ef82710a3f80cd24d459c508f91542ecccb1f340 (patch) | |
tree | 11c1454eb39f0f82378f179bb15f43b992093613 /drivers/watchdog | |
parent | 103018aca2e4ba0d0e230efa864231c59228f419 (diff) |
[WATCHDOG] Fix return value warning in hpwdt
The return value of smbios_scan_machine() is never used, and when it
succeeds it doesn't return anything, so just make it void. This fixes:
drivers/watchdog/hpwdt.c: In function 'smbios_scan_machine':
drivers/watchdog/hpwdt.c:562: warning: control reaches end of non-void function
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Acked-by: Thomas Mingarelli <Thomas.Mingarelli@hp.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'drivers/watchdog')
-rw-r--r-- | drivers/watchdog/hpwdt.c | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index cd1cc2dacee7..b1cd0aca9b3c 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c | |||
@@ -528,20 +528,19 @@ static int __devinit smbios_present(const char __iomem *p) | |||
528 | return -ENODEV; | 528 | return -ENODEV; |
529 | } | 529 | } |
530 | 530 | ||
531 | static int __devinit smbios_scan_machine(void) | 531 | static void __devinit smbios_scan_machine(void) |
532 | { | 532 | { |
533 | char __iomem *p, *q; | 533 | char __iomem *p, *q; |
534 | int rc; | ||
535 | 534 | ||
536 | if (efi_enabled) { | 535 | if (efi_enabled) { |
537 | if (efi.smbios == EFI_INVALID_TABLE_ADDR) | 536 | if (efi.smbios == EFI_INVALID_TABLE_ADDR) |
538 | return -ENODEV; | 537 | return; |
539 | 538 | ||
540 | p = ioremap(efi.smbios, 32); | 539 | p = ioremap(efi.smbios, 32); |
541 | if (p == NULL) | 540 | if (p == NULL) |
542 | return -ENOMEM; | 541 | return; |
543 | 542 | ||
544 | rc = smbios_present(p); | 543 | smbios_present(p); |
545 | iounmap(p); | 544 | iounmap(p); |
546 | } else { | 545 | } else { |
547 | /* | 546 | /* |
@@ -549,14 +548,12 @@ static int __devinit smbios_scan_machine(void) | |||
549 | */ | 548 | */ |
550 | p = ioremap(PCI_ROM_BASE1, ROM_SIZE); | 549 | p = ioremap(PCI_ROM_BASE1, ROM_SIZE); |
551 | if (p == NULL) | 550 | if (p == NULL) |
552 | return -ENOMEM; | 551 | return; |
553 | 552 | ||
554 | for (q = p; q < p + ROM_SIZE; q += 16) { | 553 | for (q = p; q < p + ROM_SIZE; q += 16) |
555 | rc = smbios_present(q); | 554 | if (!smbios_present(q)) |
556 | if (!rc) { | ||
557 | break; | 555 | break; |
558 | } | 556 | |
559 | } | ||
560 | iounmap(p); | 557 | iounmap(p); |
561 | } | 558 | } |
562 | } | 559 | } |