diff options
author | Jingoo Han <jg1.han@samsung.com> | 2014-02-27 00:41:42 -0500 |
---|---|---|
committer | Wim Van Sebroeck <wim@iguana.be> | 2014-03-31 07:31:06 -0400 |
commit | 5f5e19093b2fa592720810154f15ffe51aa9277f (patch) | |
tree | 7fb419b6839947540fb76f78243864a1c9838e41 /drivers/watchdog | |
parent | c33a15974c1a326b0034cc2a2e73fac92ae8d001 (diff) |
watchdog: fix checkpatch warnings and error
Fix the following checkpatch warnings and error:
WARNING: quoted string split across lines
WARNING: braces {} are not necessary for single statement blocks
WARNING: __initdata should be placed after ibmasr_id_table[]
WARNING: please, no space before tabs
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog')
-rw-r--r-- | drivers/watchdog/ep93xx_wdt.c | 6 | ||||
-rw-r--r-- | drivers/watchdog/iTCO_wdt.c | 6 | ||||
-rw-r--r-- | drivers/watchdog/ibmasr.c | 2 | ||||
-rw-r--r-- | drivers/watchdog/pc87413_wdt.c | 7 | ||||
-rw-r--r-- | drivers/watchdog/softdog.c | 2 | ||||
-rw-r--r-- | drivers/watchdog/w83697hf_wdt.c | 4 |
6 files changed, 13 insertions, 14 deletions
diff --git a/drivers/watchdog/ep93xx_wdt.c b/drivers/watchdog/ep93xx_wdt.c index 5e4f3dea85f5..5f54e1e5819a 100644 --- a/drivers/watchdog/ep93xx_wdt.c +++ b/drivers/watchdog/ep93xx_wdt.c | |||
@@ -165,9 +165,9 @@ static struct platform_driver ep93xx_wdt_driver = { | |||
165 | 165 | ||
166 | module_platform_driver(ep93xx_wdt_driver); | 166 | module_platform_driver(ep93xx_wdt_driver); |
167 | 167 | ||
168 | MODULE_AUTHOR("Ray Lehtiniemi <rayl@mail.com>," | 168 | MODULE_AUTHOR("Ray Lehtiniemi <rayl@mail.com>"); |
169 | "Alessandro Zummo <a.zummo@towertech.it>," | 169 | MODULE_AUTHOR("Alessandro Zummo <a.zummo@towertech.it>"); |
170 | "H Hartley Sweeten <hsweeten@visionengravers.com>"); | 170 | MODULE_AUTHOR("H Hartley Sweeten <hsweeten@visionengravers.com>"); |
171 | MODULE_DESCRIPTION("EP93xx Watchdog"); | 171 | MODULE_DESCRIPTION("EP93xx Watchdog"); |
172 | MODULE_LICENSE("GPL"); | 172 | MODULE_LICENSE("GPL"); |
173 | MODULE_VERSION(WDT_VERSION); | 173 | MODULE_VERSION(WDT_VERSION); |
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c index 04f8af65acfd..6532e7a260d8 100644 --- a/drivers/watchdog/iTCO_wdt.c +++ b/drivers/watchdog/iTCO_wdt.c | |||
@@ -347,15 +347,15 @@ static const struct watchdog_info ident = { | |||
347 | static const struct watchdog_ops iTCO_wdt_ops = { | 347 | static const struct watchdog_ops iTCO_wdt_ops = { |
348 | .owner = THIS_MODULE, | 348 | .owner = THIS_MODULE, |
349 | .start = iTCO_wdt_start, | 349 | .start = iTCO_wdt_start, |
350 | .stop = iTCO_wdt_stop, | 350 | .stop = iTCO_wdt_stop, |
351 | .ping = iTCO_wdt_ping, | 351 | .ping = iTCO_wdt_ping, |
352 | .set_timeout = iTCO_wdt_set_timeout, | 352 | .set_timeout = iTCO_wdt_set_timeout, |
353 | .get_timeleft = iTCO_wdt_get_timeleft, | 353 | .get_timeleft = iTCO_wdt_get_timeleft, |
354 | }; | 354 | }; |
355 | 355 | ||
356 | static struct watchdog_device iTCO_wdt_watchdog_dev = { | 356 | static struct watchdog_device iTCO_wdt_watchdog_dev = { |
357 | .info = &ident, | 357 | .info = &ident, |
358 | .ops = &iTCO_wdt_ops, | 358 | .ops = &iTCO_wdt_ops, |
359 | }; | 359 | }; |
360 | 360 | ||
361 | /* | 361 | /* |
diff --git a/drivers/watchdog/ibmasr.c b/drivers/watchdog/ibmasr.c index db0a34460e57..366b0474f278 100644 --- a/drivers/watchdog/ibmasr.c +++ b/drivers/watchdog/ibmasr.c | |||
@@ -360,7 +360,7 @@ struct ibmasr_id { | |||
360 | int type; | 360 | int type; |
361 | }; | 361 | }; |
362 | 362 | ||
363 | static struct ibmasr_id __initdata ibmasr_id_table[] = { | 363 | static struct ibmasr_id ibmasr_id_table[] __initdata = { |
364 | { "IBM Automatic Server Restart - eserver xSeries 220", ASMTYPE_TOPAZ }, | 364 | { "IBM Automatic Server Restart - eserver xSeries 220", ASMTYPE_TOPAZ }, |
365 | { "IBM Automatic Server Restart - Machine Type 8673", ASMTYPE_PEARL }, | 365 | { "IBM Automatic Server Restart - Machine Type 8673", ASMTYPE_PEARL }, |
366 | { "IBM Automatic Server Restart - Machine Type 8480", ASMTYPE_JASPER }, | 366 | { "IBM Automatic Server Restart - Machine Type 8480", ASMTYPE_JASPER }, |
diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c index 5211d56b3681..9f15dd9435d1 100644 --- a/drivers/watchdog/pc87413_wdt.c +++ b/drivers/watchdog/pc87413_wdt.c | |||
@@ -512,9 +512,8 @@ static int __init pc87413_init(void) | |||
512 | return -EBUSY; | 512 | return -EBUSY; |
513 | 513 | ||
514 | ret = register_reboot_notifier(&pc87413_notifier); | 514 | ret = register_reboot_notifier(&pc87413_notifier); |
515 | if (ret != 0) { | 515 | if (ret != 0) |
516 | pr_err("cannot register reboot notifier (err=%d)\n", ret); | 516 | pr_err("cannot register reboot notifier (err=%d)\n", ret); |
517 | } | ||
518 | 517 | ||
519 | ret = misc_register(&pc87413_miscdev); | 518 | ret = misc_register(&pc87413_miscdev); |
520 | if (ret != 0) { | 519 | if (ret != 0) { |
@@ -575,8 +574,8 @@ static void __exit pc87413_exit(void) | |||
575 | module_init(pc87413_init); | 574 | module_init(pc87413_init); |
576 | module_exit(pc87413_exit); | 575 | module_exit(pc87413_exit); |
577 | 576 | ||
578 | MODULE_AUTHOR("Sven Anders <anders@anduras.de>, " | 577 | MODULE_AUTHOR("Sven Anders <anders@anduras.de>"); |
579 | "Marcus Junker <junker@anduras.de>,"); | 578 | MODULE_AUTHOR("Marcus Junker <junker@anduras.de>"); |
580 | MODULE_DESCRIPTION("PC87413 WDT driver"); | 579 | MODULE_DESCRIPTION("PC87413 WDT driver"); |
581 | MODULE_LICENSE("GPL"); | 580 | MODULE_LICENSE("GPL"); |
582 | 581 | ||
diff --git a/drivers/watchdog/softdog.c b/drivers/watchdog/softdog.c index c04a1aa158e2..0dc5e323d59d 100644 --- a/drivers/watchdog/softdog.c +++ b/drivers/watchdog/softdog.c | |||
@@ -62,7 +62,7 @@ MODULE_PARM_DESC(nowayout, | |||
62 | "Watchdog cannot be stopped once started (default=" | 62 | "Watchdog cannot be stopped once started (default=" |
63 | __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); | 63 | __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); |
64 | 64 | ||
65 | static int soft_noboot = 0; | 65 | static int soft_noboot; |
66 | module_param(soft_noboot, int, 0); | 66 | module_param(soft_noboot, int, 0); |
67 | MODULE_PARM_DESC(soft_noboot, | 67 | MODULE_PARM_DESC(soft_noboot, |
68 | "Softdog action, set to 1 to ignore reboots, 0 to reboot (default=0)"); | 68 | "Softdog action, set to 1 to ignore reboots, 0 to reboot (default=0)"); |
diff --git a/drivers/watchdog/w83697hf_wdt.c b/drivers/watchdog/w83697hf_wdt.c index 68b45fc9ba6a..e9ea856b8ff2 100644 --- a/drivers/watchdog/w83697hf_wdt.c +++ b/drivers/watchdog/w83697hf_wdt.c | |||
@@ -455,6 +455,6 @@ module_init(wdt_init); | |||
455 | module_exit(wdt_exit); | 455 | module_exit(wdt_exit); |
456 | 456 | ||
457 | MODULE_LICENSE("GPL"); | 457 | MODULE_LICENSE("GPL"); |
458 | MODULE_AUTHOR("Marcus Junker <junker@anduras.de>, " | 458 | MODULE_AUTHOR("Marcus Junker <junker@anduras.de>"); |
459 | "Samuel Tardieu <sam@rfc1149.net>"); | 459 | MODULE_AUTHOR("Samuel Tardieu <sam@rfc1149.net>"); |
460 | MODULE_DESCRIPTION("w83697hf/hg WDT driver"); | 460 | MODULE_DESCRIPTION("w83697hf/hg WDT driver"); |