diff options
author | Adrian Bunk <bunk@kernel.org> | 2008-08-08 11:39:11 -0400 |
---|---|---|
committer | Wim Van Sebroeck <wim@iguana.be> | 2008-08-10 16:22:32 -0400 |
commit | 58cf41984a3791e7a516641f107ff70bd844ef72 (patch) | |
tree | 8224333334ad1bb2216f9c35b9a9df5d451bbd80 /drivers/watchdog | |
parent | f8494e061799905dc2eb787c148cfbfb134b928f (diff) |
[WATCHDOG] fix watchdog/shwdt.c compilation
This patch fixes the following compile errors caused by
commit 70b814ec1a484279a51bf9f7193551b996627247
([WATCHDOG 45/57] shwdt: coding style, cleanup, switch to unlocked_io):
<-- snip -->
...
CC drivers/watchdog/shwdt.o
shwdt.c:64: error: 'WTCSR_CKS_4096' undeclared here (not in a function)
shwdt.c: In function 'sh_wdt_start':
shwdt.c:92: error: 'wdt_lock' undeclared (first use in this function)
shwdt.c:92: error: (Each undeclared identifier is reported only once
shwdt.c:92: error: for each function it appears in.)
shwdt.c:97: error: implicit declaration of function 'sh_wdt_read_csr'
shwdt.c:98: error: 'WTCSR_WT' undeclared (first use in this function)
shwdt.c:99: error: implicit declaration of function 'sh_wdt_write_csr'
shwdt.c:101: error: implicit declaration of function 'sh_wdt_write_cnt'
shwdt.c:112: error: 'WTCSR_TME' undeclared (first use in this function)
shwdt.c:113: error: 'WTCSR_RSTS' undeclared (first use in this function)
shwdt.c: In function 'sh_wdt_stop':
shwdt.c:142: error: 'wdt_lock' undeclared (first use in this function)
shwdt.c:147: error: 'WTCSR_TME' undeclared (first use in this function)
shwdt.c: In function 'sh_wdt_keepalive':
shwdt.c:160: error: 'wdt_lock' undeclared (first use in this function)
shwdt.c: In function 'sh_wdt_set_heartbeat':
shwdt.c:176: error: 'wdt_lock' undeclared (first use in this function)
shwdt.c: In function 'sh_wdt_ping':
shwdt.c:192: error: 'wdt_lock' undeclared (first use in this function)
shwdt.c:197: error: 'WTCSR_IOVF' undeclared (first use in this function)
shwdt.c: At top level:
shwdt.c:417: error: conflicting type qualifiers for 'sh_wdt_info'
shwdt.c:71: error: previous declaration of 'sh_wdt_info' was here
make[3]: *** [drivers/watchdog/shwdt.o] Error 1
<-- snip -->
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog')
-rw-r--r-- | drivers/watchdog/shwdt.c | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/drivers/watchdog/shwdt.c b/drivers/watchdog/shwdt.c index 824125adf90a..cdc7138be301 100644 --- a/drivers/watchdog/shwdt.c +++ b/drivers/watchdog/shwdt.c | |||
@@ -30,7 +30,7 @@ | |||
30 | #include <linux/mm.h> | 30 | #include <linux/mm.h> |
31 | #include <linux/io.h> | 31 | #include <linux/io.h> |
32 | #include <linux/uaccess.h> | 32 | #include <linux/uaccess.h> |
33 | #include <linux/watchdog.h> | 33 | #include <asm/watchdog.h> |
34 | 34 | ||
35 | #define PFX "shwdt: " | 35 | #define PFX "shwdt: " |
36 | 36 | ||
@@ -68,7 +68,7 @@ static int clock_division_ratio = WTCSR_CKS_4096; | |||
68 | static void sh_wdt_ping(unsigned long data); | 68 | static void sh_wdt_ping(unsigned long data); |
69 | 69 | ||
70 | static unsigned long shwdt_is_open; | 70 | static unsigned long shwdt_is_open; |
71 | static struct watchdog_info sh_wdt_info; | 71 | static const struct watchdog_info sh_wdt_info; |
72 | static char shwdt_expect_close; | 72 | static char shwdt_expect_close; |
73 | static DEFINE_TIMER(timer, sh_wdt_ping, 0, 0); | 73 | static DEFINE_TIMER(timer, sh_wdt_ping, 0, 0); |
74 | static unsigned long next_heartbeat; | 74 | static unsigned long next_heartbeat; |
@@ -89,7 +89,7 @@ static void sh_wdt_start(void) | |||
89 | __u8 csr; | 89 | __u8 csr; |
90 | unsigned long flags; | 90 | unsigned long flags; |
91 | 91 | ||
92 | spin_lock_irqsave(&wdt_lock, flags); | 92 | spin_lock_irqsave(&shwdt_lock, flags); |
93 | 93 | ||
94 | next_heartbeat = jiffies + (heartbeat * HZ); | 94 | next_heartbeat = jiffies + (heartbeat * HZ); |
95 | mod_timer(&timer, next_ping_period(clock_division_ratio)); | 95 | mod_timer(&timer, next_ping_period(clock_division_ratio)); |
@@ -127,7 +127,7 @@ static void sh_wdt_start(void) | |||
127 | csr &= ~RSTCSR_RSTS; | 127 | csr &= ~RSTCSR_RSTS; |
128 | sh_wdt_write_rstcsr(csr); | 128 | sh_wdt_write_rstcsr(csr); |
129 | #endif | 129 | #endif |
130 | spin_unlock_irqrestore(&wdt_lock, flags); | 130 | spin_unlock_irqrestore(&shwdt_lock, flags); |
131 | } | 131 | } |
132 | 132 | ||
133 | /** | 133 | /** |
@@ -139,14 +139,14 @@ static void sh_wdt_stop(void) | |||
139 | __u8 csr; | 139 | __u8 csr; |
140 | unsigned long flags; | 140 | unsigned long flags; |
141 | 141 | ||
142 | spin_lock_irqsave(&wdt_lock, flags); | 142 | spin_lock_irqsave(&shwdt_lock, flags); |
143 | 143 | ||
144 | del_timer(&timer); | 144 | del_timer(&timer); |
145 | 145 | ||
146 | csr = sh_wdt_read_csr(); | 146 | csr = sh_wdt_read_csr(); |
147 | csr &= ~WTCSR_TME; | 147 | csr &= ~WTCSR_TME; |
148 | sh_wdt_write_csr(csr); | 148 | sh_wdt_write_csr(csr); |
149 | spin_unlock_irqrestore(&wdt_lock, flags); | 149 | spin_unlock_irqrestore(&shwdt_lock, flags); |
150 | } | 150 | } |
151 | 151 | ||
152 | /** | 152 | /** |
@@ -157,9 +157,9 @@ static inline void sh_wdt_keepalive(void) | |||
157 | { | 157 | { |
158 | unsigned long flags; | 158 | unsigned long flags; |
159 | 159 | ||
160 | spin_lock_irqsave(&wdt_lock, flags); | 160 | spin_lock_irqsave(&shwdt_lock, flags); |
161 | next_heartbeat = jiffies + (heartbeat * HZ); | 161 | next_heartbeat = jiffies + (heartbeat * HZ); |
162 | spin_unlock_irqrestore(&wdt_lock, flags); | 162 | spin_unlock_irqrestore(&shwdt_lock, flags); |
163 | } | 163 | } |
164 | 164 | ||
165 | /** | 165 | /** |
@@ -173,9 +173,9 @@ static int sh_wdt_set_heartbeat(int t) | |||
173 | if (unlikely(t < 1 || t > 3600)) /* arbitrary upper limit */ | 173 | if (unlikely(t < 1 || t > 3600)) /* arbitrary upper limit */ |
174 | return -EINVAL; | 174 | return -EINVAL; |
175 | 175 | ||
176 | spin_lock_irqsave(&wdt_lock, flags); | 176 | spin_lock_irqsave(&shwdt_lock, flags); |
177 | heartbeat = t; | 177 | heartbeat = t; |
178 | spin_unlock_irqrestore(&wdt_lock, flags); | 178 | spin_unlock_irqrestore(&shwdt_lock, flags); |
179 | return 0; | 179 | return 0; |
180 | } | 180 | } |
181 | 181 | ||
@@ -189,7 +189,7 @@ static void sh_wdt_ping(unsigned long data) | |||
189 | { | 189 | { |
190 | unsigned long flags; | 190 | unsigned long flags; |
191 | 191 | ||
192 | spin_lock_irqsave(&wdt_lock, flags); | 192 | spin_lock_irqsave(&shwdt_lock, flags); |
193 | if (time_before(jiffies, next_heartbeat)) { | 193 | if (time_before(jiffies, next_heartbeat)) { |
194 | __u8 csr; | 194 | __u8 csr; |
195 | 195 | ||
@@ -203,7 +203,7 @@ static void sh_wdt_ping(unsigned long data) | |||
203 | } else | 203 | } else |
204 | printk(KERN_WARNING PFX "Heartbeat lost! Will not ping " | 204 | printk(KERN_WARNING PFX "Heartbeat lost! Will not ping " |
205 | "the watchdog\n"); | 205 | "the watchdog\n"); |
206 | spin_unlock_irqrestore(&wdt_lock, flags); | 206 | spin_unlock_irqrestore(&shwdt_lock, flags); |
207 | } | 207 | } |
208 | 208 | ||
209 | /** | 209 | /** |