diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-23 18:42:42 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-23 18:42:42 -0400 |
commit | 0b87da68a0f0a7bf7f7446cf64f92e672bd68ef8 (patch) | |
tree | cc5ddfd411bc9c5d6fb828b86eba92f50294805e /drivers/watchdog/wm831x_wdt.c | |
parent | 59d0952b43552570e0f1c3ff91ebb16d4caec171 (diff) | |
parent | cad19fa66469d2a745fae0c168833d5d33d64489 (diff) |
Merge git://www.linux-watchdog.org/linux-watchdog
Pull first set of watchdog updates from Wim Van Sebroeck:
"This pull contains:
- The removal of ixp2000_wdt
- The addition of ie6xx_wdt
- Some documentation fixes
- Small fixes and improvements
(Note: Part 2 will contain generic watchdog core changes + conversion
of some more drivers)"
* git://www.linux-watchdog.org/linux-watchdog:
Documentation/watchdog: Fix the file descriptor leak when no cmdline arg given
Documentation/watchdog: close the fd when cmdline arg given
Documentation/watchdog: Fix a small typo
watchdog: s3c2410_wdt: Set timeout to actually achieved timeout
watchdog: wm831x: Convert to gpio_request_one()
watchdog: via_wdt: depends on PCI
watchdog: ie6xx_wdt needs io.h
watchdog: ie6xx_wdt.c: fix printk format warning
watchdog: Add watchdog driver for Intel Atom E6XX
watchdog: it87_wdt: Add support for IT8728F watchdog.
watchdog: i6300esb: don't depend on X86
watchdog: Use module_pci_driver
watchdog: sch311x_wdt.c: Remove RESGEN
watchdog: s3c2410-wdt: Use of_match_ptr().
watchdog: Device tree support for pnx4008-wdt
watchdog: ar7_wdt.c: use devm_request_and_ioremap
watchdog: remove ixp2000 driver
watchdog: sp5100_tco.c: quiet sparse noise about using plain integer was NULL pointer
Diffstat (limited to 'drivers/watchdog/wm831x_wdt.c')
-rw-r--r-- | drivers/watchdog/wm831x_wdt.c | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/drivers/watchdog/wm831x_wdt.c b/drivers/watchdog/wm831x_wdt.c index b1815c5ed7a7..87d66d236c3e 100644 --- a/drivers/watchdog/wm831x_wdt.c +++ b/drivers/watchdog/wm831x_wdt.c | |||
@@ -247,8 +247,9 @@ static int __devinit wm831x_wdt_probe(struct platform_device *pdev) | |||
247 | reg |= pdata->software << WM831X_WDOG_RST_SRC_SHIFT; | 247 | reg |= pdata->software << WM831X_WDOG_RST_SRC_SHIFT; |
248 | 248 | ||
249 | if (pdata->update_gpio) { | 249 | if (pdata->update_gpio) { |
250 | ret = gpio_request(pdata->update_gpio, | 250 | ret = gpio_request_one(pdata->update_gpio, |
251 | "Watchdog update"); | 251 | GPIOF_DIR_OUT | GPIOF_INIT_LOW, |
252 | "Watchdog update"); | ||
252 | if (ret < 0) { | 253 | if (ret < 0) { |
253 | dev_err(wm831x->dev, | 254 | dev_err(wm831x->dev, |
254 | "Failed to request update GPIO: %d\n", | 255 | "Failed to request update GPIO: %d\n", |
@@ -256,14 +257,6 @@ static int __devinit wm831x_wdt_probe(struct platform_device *pdev) | |||
256 | goto err; | 257 | goto err; |
257 | } | 258 | } |
258 | 259 | ||
259 | ret = gpio_direction_output(pdata->update_gpio, 0); | ||
260 | if (ret != 0) { | ||
261 | dev_err(wm831x->dev, | ||
262 | "gpio_direction_output returned: %d\n", | ||
263 | ret); | ||
264 | goto err_gpio; | ||
265 | } | ||
266 | |||
267 | driver_data->update_gpio = pdata->update_gpio; | 260 | driver_data->update_gpio = pdata->update_gpio; |
268 | 261 | ||
269 | /* Make sure the watchdog takes hardware updates */ | 262 | /* Make sure the watchdog takes hardware updates */ |