diff options
author | Randy Dunlap <randy.dunlap@oracle.com> | 2010-05-01 12:46:15 -0400 |
---|---|---|
committer | Wim Van Sebroeck <wim@iguana.be> | 2010-05-25 05:03:52 -0400 |
commit | 76550d3292ba1b0dd1ff0a13d78a2718eba599c7 (patch) | |
tree | ee6f77e3434def57114aff43b12c79673a0f22a1 /drivers/watchdog/pc87413_wdt.c | |
parent | 42bd5d499455fe4235bb82cffe937a4089a8bba9 (diff) |
watchdog: fix several MODULE_PARM_DESC strings
Fix MODULE_PARM_DESC() strings in several watchdog drivers.
Some are simple as add a parenthesis.
Others are problems from __stringify() being used on a
variable name instead of a macro name, so the variable name
is produced in the string instead of its build-time value.
In these cases, create a macro for the value so that the
module param description string is useful.
Only pc87413_wdt has been built (due to toolchains).
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog/pc87413_wdt.c')
-rw-r--r-- | drivers/watchdog/pc87413_wdt.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c index d3aa2f1fe61d..3a56bc360924 100644 --- a/drivers/watchdog/pc87413_wdt.c +++ b/drivers/watchdog/pc87413_wdt.c | |||
@@ -53,7 +53,9 @@ | |||
53 | #define WDTO 0x11 /* Watchdog timeout register */ | 53 | #define WDTO 0x11 /* Watchdog timeout register */ |
54 | #define WDCFG 0x12 /* Watchdog config register */ | 54 | #define WDCFG 0x12 /* Watchdog config register */ |
55 | 55 | ||
56 | static int io = 0x2E; /* Address used on Portwell Boards */ | 56 | #define IO_DEFAULT 0x2E /* Address used on Portwell Boards */ |
57 | |||
58 | static int io = IO_DEFAULT; | ||
57 | 59 | ||
58 | static int timeout = DEFAULT_TIMEOUT; /* timeout value */ | 60 | static int timeout = DEFAULT_TIMEOUT; /* timeout value */ |
59 | static unsigned long timer_enabled; /* is the timer enabled? */ | 61 | static unsigned long timer_enabled; /* is the timer enabled? */ |
@@ -583,12 +585,13 @@ MODULE_LICENSE("GPL"); | |||
583 | MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); | 585 | MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); |
584 | 586 | ||
585 | module_param(io, int, 0); | 587 | module_param(io, int, 0); |
586 | MODULE_PARM_DESC(io, MODNAME " I/O port (default: " __MODULE_STRING(io) ")."); | 588 | MODULE_PARM_DESC(io, MODNAME " I/O port (default: " |
589 | __MODULE_STRING(IO_DEFAULT) ")."); | ||
587 | 590 | ||
588 | module_param(timeout, int, 0); | 591 | module_param(timeout, int, 0); |
589 | MODULE_PARM_DESC(timeout, | 592 | MODULE_PARM_DESC(timeout, |
590 | "Watchdog timeout in minutes (default=" | 593 | "Watchdog timeout in minutes (default=" |
591 | __MODULE_STRING(timeout) ")."); | 594 | __MODULE_STRING(DEFAULT_TIMEOUT) ")."); |
592 | 595 | ||
593 | module_param(nowayout, int, 0); | 596 | module_param(nowayout, int, 0); |
594 | MODULE_PARM_DESC(nowayout, | 597 | MODULE_PARM_DESC(nowayout, |