diff options
author | Sachin Kamat <sachin.kamat@linaro.org> | 2013-03-04 00:06:41 -0500 |
---|---|---|
committer | Wim Van Sebroeck <wim@iguana.be> | 2013-05-09 02:12:00 -0400 |
commit | 6330c7070be6783b82025d2bc259db8413c00182 (patch) | |
tree | 32ef8ae643db47f6c8176b15ae22094b58fefa8c /drivers/watchdog/davinci_wdt.c | |
parent | e0fd9affeb64088eff407dfc98bbd3a5c17ea479 (diff) |
watchdog: Convert to devm_ioremap_resource()
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Gabor Juhos <juhosg@openwrt.org>
Cc: Paul Mundt <lethal@linux-sh.org>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog/davinci_wdt.c')
-rw-r--r-- | drivers/watchdog/davinci_wdt.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c index 7df1fdca9e78..100d4fbfde2a 100644 --- a/drivers/watchdog/davinci_wdt.c +++ b/drivers/watchdog/davinci_wdt.c | |||
@@ -27,6 +27,7 @@ | |||
27 | #include <linux/device.h> | 27 | #include <linux/device.h> |
28 | #include <linux/clk.h> | 28 | #include <linux/clk.h> |
29 | #include <linux/slab.h> | 29 | #include <linux/slab.h> |
30 | #include <linux/err.h> | ||
30 | 31 | ||
31 | #define MODULE_NAME "DAVINCI-WDT: " | 32 | #define MODULE_NAME "DAVINCI-WDT: " |
32 | 33 | ||
@@ -221,11 +222,9 @@ static int davinci_wdt_probe(struct platform_device *pdev) | |||
221 | return -ENOENT; | 222 | return -ENOENT; |
222 | } | 223 | } |
223 | 224 | ||
224 | wdt_base = devm_request_and_ioremap(dev, wdt_mem); | 225 | wdt_base = devm_ioremap_resource(dev, wdt_mem); |
225 | if (!wdt_base) { | 226 | if (IS_ERR(wdt_base)) |
226 | dev_err(dev, "ioremap failed\n"); | 227 | return PTR_ERR(wdt_base); |
227 | return -EADDRNOTAVAIL; | ||
228 | } | ||
229 | 228 | ||
230 | ret = misc_register(&davinci_wdt_miscdev); | 229 | ret = misc_register(&davinci_wdt_miscdev); |
231 | if (ret < 0) { | 230 | if (ret < 0) { |