diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-06-13 19:33:54 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-06-13 19:33:54 -0400 |
commit | dd0aa67cd7cf3f4a3ca52ecc1d6b82f3fad1352b (patch) | |
tree | c7cc1c36872fa6e185acd78ec9545ee14b865c17 /drivers/w1 | |
parent | 526be41625a8b2282d5720dcb19f927edbf193b4 (diff) |
Revert "w1: introduce a slave mutex for serializing IO"
This reverts commit 59d4467be405316916a4087d5b02d99196eeef04.
Turns out it was the wrong version, will apply the correct version after
this.
Reported-by: NeilBrown <neilb@suse.de>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/w1')
-rw-r--r-- | drivers/w1/slaves/w1_bq27000.c | 4 | ||||
-rw-r--r-- | drivers/w1/w1.c | 1 | ||||
-rw-r--r-- | drivers/w1/w1.h | 1 |
3 files changed, 2 insertions, 4 deletions
diff --git a/drivers/w1/slaves/w1_bq27000.c b/drivers/w1/slaves/w1_bq27000.c index 87554788fa32..52ad812fa1e7 100644 --- a/drivers/w1/slaves/w1_bq27000.c +++ b/drivers/w1/slaves/w1_bq27000.c | |||
@@ -31,10 +31,10 @@ static int w1_bq27000_read(struct device *dev, unsigned int reg) | |||
31 | u8 val; | 31 | u8 val; |
32 | struct w1_slave *sl = container_of(dev->parent, struct w1_slave, dev); | 32 | struct w1_slave *sl = container_of(dev->parent, struct w1_slave, dev); |
33 | 33 | ||
34 | mutex_lock(&sl->mutex); | 34 | mutex_lock(&sl->master->mutex); |
35 | w1_write_8(sl->master, HDQ_CMD_READ | reg); | 35 | w1_write_8(sl->master, HDQ_CMD_READ | reg); |
36 | val = w1_read_8(sl->master); | 36 | val = w1_read_8(sl->master); |
37 | mutex_unlock(&sl->mutex); | 37 | mutex_unlock(&sl->master->mutex); |
38 | 38 | ||
39 | return val; | 39 | return val; |
40 | } | 40 | } |
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 79e488db5104..bfb898641029 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c | |||
@@ -686,7 +686,6 @@ static int w1_attach_slave_device(struct w1_master *dev, struct w1_reg_num *rn) | |||
686 | memcpy(&sl->reg_num, rn, sizeof(sl->reg_num)); | 686 | memcpy(&sl->reg_num, rn, sizeof(sl->reg_num)); |
687 | atomic_set(&sl->refcnt, 0); | 687 | atomic_set(&sl->refcnt, 0); |
688 | init_completion(&sl->released); | 688 | init_completion(&sl->released); |
689 | mutex_init(&sl->mutex); | ||
690 | 689 | ||
691 | spin_lock(&w1_flock); | 690 | spin_lock(&w1_flock); |
692 | f = w1_family_registered(rn->family); | 691 | f = w1_family_registered(rn->family); |
diff --git a/drivers/w1/w1.h b/drivers/w1/w1.h index 8c8be380a98a..4d012ca3f32c 100644 --- a/drivers/w1/w1.h +++ b/drivers/w1/w1.h | |||
@@ -75,7 +75,6 @@ struct w1_slave | |||
75 | void *family_data; | 75 | void *family_data; |
76 | struct device dev; | 76 | struct device dev; |
77 | struct completion released; | 77 | struct completion released; |
78 | struct mutex mutex; | ||
79 | }; | 78 | }; |
80 | 79 | ||
81 | typedef void (*w1_slave_found_callback)(struct w1_master *, u64); | 80 | typedef void (*w1_slave_found_callback)(struct w1_master *, u64); |