diff options
author | Christoph Lameter <christoph@lameter.com> | 2005-06-25 02:13:50 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-06-25 20:10:13 -0400 |
commit | 3e1d1d28d99dabe63c64f7f40f1ca1d646de1f73 (patch) | |
tree | d1e7c1e2e8902072042aefc3a7976b271cf76021 /drivers/w1 | |
parent | b3e112bcc19abd8e9657dca34a87316786e096f3 (diff) |
[PATCH] Cleanup patch for process freezing
1. Establish a simple API for process freezing defined in linux/include/sched.h:
frozen(process) Check for frozen process
freezing(process) Check if a process is being frozen
freeze(process) Tell a process to freeze (go to refrigerator)
thaw_process(process) Restart process
frozen_process(process) Process is frozen now
2. Remove all references to PF_FREEZE and PF_FROZEN from all
kernel sources except sched.h
3. Fix numerous locations where try_to_freeze is manually done by a driver
4. Remove the argument that is no longer necessary from two function calls.
5. Some whitespace cleanup
6. Clear potential race in refrigerator (provides an open window of PF_FREEZE
cleared before setting PF_FROZEN, recalc_sigpending does not check
PF_FROZEN).
This patch does not address the problem of freeze_processes() violating the rule
that a task may only modify its own flags by setting PF_FREEZE. This is not clean
in an SMP environment. freeze(process) is therefore not SMP safe!
Signed-off-by: Christoph Lameter <christoph@lameter.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/w1')
-rw-r--r-- | drivers/w1/w1.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index b460927ec32a..312cf3220f12 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c | |||
@@ -646,7 +646,7 @@ static int w1_control(void *data) | |||
646 | while (!control_needs_exit || have_to_wait) { | 646 | while (!control_needs_exit || have_to_wait) { |
647 | have_to_wait = 0; | 647 | have_to_wait = 0; |
648 | 648 | ||
649 | try_to_freeze(PF_FREEZE); | 649 | try_to_freeze(); |
650 | msleep_interruptible(w1_timeout * 1000); | 650 | msleep_interruptible(w1_timeout * 1000); |
651 | 651 | ||
652 | if (signal_pending(current)) | 652 | if (signal_pending(current)) |
@@ -725,7 +725,7 @@ int w1_process(void *data) | |||
725 | allow_signal(SIGTERM); | 725 | allow_signal(SIGTERM); |
726 | 726 | ||
727 | while (!test_bit(W1_MASTER_NEED_EXIT, &dev->flags)) { | 727 | while (!test_bit(W1_MASTER_NEED_EXIT, &dev->flags)) { |
728 | try_to_freeze(PF_FREEZE); | 728 | try_to_freeze(); |
729 | msleep_interruptible(w1_timeout * 1000); | 729 | msleep_interruptible(w1_timeout * 1000); |
730 | 730 | ||
731 | if (signal_pending(current)) | 731 | if (signal_pending(current)) |