aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/virtio
diff options
context:
space:
mode:
authorRusty Russell <rusty@rustcorp.com.au>2015-02-10 23:31:14 -0500
committerRusty Russell <rusty@rustcorp.com.au>2015-02-10 23:33:16 -0500
commit7abb568dbb32d055ec6a5633d26fb39fbcd525e3 (patch)
tree7e5aac0a98bbcd55d764a28c84743a02ff72e320 /drivers/virtio
parent6d96ee98b1d08bcf0f90a6bf2c6766dda6b3a010 (diff)
virtio_pci: use 16-bit accessor for queue_enable.
Since PCI is little endian, 8-bit access might work, but the spec section is very clear on this: 4.1.3.1 Driver Requirements: PCI Device Layout The driver MUST access each field using the “natural” access method, i.e. 32-bit accesses for 32-bit fields, 16-bit accesses for 16-bit fields and 8-bit accesses for 8-bit fields. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/virtio')
-rw-r--r--drivers/virtio/virtio_pci_modern.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c
index f16e462cb4ef..2aa38e59db2e 100644
--- a/drivers/virtio/virtio_pci_modern.c
+++ b/drivers/virtio/virtio_pci_modern.c
@@ -294,7 +294,7 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
294 294
295 /* Check if queue is either not available or already active. */ 295 /* Check if queue is either not available or already active. */
296 num = ioread16(&cfg->queue_size); 296 num = ioread16(&cfg->queue_size);
297 if (!num || ioread8(&cfg->queue_enable)) 297 if (!num || ioread16(&cfg->queue_enable))
298 return ERR_PTR(-ENOENT); 298 return ERR_PTR(-ENOENT);
299 299
300 if (num & (num - 1)) { 300 if (num & (num - 1)) {
@@ -394,7 +394,7 @@ static int vp_modern_find_vqs(struct virtio_device *vdev, unsigned nvqs,
394 */ 394 */
395 list_for_each_entry(vq, &vdev->vqs, list) { 395 list_for_each_entry(vq, &vdev->vqs, list) {
396 iowrite16(vq->index, &vp_dev->common->queue_select); 396 iowrite16(vq->index, &vp_dev->common->queue_select);
397 iowrite8(1, &vp_dev->common->queue_enable); 397 iowrite16(1, &vp_dev->common->queue_enable);
398 } 398 }
399 399
400 return 0; 400 return 0;