aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorMarcelo Tosatti <mtosatti@redhat.com>2013-06-20 17:05:56 -0400
committerDave Airlie <airlied@redhat.com>2013-06-26 02:27:55 -0400
commit7e6d72c15ff4cc0c27573901bb05f9eddbd71ed4 (patch)
treeb9a2ea68e5455051856b3bf6693cd548d435a0ec /drivers/video
parent5cef29aa5227e6347145940a7bccde92fd9a1afa (diff)
vgacon.c: add cond reschedule points in vgacon_do_font_op
Booting a 64-vcpu KVM guest, with CONFIG_PREEMPT_VOLUNTARY, can result in a soft lockup: BUG: soft lockup - CPU#41 stuck for 67s! [setfont:1505] RIP: 0010:[<ffffffff812c48da>] [<ffffffff812c48da>] vgacon_do_font_op.clone.0+0x1ba/0x550 This is due to the 8192 (cmapsz) IO operations taking longer than expected due to lock contention in QEMU. Add conditional resched points in between writes allowing other tasks to execute. Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com> Cc: stable@vger.kernel.org Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/console/vgacon.c16
1 files changed, 12 insertions, 4 deletions
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index 5855d17d19ac..0dd6d9625bb5 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -1124,11 +1124,15 @@ static int vgacon_do_font_op(struct vgastate *state,char *arg,int set,int ch512)
1124 1124
1125 if (arg) { 1125 if (arg) {
1126 if (set) 1126 if (set)
1127 for (i = 0; i < cmapsz; i++) 1127 for (i = 0; i < cmapsz; i++) {
1128 vga_writeb(arg[i], charmap + i); 1128 vga_writeb(arg[i], charmap + i);
1129 cond_resched();
1130 }
1129 else 1131 else
1130 for (i = 0; i < cmapsz; i++) 1132 for (i = 0; i < cmapsz; i++) {
1131 arg[i] = vga_readb(charmap + i); 1133 arg[i] = vga_readb(charmap + i);
1134 cond_resched();
1135 }
1132 1136
1133 /* 1137 /*
1134 * In 512-character mode, the character map is not contiguous if 1138 * In 512-character mode, the character map is not contiguous if
@@ -1139,11 +1143,15 @@ static int vgacon_do_font_op(struct vgastate *state,char *arg,int set,int ch512)
1139 charmap += 2 * cmapsz; 1143 charmap += 2 * cmapsz;
1140 arg += cmapsz; 1144 arg += cmapsz;
1141 if (set) 1145 if (set)
1142 for (i = 0; i < cmapsz; i++) 1146 for (i = 0; i < cmapsz; i++) {
1143 vga_writeb(arg[i], charmap + i); 1147 vga_writeb(arg[i], charmap + i);
1148 cond_resched();
1149 }
1144 else 1150 else
1145 for (i = 0; i < cmapsz; i++) 1151 for (i = 0; i < cmapsz; i++) {
1146 arg[i] = vga_readb(charmap + i); 1152 arg[i] = vga_readb(charmap + i);
1153 cond_resched();
1154 }
1147 } 1155 }
1148 } 1156 }
1149 1157