diff options
author | Vivek Kutal <vivek.kutal@azingo.com> | 2009-06-16 18:34:42 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-06-16 22:48:01 -0400 |
commit | 3608c66c2e6522952b4be219317b194ab27f4e78 (patch) | |
tree | 286a8542aa0c7be32b672aeeff5ea11198a2c640 /drivers/video | |
parent | 9990bfd0e5d4aae9c33693aef8b0a36577c63677 (diff) |
fbdev: *bfin*: drop unnecessary calls to memset
The dma_alloc_* functions sets the memory to 0 before returning so there
is no need to call memset after the allocation. Also no point in clearing
the memory when disabling the buffer.
Signed-off-by: Vivek Kutal <vivek.kutal@azingo.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video')
-rw-r--r-- | drivers/video/bf54x-lq043fb.c | 3 | ||||
-rw-r--r-- | drivers/video/bfin-t350mcqb-fb.c | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c index 37e60b1d2ed9..6439a437ddf9 100644 --- a/drivers/video/bf54x-lq043fb.c +++ b/drivers/video/bf54x-lq043fb.c | |||
@@ -323,7 +323,6 @@ static int bfin_bf54x_fb_release(struct fb_info *info, int user) | |||
323 | bfin_write_EPPI0_CONTROL(0); | 323 | bfin_write_EPPI0_CONTROL(0); |
324 | SSYNC(); | 324 | SSYNC(); |
325 | disable_dma(CH_EPPI0); | 325 | disable_dma(CH_EPPI0); |
326 | memset(fbi->fb_buffer, 0, info->fix.smem_len); | ||
327 | } | 326 | } |
328 | 327 | ||
329 | spin_unlock(&fbi->lock); | 328 | spin_unlock(&fbi->lock); |
@@ -626,8 +625,6 @@ static int __init bfin_bf54x_probe(struct platform_device *pdev) | |||
626 | goto out3; | 625 | goto out3; |
627 | } | 626 | } |
628 | 627 | ||
629 | memset(info->fb_buffer, 0, fbinfo->fix.smem_len); | ||
630 | |||
631 | fbinfo->screen_base = (void *)info->fb_buffer; | 628 | fbinfo->screen_base = (void *)info->fb_buffer; |
632 | fbinfo->fix.smem_start = (int)info->fb_buffer; | 629 | fbinfo->fix.smem_start = (int)info->fb_buffer; |
633 | 630 | ||
diff --git a/drivers/video/bfin-t350mcqb-fb.c b/drivers/video/bfin-t350mcqb-fb.c index 2a2e116b7fb1..f40eef8d1dda 100644 --- a/drivers/video/bfin-t350mcqb-fb.c +++ b/drivers/video/bfin-t350mcqb-fb.c | |||
@@ -242,7 +242,6 @@ static int bfin_t350mcqb_fb_release(struct fb_info *info, int user) | |||
242 | SSYNC(); | 242 | SSYNC(); |
243 | disable_dma(CH_PPI); | 243 | disable_dma(CH_PPI); |
244 | bfin_t350mcqb_stop_timers(); | 244 | bfin_t350mcqb_stop_timers(); |
245 | memset(fbi->fb_buffer, 0, info->fix.smem_len); | ||
246 | } | 245 | } |
247 | 246 | ||
248 | spin_unlock(&fbi->lock); | 247 | spin_unlock(&fbi->lock); |
@@ -527,8 +526,6 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev) | |||
527 | goto out3; | 526 | goto out3; |
528 | } | 527 | } |
529 | 528 | ||
530 | memset(info->fb_buffer, 0, fbinfo->fix.smem_len); | ||
531 | |||
532 | fbinfo->screen_base = (void *)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET; | 529 | fbinfo->screen_base = (void *)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET; |
533 | fbinfo->fix.smem_start = (int)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET; | 530 | fbinfo->fix.smem_start = (int)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET; |
534 | 531 | ||