diff options
author | Devendra Naga <devendra.aaru@gmail.com> | 2013-02-21 19:43:52 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-02-21 20:22:24 -0500 |
commit | aea00a6c370cff79b58503c012943d6a298eb527 (patch) | |
tree | 0ef16f0facb6959a2ddc379af788d37ba2cdc19a /drivers/video | |
parent | 47cf076b4407010573dee9eadc998ff9ecf8397c (diff) |
drivers/video/backlight/lm3639_bl.c: remove ret = -EIO at error paths of probe
The APIs are returning correctly the err codes, no need to assign -EIO
to the ret again.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Acked-by: Daniel Jeong <daniel.jeong@ti.com>
Cc: G.Shark Jeong <gshark.jeong@gmail.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video')
-rw-r--r-- | drivers/video/backlight/lm3639_bl.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c index 7ab2d2a04e41..053964da8dd3 100644 --- a/drivers/video/backlight/lm3639_bl.c +++ b/drivers/video/backlight/lm3639_bl.c | |||
@@ -350,14 +350,13 @@ static int lm3639_probe(struct i2c_client *client, | |||
350 | &lm3639_bled_ops, &props); | 350 | &lm3639_bled_ops, &props); |
351 | if (IS_ERR(pchip->bled)) { | 351 | if (IS_ERR(pchip->bled)) { |
352 | dev_err(&client->dev, "fail : backlight register\n"); | 352 | dev_err(&client->dev, "fail : backlight register\n"); |
353 | ret = -EIO; | 353 | ret = PTR_ERR(pchip->bled); |
354 | goto err_out; | 354 | goto err_out; |
355 | } | 355 | } |
356 | 356 | ||
357 | ret = device_create_file(&(pchip->bled->dev), &dev_attr_bled_mode); | 357 | ret = device_create_file(&(pchip->bled->dev), &dev_attr_bled_mode); |
358 | if (ret < 0) { | 358 | if (ret < 0) { |
359 | dev_err(&client->dev, "failed : add sysfs entries\n"); | 359 | dev_err(&client->dev, "failed : add sysfs entries\n"); |
360 | ret = -EIO; | ||
361 | goto err_bled_mode; | 360 | goto err_bled_mode; |
362 | } | 361 | } |
363 | 362 | ||
@@ -369,7 +368,6 @@ static int lm3639_probe(struct i2c_client *client, | |||
369 | &client->dev, &pchip->cdev_flash); | 368 | &client->dev, &pchip->cdev_flash); |
370 | if (ret < 0) { | 369 | if (ret < 0) { |
371 | dev_err(&client->dev, "fail : flash register\n"); | 370 | dev_err(&client->dev, "fail : flash register\n"); |
372 | ret = -EIO; | ||
373 | goto err_flash; | 371 | goto err_flash; |
374 | } | 372 | } |
375 | 373 | ||
@@ -381,7 +379,6 @@ static int lm3639_probe(struct i2c_client *client, | |||
381 | &client->dev, &pchip->cdev_torch); | 379 | &client->dev, &pchip->cdev_torch); |
382 | if (ret < 0) { | 380 | if (ret < 0) { |
383 | dev_err(&client->dev, "fail : torch register\n"); | 381 | dev_err(&client->dev, "fail : torch register\n"); |
384 | ret = -EIO; | ||
385 | goto err_torch; | 382 | goto err_torch; |
386 | } | 383 | } |
387 | 384 | ||