diff options
author | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2012-12-13 05:17:08 -0500 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2012-12-13 05:18:24 -0500 |
commit | c7e1eae537652330cec3fbf5f8f50000b2f24269 (patch) | |
tree | d1752293bb9899b6817f307ad6215abfe42751fe /drivers/video | |
parent | fa0c5e71295fa4d62b900818d900c16980985e72 (diff) |
OMAPFB: remove silly loop in fb2display()
fb2display() has a for loop which always returns at the first iteration.
Replace the loop with a simple if.
This removes the smatch warning:
drivers/video/omap2/omapfb/omapfb.h:153 fb2display() info: loop could be
replaced with if statement.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video')
-rw-r--r-- | drivers/video/omap2/omapfb/omapfb.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/video/omap2/omapfb/omapfb.h b/drivers/video/omap2/omapfb/omapfb.h index 71cd8bab31c0..2b5264475ed4 100644 --- a/drivers/video/omap2/omapfb/omapfb.h +++ b/drivers/video/omap2/omapfb/omapfb.h | |||
@@ -144,16 +144,16 @@ int omapfb_set_update_mode(struct fb_info *fbi, enum omapfb_update_mode mode); | |||
144 | static inline struct omap_dss_device *fb2display(struct fb_info *fbi) | 144 | static inline struct omap_dss_device *fb2display(struct fb_info *fbi) |
145 | { | 145 | { |
146 | struct omapfb_info *ofbi = FB2OFB(fbi); | 146 | struct omapfb_info *ofbi = FB2OFB(fbi); |
147 | int i; | 147 | struct omap_overlay *ovl; |
148 | 148 | ||
149 | /* XXX: returns the display connected to first attached overlay */ | 149 | /* XXX: returns the display connected to first attached overlay */ |
150 | for (i = 0; i < ofbi->num_overlays; i++) { | ||
151 | struct omap_overlay *ovl = ofbi->overlays[i]; | ||
152 | 150 | ||
153 | return ovl->get_device(ovl); | 151 | if (ofbi->num_overlays == 0) |
154 | } | 152 | return NULL; |
155 | 153 | ||
156 | return NULL; | 154 | ovl = ofbi->overlays[0]; |
155 | |||
156 | return ovl->get_device(ovl); | ||
157 | } | 157 | } |
158 | 158 | ||
159 | static inline struct omapfb_display_data *get_display_data( | 159 | static inline struct omapfb_display_data *get_display_data( |