aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorAmol Lad <amol@verismonetworks.com>2006-12-08 05:40:06 -0500
committerLinus Torvalds <torvalds@woody.osdl.org>2006-12-08 11:29:04 -0500
commit295a1b476749e8b6fa6c3c0978426360ac7dde4b (patch)
treea70846427824ebddedb545298f8e7c13824e52f3 /drivers/video
parent027b53dd92e3d1a23c56d85e006a9bb5e63314f9 (diff)
[PATCH] ioremap balanced with iounmap for drivers/video/pvr2fb
ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/pvr2fb.c18
1 files changed, 18 insertions, 0 deletions
diff --git a/drivers/video/pvr2fb.c b/drivers/video/pvr2fb.c
index c7bc80921f16..a93618bc9d27 100644
--- a/drivers/video/pvr2fb.c
+++ b/drivers/video/pvr2fb.c
@@ -905,6 +905,15 @@ static int __init pvr2fb_dc_init(void)
905 905
906static void pvr2fb_dc_exit(void) 906static void pvr2fb_dc_exit(void)
907{ 907{
908 if (fb_info->screen_base) {
909 iounmap(fb_info->screen_base);
910 fb_info->screen_base = NULL;
911 }
912 if (currentpar->mmio_base) {
913 iounmap((void *)currentpar->mmio_base);
914 currentpar->mmio_base = 0;
915 }
916
908 free_irq(HW_EVENT_VSYNC, 0); 917 free_irq(HW_EVENT_VSYNC, 0);
909#ifdef CONFIG_SH_DMA 918#ifdef CONFIG_SH_DMA
910 free_dma(pvr2dma); 919 free_dma(pvr2dma);
@@ -946,6 +955,15 @@ static int __devinit pvr2fb_pci_probe(struct pci_dev *pdev,
946 955
947static void __devexit pvr2fb_pci_remove(struct pci_dev *pdev) 956static void __devexit pvr2fb_pci_remove(struct pci_dev *pdev)
948{ 957{
958 if (fb_info->screen_base) {
959 iounmap(fb_info->screen_base);
960 fb_info->screen_base = NULL;
961 }
962 if (currentpar->mmio_base) {
963 iounmap((void *)currentpar->mmio_base);
964 currentpar->mmio_base = 0;
965 }
966
949 pci_release_regions(pdev); 967 pci_release_regions(pdev);
950} 968}
951 969