diff options
author | Mikulas Patocka <mpatocka@redhat.com> | 2008-10-29 17:01:17 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-30 14:38:47 -0400 |
commit | 120a37470c2831fea49fdebaceb5a7039f700ce6 (patch) | |
tree | 66ecbbda7026f185bae8ab6a6cf3a692c721a2e3 /drivers/video | |
parent | 51b7616e36fbad93d7ba9e41f11fb57143d11252 (diff) |
framebuffer compat_ioctl deadlock
Fix deadlock in fb_compat_ioctl. fb_compat_ioctl acquires a mutex and
calls fb_ioctl that tries to acquire that mutex too. A regression added
during BKL removal.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video')
-rw-r--r-- | drivers/video/fbmem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c index cd5f20da738a..6048b55f2878 100644 --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c | |||
@@ -1262,8 +1262,8 @@ fb_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
1262 | case FBIOPUT_CON2FBMAP: | 1262 | case FBIOPUT_CON2FBMAP: |
1263 | arg = (unsigned long) compat_ptr(arg); | 1263 | arg = (unsigned long) compat_ptr(arg); |
1264 | case FBIOBLANK: | 1264 | case FBIOBLANK: |
1265 | ret = fb_ioctl(file, cmd, arg); | 1265 | mutex_unlock(&info->lock); |
1266 | break; | 1266 | return fb_ioctl(file, cmd, arg); |
1267 | 1267 | ||
1268 | case FBIOGET_FSCREENINFO: | 1268 | case FBIOGET_FSCREENINFO: |
1269 | ret = fb_get_fscreeninfo(inode, file, cmd, arg); | 1269 | ret = fb_get_fscreeninfo(inode, file, cmd, arg); |