diff options
author | Arnd Bergmann <arnd@arndb.de> | 2014-09-08 11:17:13 -0400 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2014-09-09 06:56:05 -0400 |
commit | 9c8ee3c7341393811d5be5eb61b815e76f92c799 (patch) | |
tree | 1ee83910bb621cb057207e5f240601e0e132bcb7 /drivers/video | |
parent | 58678a77029bc1f78f80f6f93da3d302d587f951 (diff) |
video: mx3fb: always enable BACKLIGHT_LCD_SUPPORT
Commit 7edaa761ee81b ("video: mx3fb: Add backlight control support")
changed the mx3fb driver so it always selects the BACKLIGHT_CLASS_DEVICE
symbol, but that is hidden behind BACKLIGHT_LCD_SUPPORT in Kconfig, so
we get a Kconfig warning for multi_v5_defconfig, which doesn't have that:
Warning: (DRM_RADEON && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 &&
DRM_SHMOBILE && DRM_TILCDC && FB_BACKLIGHT && FB_MX3 && USB_APPLEDISPLAY
&& FB_OLPC_DCON && ASUS_LAPTOP && SONY_LAPTOP && THINKPAD_ACPI &&
EEEPC_LAPTOP && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE
which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT)
This makes sure we always enable both symbols together for mx3fb, like
we do for the other drivers that can't be built without backlight
support. Note that a better solution would be to ensure the driver can
work with or without backlight support.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video')
-rw-r--r-- | drivers/video/fbdev/Kconfig | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index e911b9c96e19..7b01cd75973c 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig | |||
@@ -2352,10 +2352,11 @@ config FB_MSM | |||
2352 | config FB_MX3 | 2352 | config FB_MX3 |
2353 | tristate "MX3 Framebuffer support" | 2353 | tristate "MX3 Framebuffer support" |
2354 | depends on FB && MX3_IPU | 2354 | depends on FB && MX3_IPU |
2355 | select BACKLIGHT_CLASS_DEVICE | ||
2356 | select BACKLIGHT_LCD_SUPPORT | ||
2355 | select FB_CFB_FILLRECT | 2357 | select FB_CFB_FILLRECT |
2356 | select FB_CFB_COPYAREA | 2358 | select FB_CFB_COPYAREA |
2357 | select FB_CFB_IMAGEBLIT | 2359 | select FB_CFB_IMAGEBLIT |
2358 | select BACKLIGHT_CLASS_DEVICE | ||
2359 | default y | 2360 | default y |
2360 | help | 2361 | help |
2361 | This is a framebuffer device for the i.MX31 LCD Controller. So | 2362 | This is a framebuffer device for the i.MX31 LCD Controller. So |