diff options
author | Jan Beulich <JBeulich@suse.com> | 2011-12-22 04:08:13 -0500 |
---|---|---|
committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2012-01-04 17:01:17 -0500 |
commit | 73db144b58a32fc39733db6a7e1fe582072ad26a (patch) | |
tree | f03edee848be5aa085c30d493c02a5ee1b8fc3da /drivers/video/xen-fbfront.c | |
parent | 2e16341438c9eca15a2e0bb2ad8555bbdf24b86d (diff) |
Xen: consolidate and simplify struct xenbus_driver instantiation
The 'name', 'owner', and 'mod_name' members are redundant with the
identically named fields in the 'driver' sub-structure. Rather than
switching each instance to specify these fields explicitly, introduce
a macro to simplify this.
Eliminate further redundancy by allowing the drvname argument to
DEFINE_XENBUS_DRIVER() to be blank (in which case the first entry from
the ID table will be used for .driver.name).
Also eliminate the questionable xenbus_register_{back,front}end()
wrappers - their sole remaining purpose was the checking of the
'owner' field, proper setting of which shouldn't be an issue anymore
when the macro gets used.
v2: Restore DRV_NAME for the driver name in xen-pciback.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'drivers/video/xen-fbfront.c')
-rw-r--r-- | drivers/video/xen-fbfront.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c index beac52fc1c0e..cb4529c40d74 100644 --- a/drivers/video/xen-fbfront.c +++ b/drivers/video/xen-fbfront.c | |||
@@ -671,20 +671,17 @@ InitWait: | |||
671 | } | 671 | } |
672 | } | 672 | } |
673 | 673 | ||
674 | static struct xenbus_device_id xenfb_ids[] = { | 674 | static const struct xenbus_device_id xenfb_ids[] = { |
675 | { "vfb" }, | 675 | { "vfb" }, |
676 | { "" } | 676 | { "" } |
677 | }; | 677 | }; |
678 | 678 | ||
679 | static struct xenbus_driver xenfb_driver = { | 679 | static DEFINE_XENBUS_DRIVER(xenfb, , |
680 | .name = "vfb", | ||
681 | .owner = THIS_MODULE, | ||
682 | .ids = xenfb_ids, | ||
683 | .probe = xenfb_probe, | 680 | .probe = xenfb_probe, |
684 | .remove = xenfb_remove, | 681 | .remove = xenfb_remove, |
685 | .resume = xenfb_resume, | 682 | .resume = xenfb_resume, |
686 | .otherend_changed = xenfb_backend_changed, | 683 | .otherend_changed = xenfb_backend_changed, |
687 | }; | 684 | ); |
688 | 685 | ||
689 | static int __init xenfb_init(void) | 686 | static int __init xenfb_init(void) |
690 | { | 687 | { |