diff options
author | Jingoo Han <jg1.han@samsung.com> | 2011-04-01 03:17:27 -0400 |
---|---|---|
committer | Paul Mundt <lethal@linux-sh.org> | 2011-04-06 12:44:57 -0400 |
commit | b73a21fc66fee35b41db755abebfacba48b2fc76 (patch) | |
tree | 2e3171811db5ff0c58093f07fe274919749bf857 /drivers/video/s3c-fb.c | |
parent | e9c5db0b8dce1bcdc99ad26e718230810d6b5cff (diff) |
video: s3c-fb: fix checkpatch errors and warning
This patch fixes the checkpatch errors listed below:
ERROR: space required before the open parenthesis '('
ERROR: need consistent spacing around '+' (ctx:WxV)
ERROR: space prohibited before that close parenthesis ')'
Also, following warning is fixed by adding 'platid' variable
which can reduce number of lines exceeding 80 characters.
WARNING: line over 80 characters
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'drivers/video/s3c-fb.c')
-rw-r--r-- | drivers/video/s3c-fb.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c index 6817d187d46e..3b6cdcac8f1a 100644 --- a/drivers/video/s3c-fb.c +++ b/drivers/video/s3c-fb.c | |||
@@ -48,7 +48,7 @@ | |||
48 | #undef writel | 48 | #undef writel |
49 | #define writel(v, r) do { \ | 49 | #define writel(v, r) do { \ |
50 | printk(KERN_DEBUG "%s: %08x => %p\n", __func__, (unsigned int)v, r); \ | 50 | printk(KERN_DEBUG "%s: %08x => %p\n", __func__, (unsigned int)v, r); \ |
51 | __raw_writel(v, r); } while(0) | 51 | __raw_writel(v, r); } while (0) |
52 | #endif /* FB_S3C_DEBUG_REGWRITE */ | 52 | #endif /* FB_S3C_DEBUG_REGWRITE */ |
53 | 53 | ||
54 | /* irq_flags bits */ | 54 | /* irq_flags bits */ |
@@ -518,7 +518,7 @@ static int s3c_fb_set_par(struct fb_info *info) | |||
518 | 518 | ||
519 | data = VIDTCON2_LINEVAL(var->yres - 1) | | 519 | data = VIDTCON2_LINEVAL(var->yres - 1) | |
520 | VIDTCON2_HOZVAL(var->xres - 1); | 520 | VIDTCON2_HOZVAL(var->xres - 1); |
521 | writel(data, regs +sfb->variant.vidtcon + 8 ); | 521 | writel(data, regs + sfb->variant.vidtcon + 8); |
522 | } | 522 | } |
523 | 523 | ||
524 | /* write the buffer address */ | 524 | /* write the buffer address */ |
@@ -1304,6 +1304,7 @@ static void s3c_fb_clear_win(struct s3c_fb *sfb, int win) | |||
1304 | 1304 | ||
1305 | static int __devinit s3c_fb_probe(struct platform_device *pdev) | 1305 | static int __devinit s3c_fb_probe(struct platform_device *pdev) |
1306 | { | 1306 | { |
1307 | const struct platform_device_id *platid; | ||
1307 | struct s3c_fb_driverdata *fbdrv; | 1308 | struct s3c_fb_driverdata *fbdrv; |
1308 | struct device *dev = &pdev->dev; | 1309 | struct device *dev = &pdev->dev; |
1309 | struct s3c_fb_platdata *pd; | 1310 | struct s3c_fb_platdata *pd; |
@@ -1312,7 +1313,8 @@ static int __devinit s3c_fb_probe(struct platform_device *pdev) | |||
1312 | int win; | 1313 | int win; |
1313 | int ret = 0; | 1314 | int ret = 0; |
1314 | 1315 | ||
1315 | fbdrv = (struct s3c_fb_driverdata *)platform_get_device_id(pdev)->driver_data; | 1316 | platid = platform_get_device_id(pdev); |
1317 | fbdrv = (struct s3c_fb_driverdata *)platid->driver_data; | ||
1316 | 1318 | ||
1317 | if (fbdrv->variant.nr_windows > S3C_FB_MAX_WIN) { | 1319 | if (fbdrv->variant.nr_windows > S3C_FB_MAX_WIN) { |
1318 | dev_err(dev, "too many windows, cannot attach\n"); | 1320 | dev_err(dev, "too many windows, cannot attach\n"); |