diff options
author | Antonino A. Daplas <adaplas@gmail.com> | 2005-11-07 04:00:35 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-11-07 10:53:50 -0500 |
commit | c465e05a03209651078b95686158648fd7ed84c5 (patch) | |
tree | e1119586a567a9a6a5ad9bda43d3438772ecf5a4 /drivers/video/q40fb.c | |
parent | e764a20196f4e1b497a42fdc6e9d254e7ec290f2 (diff) |
[PATCH] fbcon/fbdev: Move softcursor out of fbdev to fbcon
According to Jon Smirl, filling in the field fb_cursor with soft_cursor for
drivers that do not support hardware cursors is redundant. The soft_cursor
function is usable by all drivers because it is just a wrapper around
fb_imageblit. And because soft_cursor is an fbcon-specific hook, the file is
moved to the console directory.
Thus, drivers that do not support hardware cursors can leave the fb_cursor
field blank. For drivers that do, they can fill up this field with their own
version.
The end result is a smaller code size. And if the framebuffer console is not
loaded, module/kernel size is also reduced because the soft_cursor module will
also not be loaded.
Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/video/q40fb.c')
-rw-r--r-- | drivers/video/q40fb.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/video/q40fb.c b/drivers/video/q40fb.c index 8416b2e2b501..bfc41f2c902a 100644 --- a/drivers/video/q40fb.c +++ b/drivers/video/q40fb.c | |||
@@ -84,7 +84,6 @@ static struct fb_ops q40fb_ops = { | |||
84 | .fb_fillrect = cfb_fillrect, | 84 | .fb_fillrect = cfb_fillrect, |
85 | .fb_copyarea = cfb_copyarea, | 85 | .fb_copyarea = cfb_copyarea, |
86 | .fb_imageblit = cfb_imageblit, | 86 | .fb_imageblit = cfb_imageblit, |
87 | .fb_cursor = soft_cursor, | ||
88 | }; | 87 | }; |
89 | 88 | ||
90 | static int __init q40fb_probe(struct device *device) | 89 | static int __init q40fb_probe(struct device *device) |