diff options
author | Kees Cook <keescook@chromium.org> | 2013-07-03 18:04:56 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-07-03 19:07:41 -0400 |
commit | 02aa2a37636c8fa4fb9322d91be46ff8225b7de0 (patch) | |
tree | 97c93d17cfcad186d229ef76f96de709eddfea8c /drivers/video/output.c | |
parent | 096a8aac6bf4a5a0b2ef812ad76d056bbf3fb2af (diff) |
drivers: avoid format string in dev_set_name
Calling dev_set_name with a single paramter causes it to be handled as a
format string. Many callers are passing potentially dynamic string
content, so use "%s" in those cases to avoid any potential accidents,
including wrappers like device_create*() and bdi_register().
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/output.c')
-rw-r--r-- | drivers/video/output.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/output.c b/drivers/video/output.c index 0d6f2cda9369..6285b9718451 100644 --- a/drivers/video/output.c +++ b/drivers/video/output.c | |||
@@ -97,7 +97,7 @@ struct output_device *video_output_register(const char *name, | |||
97 | new_dev->props = op; | 97 | new_dev->props = op; |
98 | new_dev->dev.class = &video_output_class; | 98 | new_dev->dev.class = &video_output_class; |
99 | new_dev->dev.parent = dev; | 99 | new_dev->dev.parent = dev; |
100 | dev_set_name(&new_dev->dev, name); | 100 | dev_set_name(&new_dev->dev, "%s", name); |
101 | dev_set_drvdata(&new_dev->dev, devdata); | 101 | dev_set_drvdata(&new_dev->dev, devdata); |
102 | ret_code = device_register(&new_dev->dev); | 102 | ret_code = device_register(&new_dev->dev); |
103 | if (ret_code) { | 103 | if (ret_code) { |