diff options
author | Adrian Bunk <bunk@stusta.de> | 2006-01-09 23:54:04 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-01-10 11:01:56 -0500 |
commit | a0aa7d0639277f375989071fb52a7ce78beeef97 (patch) | |
tree | 5189b4cae286c754f5193f6ac465e3fff31732b6 /drivers/video/kyro | |
parent | 1d64ec153e914cbd60cfaaa47ececed55a9d14d7 (diff) |
[PATCH] drivers/video/: possible cleanups
This patch contains the possible cleanups including the following:
- every file should #include the headers containing the prototypes for
it's global functions
- make needlessly global functions static
- kyro/STG4000Interface.h: #include video/kyro.h and linux/pci.h
instead of a manual "struct pci_dev"
- i810_main.{c,h}: prototypes for static functions belong to the
C file
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: "Antonino A. Daplas" <adaplas@hotpop.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/video/kyro')
-rw-r--r-- | drivers/video/kyro/STG4000InitDevice.c | 1 | ||||
-rw-r--r-- | drivers/video/kyro/STG4000Interface.h | 3 | ||||
-rw-r--r-- | drivers/video/kyro/STG4000OverlayDevice.c | 1 |
3 files changed, 4 insertions, 1 deletions
diff --git a/drivers/video/kyro/STG4000InitDevice.c b/drivers/video/kyro/STG4000InitDevice.c index 7e33cd307d47..ab5285a7f1d6 100644 --- a/drivers/video/kyro/STG4000InitDevice.c +++ b/drivers/video/kyro/STG4000InitDevice.c | |||
@@ -15,6 +15,7 @@ | |||
15 | #include <linux/pci.h> | 15 | #include <linux/pci.h> |
16 | 16 | ||
17 | #include "STG4000Reg.h" | 17 | #include "STG4000Reg.h" |
18 | #include "STG4000Interface.h" | ||
18 | 19 | ||
19 | /* SDRAM fixed settings */ | 20 | /* SDRAM fixed settings */ |
20 | #define SDRAM_CFG_0 0x49A1 | 21 | #define SDRAM_CFG_0 0x49A1 |
diff --git a/drivers/video/kyro/STG4000Interface.h b/drivers/video/kyro/STG4000Interface.h index e75b3b4a4aa1..b7c83d5dfb13 100644 --- a/drivers/video/kyro/STG4000Interface.h +++ b/drivers/video/kyro/STG4000Interface.h | |||
@@ -11,7 +11,8 @@ | |||
11 | #ifndef _STG4000INTERFACE_H | 11 | #ifndef _STG4000INTERFACE_H |
12 | #define _STG4000INTERFACE_H | 12 | #define _STG4000INTERFACE_H |
13 | 13 | ||
14 | struct pci_dev; | 14 | #include <linux/pci.h> |
15 | #include <video/kyro.h> | ||
15 | 16 | ||
16 | /* | 17 | /* |
17 | * Ramdac Setup | 18 | * Ramdac Setup |
diff --git a/drivers/video/kyro/STG4000OverlayDevice.c b/drivers/video/kyro/STG4000OverlayDevice.c index 2ae9bafacdd0..a8c9713413e6 100644 --- a/drivers/video/kyro/STG4000OverlayDevice.c +++ b/drivers/video/kyro/STG4000OverlayDevice.c | |||
@@ -14,6 +14,7 @@ | |||
14 | #include <linux/types.h> | 14 | #include <linux/types.h> |
15 | 15 | ||
16 | #include "STG4000Reg.h" | 16 | #include "STG4000Reg.h" |
17 | #include "STG4000Interface.h" | ||
17 | 18 | ||
18 | /* HW Defines */ | 19 | /* HW Defines */ |
19 | 20 | ||