diff options
author | Antonino A. Daplas <adaplas@gmail.com> | 2005-11-07 04:00:35 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-11-07 10:53:50 -0500 |
commit | c465e05a03209651078b95686158648fd7ed84c5 (patch) | |
tree | e1119586a567a9a6a5ad9bda43d3438772ecf5a4 /drivers/video/imxfb.c | |
parent | e764a20196f4e1b497a42fdc6e9d254e7ec290f2 (diff) |
[PATCH] fbcon/fbdev: Move softcursor out of fbdev to fbcon
According to Jon Smirl, filling in the field fb_cursor with soft_cursor for
drivers that do not support hardware cursors is redundant. The soft_cursor
function is usable by all drivers because it is just a wrapper around
fb_imageblit. And because soft_cursor is an fbcon-specific hook, the file is
moved to the console directory.
Thus, drivers that do not support hardware cursors can leave the fb_cursor
field blank. For drivers that do, they can fill up this field with their own
version.
The end result is a smaller code size. And if the framebuffer console is not
loaded, module/kernel size is also reduced because the soft_cursor module will
also not be loaded.
Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/video/imxfb.c')
-rw-r--r-- | drivers/video/imxfb.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c index 64d9bcc38da3..e20b9f3a255f 100644 --- a/drivers/video/imxfb.c +++ b/drivers/video/imxfb.c | |||
@@ -298,7 +298,6 @@ static struct fb_ops imxfb_ops = { | |||
298 | .fb_copyarea = cfb_copyarea, | 298 | .fb_copyarea = cfb_copyarea, |
299 | .fb_imageblit = cfb_imageblit, | 299 | .fb_imageblit = cfb_imageblit, |
300 | .fb_blank = imxfb_blank, | 300 | .fb_blank = imxfb_blank, |
301 | .fb_cursor = soft_cursor, /* FIXME: i.MX can do hardware cursor */ | ||
302 | }; | 301 | }; |
303 | 302 | ||
304 | /* | 303 | /* |