diff options
author | Ben Dooks <ben-linux@fluff.org> | 2008-08-05 16:01:22 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-08-05 17:33:48 -0400 |
commit | 14563a4ec450f35c70fbe5f6ac5199e9d5a0edc5 (patch) | |
tree | 07cc513465e074eef9d0f369dc639af845b1db8d /drivers/video/backlight | |
parent | 26cb8bb21b11245a53f79d9fa766537752f77d88 (diff) |
backlight: add more information output to pwm_backlight
Make the error paths in the pwm_backlight driver more informative in the
probe path, especially for the times that it finds an error.
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Cc: Richard Purdie <rpurdie@rpsys.net>
Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/backlight')
-rw-r--r-- | drivers/video/backlight/pwm_bl.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 6338d0e2fe07..441e5a707d37 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c | |||
@@ -68,8 +68,10 @@ static int pwm_backlight_probe(struct platform_device *pdev) | |||
68 | struct pwm_bl_data *pb; | 68 | struct pwm_bl_data *pb; |
69 | int ret; | 69 | int ret; |
70 | 70 | ||
71 | if (!data) | 71 | if (!data) { |
72 | dev_err(&pdev->dev, "failed to find platform data\n"); | ||
72 | return -EINVAL; | 73 | return -EINVAL; |
74 | } | ||
73 | 75 | ||
74 | if (data->init) { | 76 | if (data->init) { |
75 | ret = data->init(&pdev->dev); | 77 | ret = data->init(&pdev->dev); |
@@ -79,6 +81,7 @@ static int pwm_backlight_probe(struct platform_device *pdev) | |||
79 | 81 | ||
80 | pb = kzalloc(sizeof(*pb), GFP_KERNEL); | 82 | pb = kzalloc(sizeof(*pb), GFP_KERNEL); |
81 | if (!pb) { | 83 | if (!pb) { |
84 | dev_err(&pdev->dev, "no memory for state\n"); | ||
82 | ret = -ENOMEM; | 85 | ret = -ENOMEM; |
83 | goto err_alloc; | 86 | goto err_alloc; |
84 | } | 87 | } |
@@ -91,7 +94,8 @@ static int pwm_backlight_probe(struct platform_device *pdev) | |||
91 | dev_err(&pdev->dev, "unable to request PWM for backlight\n"); | 94 | dev_err(&pdev->dev, "unable to request PWM for backlight\n"); |
92 | ret = PTR_ERR(pb->pwm); | 95 | ret = PTR_ERR(pb->pwm); |
93 | goto err_pwm; | 96 | goto err_pwm; |
94 | } | 97 | } else |
98 | dev_dbg(&pdev->dev, "got pwm for backlight\n"); | ||
95 | 99 | ||
96 | bl = backlight_device_register(pdev->name, &pdev->dev, | 100 | bl = backlight_device_register(pdev->name, &pdev->dev, |
97 | pb, &pwm_backlight_ops); | 101 | pb, &pwm_backlight_ops); |