diff options
author | Akinobu Mita <akinobu.mita@gmail.com> | 2008-11-17 10:19:29 -0500 |
---|---|---|
committer | Richard Purdie <rpurdie@linux.intel.com> | 2009-01-08 07:37:28 -0500 |
commit | 6cd6f35a4b0ff86638df986efaa307de91f88ae8 (patch) | |
tree | 520586777b71aa5534df43b98a32fa1df7580008 /drivers/video/backlight/progear_bl.c | |
parent | 3bcdcc0e6675e6fcd1f27d119464036fb54f53b7 (diff) |
backlight: progear_bl - Use platform_device_register_simple()
Use platform_device_register_simple() and also fix error
handling when platform_device_alloc() fails (progearbl_driver
is left registered).
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
Diffstat (limited to 'drivers/video/backlight/progear_bl.c')
-rw-r--r-- | drivers/video/backlight/progear_bl.c | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/drivers/video/backlight/progear_bl.c b/drivers/video/backlight/progear_bl.c index 15fb4d58b5bc..9edaf24fd82d 100644 --- a/drivers/video/backlight/progear_bl.c +++ b/drivers/video/backlight/progear_bl.c | |||
@@ -119,20 +119,16 @@ static int __init progearbl_init(void) | |||
119 | { | 119 | { |
120 | int ret = platform_driver_register(&progearbl_driver); | 120 | int ret = platform_driver_register(&progearbl_driver); |
121 | 121 | ||
122 | if (!ret) { | 122 | if (ret) |
123 | progearbl_device = platform_device_alloc("progear-bl", -1); | 123 | return ret; |
124 | if (!progearbl_device) | 124 | progearbl_device = platform_device_register_simple("progear-bl", -1, |
125 | return -ENOMEM; | 125 | NULL, 0); |
126 | 126 | if (IS_ERR(progearbl_device)) { | |
127 | ret = platform_device_add(progearbl_device); | 127 | platform_driver_unregister(&progearbl_driver); |
128 | 128 | return PTR_ERR(progearbl_device); | |
129 | if (ret) { | ||
130 | platform_device_put(progearbl_device); | ||
131 | platform_driver_unregister(&progearbl_driver); | ||
132 | } | ||
133 | } | 129 | } |
134 | 130 | ||
135 | return ret; | 131 | return 0; |
136 | } | 132 | } |
137 | 133 | ||
138 | static void __exit progearbl_exit(void) | 134 | static void __exit progearbl_exit(void) |