diff options
author | Akinobu Mita <akinobu.mita@gmail.com> | 2008-11-17 10:21:32 -0500 |
---|---|---|
committer | Richard Purdie <rpurdie@linux.intel.com> | 2009-01-08 07:37:28 -0500 |
commit | b4a11d3da20db62f31b3133a6eca8a35633e0838 (patch) | |
tree | 4c9fcc6f88c1b45589d389a2a4e30cb0ddda2e19 /drivers/video/backlight/cr_bllcd.c | |
parent | 6cd6f35a4b0ff86638df986efaa307de91f88ae8 (diff) |
backlight: crbllcd_bl - Use platform_device_register_simple()
Use platform_device_register_simple() and also fix error
handling when platform_device_alloc() fails (cr_backlight_driver
is left registered).
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
Diffstat (limited to 'drivers/video/backlight/cr_bllcd.c')
-rw-r--r-- | drivers/video/backlight/cr_bllcd.c | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c index 26add8898605..b9fe62b475c6 100644 --- a/drivers/video/backlight/cr_bllcd.c +++ b/drivers/video/backlight/cr_bllcd.c | |||
@@ -259,22 +259,18 @@ static int __init cr_backlight_init(void) | |||
259 | { | 259 | { |
260 | int ret = platform_driver_register(&cr_backlight_driver); | 260 | int ret = platform_driver_register(&cr_backlight_driver); |
261 | 261 | ||
262 | if (!ret) { | 262 | if (ret) |
263 | crp = platform_device_alloc("cr_backlight", -1); | 263 | return ret; |
264 | if (!crp) | ||
265 | return -ENOMEM; | ||
266 | 264 | ||
267 | ret = platform_device_add(crp); | 265 | crp = platform_device_register_simple("cr_backlight", -1, NULL, 0); |
268 | 266 | if (IS_ERR(crp)) { | |
269 | if (ret) { | 267 | platform_driver_unregister(&cr_backlight_driver); |
270 | platform_device_put(crp); | 268 | return PTR_ERR(crp); |
271 | platform_driver_unregister(&cr_backlight_driver); | ||
272 | } | ||
273 | } | 269 | } |
274 | 270 | ||
275 | printk("Carillo Ranch Backlight Driver Initialized.\n"); | 271 | printk("Carillo Ranch Backlight Driver Initialized.\n"); |
276 | 272 | ||
277 | return ret; | 273 | return 0; |
278 | } | 274 | } |
279 | 275 | ||
280 | static void __exit cr_backlight_exit(void) | 276 | static void __exit cr_backlight_exit(void) |