diff options
author | Tony Breeds <tony@bakeyournoodle.com> | 2008-07-24 00:31:16 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-24 13:47:37 -0400 |
commit | fcea8030b3c2e71ad89f080901c63a04f07881c8 (patch) | |
tree | 942140d583a70b49f0dc3a7df52d9e66582907be /drivers/video/aty/radeon_base.c | |
parent | 7951ac91c7d45b61f54f1cdabc24b52b40785de6 (diff) |
drivers/video/aty/radeon_base.c: notify user if sysfs_create_bin_file() failed
Current kernel builds warn about:
drivers/video/aty/radeon_base.c: In function 'radeonfb_pci_register':
drivers/video/aty/radeon_base.c:2334: warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result
drivers/video/aty/radeon_base.c:2336: warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result
Do minimal checking of these functions and issue a warning if either
fails. They don't seem to be critical..
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/aty/radeon_base.c')
-rw-r--r-- | drivers/video/aty/radeon_base.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c index 400e9264e456..3c0a03f69d83 100644 --- a/drivers/video/aty/radeon_base.c +++ b/drivers/video/aty/radeon_base.c | |||
@@ -2161,6 +2161,7 @@ static int __devinit radeonfb_pci_register (struct pci_dev *pdev, | |||
2161 | struct radeonfb_info *rinfo; | 2161 | struct radeonfb_info *rinfo; |
2162 | int ret; | 2162 | int ret; |
2163 | unsigned char c1, c2; | 2163 | unsigned char c1, c2; |
2164 | int err = 0; | ||
2164 | 2165 | ||
2165 | pr_debug("radeonfb_pci_register BEGIN\n"); | 2166 | pr_debug("radeonfb_pci_register BEGIN\n"); |
2166 | 2167 | ||
@@ -2340,9 +2341,14 @@ static int __devinit radeonfb_pci_register (struct pci_dev *pdev, | |||
2340 | 2341 | ||
2341 | /* Register some sysfs stuff (should be done better) */ | 2342 | /* Register some sysfs stuff (should be done better) */ |
2342 | if (rinfo->mon1_EDID) | 2343 | if (rinfo->mon1_EDID) |
2343 | sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr); | 2344 | err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj, |
2345 | &edid1_attr); | ||
2344 | if (rinfo->mon2_EDID) | 2346 | if (rinfo->mon2_EDID) |
2345 | sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid2_attr); | 2347 | err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj, |
2348 | &edid2_attr); | ||
2349 | if (err) | ||
2350 | pr_warning("%s() Creating sysfs files failed, continuing\n", | ||
2351 | __func__); | ||
2346 | 2352 | ||
2347 | /* save current mode regs before we switch into the new one | 2353 | /* save current mode regs before we switch into the new one |
2348 | * so we can restore this upon __exit | 2354 | * so we can restore this upon __exit |