diff options
author | Richard Purdie <rpurdie@rpsys.net> | 2007-02-08 17:25:09 -0500 |
---|---|---|
committer | Richard Purdie <rpurdie@rpsys.net> | 2007-02-20 03:38:45 -0500 |
commit | 28ee086d5b36aab2931f6740e409bb0fb6c65e5f (patch) | |
tree | 0a308c80affcc39c2c869f29f1109e5ee9d6140f /drivers/video/aty/radeon_backlight.c | |
parent | a8db3c1948eb30cd6988b5b96b654f591e6280b1 (diff) |
backlight: Fix external uses of backlight internal semaphore
backlight_device->sem has a very specific use as documented in the
header file. The external users of this are using it for a different
reason, to serialise access to the update_status() method.
backlight users were supposed to implement their own internal
serialisation of update_status() if needed but everyone is doing
things differently and incorrectly. Therefore add a global mutex to
take care of serialisation for everyone, once and for all.
Locking for get_brightness remains optional since most users don't
need it.
Also update the lcd class in a similar way.
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
Diffstat (limited to 'drivers/video/aty/radeon_backlight.c')
-rw-r--r-- | drivers/video/aty/radeon_backlight.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/video/aty/radeon_backlight.c b/drivers/video/aty/radeon_backlight.c index 8b66df6f199a..9cfcecac8b5e 100644 --- a/drivers/video/aty/radeon_backlight.c +++ b/drivers/video/aty/radeon_backlight.c | |||
@@ -194,11 +194,9 @@ void radeonfb_bl_init(struct radeonfb_info *rinfo) | |||
194 | 217 * FB_BACKLIGHT_MAX / MAX_RADEON_LEVEL); | 194 | 217 * FB_BACKLIGHT_MAX / MAX_RADEON_LEVEL); |
195 | mutex_unlock(&rinfo->info->bl_mutex); | 195 | mutex_unlock(&rinfo->info->bl_mutex); |
196 | 196 | ||
197 | down(&bd->sem); | ||
198 | bd->props->brightness = radeon_bl_data.max_brightness; | 197 | bd->props->brightness = radeon_bl_data.max_brightness; |
199 | bd->props->power = FB_BLANK_UNBLANK; | 198 | bd->props->power = FB_BLANK_UNBLANK; |
200 | bd->props->update_status(bd); | 199 | backlight_update_status(bd); |
201 | up(&bd->sem); | ||
202 | 200 | ||
203 | #ifdef CONFIG_PMAC_BACKLIGHT | 201 | #ifdef CONFIG_PMAC_BACKLIGHT |
204 | mutex_lock(&pmac_backlight_mutex); | 202 | mutex_lock(&pmac_backlight_mutex); |