diff options
author | Antonino A. Daplas <adaplas@gmail.com> | 2005-11-07 04:00:35 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-11-07 10:53:50 -0500 |
commit | c465e05a03209651078b95686158648fd7ed84c5 (patch) | |
tree | e1119586a567a9a6a5ad9bda43d3438772ecf5a4 /drivers/video/amifb.c | |
parent | e764a20196f4e1b497a42fdc6e9d254e7ec290f2 (diff) |
[PATCH] fbcon/fbdev: Move softcursor out of fbdev to fbcon
According to Jon Smirl, filling in the field fb_cursor with soft_cursor for
drivers that do not support hardware cursors is redundant. The soft_cursor
function is usable by all drivers because it is just a wrapper around
fb_imageblit. And because soft_cursor is an fbcon-specific hook, the file is
moved to the console directory.
Thus, drivers that do not support hardware cursors can leave the fb_cursor
field blank. For drivers that do, they can fill up this field with their own
version.
The end result is a smaller code size. And if the framebuffer console is not
loaded, module/kernel size is also reduced because the soft_cursor module will
also not be loaded.
Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/video/amifb.c')
-rw-r--r-- | drivers/video/amifb.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/video/amifb.c b/drivers/video/amifb.c index cf8bb67462dc..d549e215f3c5 100644 --- a/drivers/video/amifb.c +++ b/drivers/video/amifb.c | |||
@@ -1185,7 +1185,6 @@ static struct fb_ops amifb_ops = { | |||
1185 | .fb_fillrect = amifb_fillrect, | 1185 | .fb_fillrect = amifb_fillrect, |
1186 | .fb_copyarea = amifb_copyarea, | 1186 | .fb_copyarea = amifb_copyarea, |
1187 | .fb_imageblit = amifb_imageblit, | 1187 | .fb_imageblit = amifb_imageblit, |
1188 | .fb_cursor = soft_cursor, | ||
1189 | .fb_ioctl = amifb_ioctl, | 1188 | .fb_ioctl = amifb_ioctl, |
1190 | }; | 1189 | }; |
1191 | 1190 | ||