diff options
author | Alex Williamson <alex.williamson@redhat.com> | 2013-06-10 18:40:56 -0400 |
---|---|---|
committer | Alex Williamson <alex.williamson@redhat.com> | 2013-07-24 18:36:40 -0400 |
commit | c64019302bbb0b445484d870e674ab34a19a18a1 (patch) | |
tree | b8b33240f42bd0788d67c3632efbb309e071f1f7 /drivers/vfio | |
parent | de9c7602ca25f52bbfeb52e7d85765fe70b92dce (diff) |
vfio: Ignore sprurious notifies
Remove debugging WARN_ON if we get a spurious notify for a group that
no longer exists. No reports of anyone hitting this, but it would
likely be a race and not a bug if they did.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/vfio')
-rw-r--r-- | drivers/vfio/vfio.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index 6d18c3cafdd4..842f4507883e 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c | |||
@@ -510,13 +510,11 @@ static int vfio_iommu_group_notifier(struct notifier_block *nb, | |||
510 | struct device *dev = data; | 510 | struct device *dev = data; |
511 | 511 | ||
512 | /* | 512 | /* |
513 | * Need to go through a group_lock lookup to get a reference or | 513 | * Need to go through a group_lock lookup to get a reference or we |
514 | * we risk racing a group being removed. Leave a WARN_ON for | 514 | * risk racing a group being removed. Ignore spurious notifies. |
515 | * debuging, but if the group no longer exists, a spurious notify | ||
516 | * is harmless. | ||
517 | */ | 515 | */ |
518 | group = vfio_group_try_get(group); | 516 | group = vfio_group_try_get(group); |
519 | if (WARN_ON(!group)) | 517 | if (!group) |
520 | return NOTIFY_OK; | 518 | return NOTIFY_OK; |
521 | 519 | ||
522 | switch (action) { | 520 | switch (action) { |