Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

Pull SCSI target updates from Nicholas Bellinger:
 "Lots of activity in target land the last months.

  The highlights include:

   - Convert fabric drivers tree-wide to target_register_template() (hch
     + bart)

   - iser-target hardening fixes + v1.0 improvements (sagi)

   - Convert iscsi_thread_set usage to kthread.h + kill
     iscsi_target_tq.c (sagi + nab)

   - Add support for T10-PI WRITE_STRIP + READ_INSERT operation (mkp +
     sagi + nab)

   - DIF fixes for CONFIG_DEBUG_SG=y + UNMAP file emulation (akinobu +
     sagi + mkp)

   - Extended TCMU ABI v2 for future BIDI + DIF support (andy + ilias)

   - Fix COMPARE_AND_WRITE handling for NO_ALLLOC drivers (hch + nab)

  Thanks to everyone who contributed this round with new features,
  bug-reports, fixes, cleanups and improvements.

  Looking forward, it's currently shaping up to be a busy v4.2 as well"

* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending: (69 commits)
  target: Put TCMU under a new config option
  target: Version 2 of TCMU ABI
  target: fix tcm_mod_builder.py
  target/file: Fix UNMAP with DIF protection support
  target/file: Fix SG table for prot_buf initialization
  target/file: Fix BUG() when CONFIG_DEBUG_SG=y and DIF protection enabled
  target: Make core_tmr_abort_task() skip TMFs
  target/sbc: Update sbc_dif_generate pr_debug output
  target/sbc: Make internal DIF emulation honor ->prot_checks
  target/sbc: Return INVALID_CDB_FIELD if DIF + sess_prot_type disabled
  target: Ensure sess_prot_type is saved across session restart
  target/rd: Don't pass incomplete scatterlist entries to sbc_dif_verify_*
  target: Remove the unused flag SCF_ACK_KREF
  target: Fix two sparse warnings
  target: Fix COMPARE_AND_WRITE with SG_TO_MEM_NOALLOC handling
  target: simplify the target template registration API
  target: simplify target_xcopy_init_pt_lun
  target: remove the unused SCF_CMD_XCOPY_PASSTHROUGH flag
  target/rd: reduce code duplication in rd_execute_rw()
  tcm_loop: fixup tpgt string to integer conversion
  ...

1 files changed, 9 insertions, 48 deletions

diff --git a/drivers/usb/gadget/legacy/tcm_usb_gadget.c b/drivers/usb/gadget/legacy/tcm_usb_gadget.c
index 6e0a019aad54..8b80addc4ce6 100644
--- a/drivers/usb/gadget/legacy/tcm_usb_gadget.c
+++ b/drivers/usb/gadget/legacy/tcm_usb_gadget.c
@@ -29,7 +29,7 @@
 
 USB_GADGET_COMPOSITE_OPTIONS();
 
-static struct target_fabric_configfs *usbg_fabric_configfs;
+static const struct target_core_fabric_ops usbg_ops;
 
 static inline struct f_uas *to_f_uas(struct usb_function *f)
 {
@@ -1572,8 +1572,7 @@ static struct se_portal_group *usbg_make_tpg(
         tpg->tport = tport;
         tpg->tport_tpgt = tpgt;
 
-        ret = core_tpg_register(&usbg_fabric_configfs->tf_ops, wwn,
-                                &tpg->se_tpg, tpg,
+        ret = core_tpg_register(&usbg_ops, wwn, &tpg->se_tpg, tpg,
                                 TRANSPORT_TPG_TYPE_NORMAL);
         if (ret < 0) {
                 destroy_workqueue(tpg->workqueue);
@@ -1864,7 +1863,9 @@ static int usbg_check_stop_free(struct se_cmd *se_cmd)
         return 1;
 }
 
-static struct target_core_fabric_ops usbg_ops = {
+static const struct target_core_fabric_ops usbg_ops = {
+        .module                         = THIS_MODULE,
+        .name                           = "usb_gadget",
         .get_fabric_name                = usbg_get_fabric_name,
         .get_fabric_proto_ident         = usbg_get_fabric_proto_ident,
         .tpg_get_wwn                    = usbg_get_fabric_wwn,
@@ -1906,46 +1907,9 @@ static struct target_core_fabric_ops usbg_ops = {
         .fabric_drop_np                 = NULL,
         .fabric_make_nodeacl            = usbg_make_nodeacl,
         .fabric_drop_nodeacl            = usbg_drop_nodeacl,
-};
-
-static int usbg_register_configfs(void)
-{
-        struct target_fabric_configfs *fabric;
-        int ret;
-
-        fabric = target_fabric_configfs_init(THIS_MODULE, "usb_gadget");
-        if (IS_ERR(fabric)) {
-                printk(KERN_ERR "target_fabric_configfs_init() failed\n");
-                return PTR_ERR(fabric);
-        }
-
-        fabric->tf_ops = usbg_ops;
-        fabric->tf_cit_tmpl.tfc_wwn_cit.ct_attrs = usbg_wwn_attrs;
-        fabric->tf_cit_tmpl.tfc_tpg_base_cit.ct_attrs = usbg_base_attrs;
-        fabric->tf_cit_tmpl.tfc_tpg_attrib_cit.ct_attrs = NULL;
-        fabric->tf_cit_tmpl.tfc_tpg_param_cit.ct_attrs = NULL;
-        fabric->tf_cit_tmpl.tfc_tpg_np_base_cit.ct_attrs = NULL;
-        fabric->tf_cit_tmpl.tfc_tpg_nacl_base_cit.ct_attrs = NULL;
-        fabric->tf_cit_tmpl.tfc_tpg_nacl_attrib_cit.ct_attrs = NULL;
-        fabric->tf_cit_tmpl.tfc_tpg_nacl_auth_cit.ct_attrs = NULL;
-        fabric->tf_cit_tmpl.tfc_tpg_nacl_param_cit.ct_attrs = NULL;
-        ret = target_fabric_configfs_register(fabric);
-        if (ret < 0) {
-                printk(KERN_ERR "target_fabric_configfs_register() failed"
-                                " for usb-gadget\n");
-                return ret;
-        }
-        usbg_fabric_configfs = fabric;
-        return 0;
-};
 
-static void usbg_deregister_configfs(void)
-{
-        if (!(usbg_fabric_configfs))
-                return;
-
-        target_fabric_configfs_deregister(usbg_fabric_configfs);
-        usbg_fabric_configfs = NULL;
+        .tfc_wwn_attrs                  = usbg_wwn_attrs,
+        .tfc_tpg_base_attrs             = usbg_base_attrs,
 };
 
 /* Start gadget.c code */
@@ -2454,16 +2418,13 @@ static void usbg_detach(struct usbg_tpg *tpg)
 
 static int __init usb_target_gadget_init(void)
 {
-        int ret;
-
-        ret = usbg_register_configfs();
-        return ret;
+        return target_register_template(&usbg_ops);
 }
 module_init(usb_target_gadget_init);
 
 static void __exit usb_target_gadget_exit(void)
 {
-        usbg_deregister_configfs();
+        target_unregister_template(&usbg_ops);
 }
 module_exit(usb_target_gadget_exit);