diff options
author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2011-06-03 13:50:45 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-06-06 19:28:02 -0400 |
commit | cb42447374eb4348b75ec677bf9c77958c7d10e0 (patch) | |
tree | 7a2fdfcefa833df0cd37cbc9cb1bade72775f7f8 /drivers/usb | |
parent | b38b03b363a53067e8b8f3f43f00b6428bd5319c (diff) |
usb/mv_udc_core: fix compile
|drivers/usb/gadget/mv_udc_core.c:2108: error: label `error' used but not defined
This seems to be broken since the initial commit. I changed this to a
simple return. The other user is the probe code which lets ->probe()
fail on error here.
|drivers/usb/gadget/mv_udc_core.c:2107: warning: passing argument 1 of `dev_err' from incompatible pointer type
|drivers/usb/gadget/mv_udc_core.c:2118: warning: initialization from incompatible pointer type
|drivers/usb/gadget/mv_udc_core.c:2119: warning: initialization from incompatible pointer type
|drivers/usb/gadget/mv_udc_core.c:2130: error: initializer element is not constant
|drivers/usb/gadget/mv_udc_core.c:2130: error: (near initialization for `udc_driver.driver.pm')
Cc: Chao Xie <chao.xie@marvell.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/gadget/mv_udc_core.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c index b62b2640deb0..b1a8146b9d50 100644 --- a/drivers/usb/gadget/mv_udc_core.c +++ b/drivers/usb/gadget/mv_udc_core.c | |||
@@ -2083,7 +2083,7 @@ out: | |||
2083 | } | 2083 | } |
2084 | 2084 | ||
2085 | #ifdef CONFIG_PM | 2085 | #ifdef CONFIG_PM |
2086 | static int mv_udc_suspend(struct platform_device *_dev, pm_message_t state) | 2086 | static int mv_udc_suspend(struct device *_dev) |
2087 | { | 2087 | { |
2088 | struct mv_udc *udc = the_controller; | 2088 | struct mv_udc *udc = the_controller; |
2089 | 2089 | ||
@@ -2092,7 +2092,7 @@ static int mv_udc_suspend(struct platform_device *_dev, pm_message_t state) | |||
2092 | return 0; | 2092 | return 0; |
2093 | } | 2093 | } |
2094 | 2094 | ||
2095 | static int mv_udc_resume(struct platform_device *_dev) | 2095 | static int mv_udc_resume(struct device *_dev) |
2096 | { | 2096 | { |
2097 | struct mv_udc *udc = the_controller; | 2097 | struct mv_udc *udc = the_controller; |
2098 | int retval; | 2098 | int retval; |
@@ -2100,7 +2100,7 @@ static int mv_udc_resume(struct platform_device *_dev) | |||
2100 | retval = mv_udc_phy_init(udc->phy_regs); | 2100 | retval = mv_udc_phy_init(udc->phy_regs); |
2101 | if (retval) { | 2101 | if (retval) { |
2102 | dev_err(_dev, "phy initialization error %d\n", retval); | 2102 | dev_err(_dev, "phy initialization error %d\n", retval); |
2103 | goto error; | 2103 | return retval; |
2104 | } | 2104 | } |
2105 | udc_reset(udc); | 2105 | udc_reset(udc); |
2106 | ep0_reset(udc); | 2106 | ep0_reset(udc); |
@@ -2122,7 +2122,7 @@ static struct platform_driver udc_driver = { | |||
2122 | .owner = THIS_MODULE, | 2122 | .owner = THIS_MODULE, |
2123 | .name = "pxa-u2o", | 2123 | .name = "pxa-u2o", |
2124 | #ifdef CONFIG_PM | 2124 | #ifdef CONFIG_PM |
2125 | .pm = mv_udc_pm_ops, | 2125 | .pm = &mv_udc_pm_ops, |
2126 | #endif | 2126 | #endif |
2127 | }, | 2127 | }, |
2128 | }; | 2128 | }; |