diff options
author | roel kluin <roel.kluin@gmail.com> | 2008-10-21 00:47:23 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-01-07 12:59:49 -0500 |
commit | e64a5219296fff11a0da0322b43012265cd3b327 (patch) | |
tree | 42fa67f74f4d13795fd6c2ee3ceeb1b816b2df9e /drivers/usb | |
parent | 3b438e30c686b1e904c759d3354d335050ab33f9 (diff) |
USB: clean up redundant tests on unsigned
temp, bytes and param->{length,sglen,vary} are unsigned so
these tests do nothing.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/host/ehci-dbg.c | 8 | ||||
-rw-r--r-- | drivers/usb/misc/usbtest.c | 2 |
2 files changed, 2 insertions, 8 deletions
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c index 0cb53ca8d343..7f4ace73d44a 100644 --- a/drivers/usb/host/ehci-dbg.c +++ b/drivers/usb/host/ehci-dbg.c | |||
@@ -455,9 +455,7 @@ static void qh_lines ( | |||
455 | (scratch >> 16) & 0x7fff, | 455 | (scratch >> 16) & 0x7fff, |
456 | scratch, | 456 | scratch, |
457 | td->urb); | 457 | td->urb); |
458 | if (temp < 0) | 458 | if (size < temp) |
459 | temp = 0; | ||
460 | else if (size < temp) | ||
461 | temp = size; | 459 | temp = size; |
462 | size -= temp; | 460 | size -= temp; |
463 | next += temp; | 461 | next += temp; |
@@ -466,9 +464,7 @@ static void qh_lines ( | |||
466 | } | 464 | } |
467 | 465 | ||
468 | temp = snprintf (next, size, "\n"); | 466 | temp = snprintf (next, size, "\n"); |
469 | if (temp < 0) | 467 | if (size < temp) |
470 | temp = 0; | ||
471 | else if (size < temp) | ||
472 | temp = size; | 468 | temp = size; |
473 | size -= temp; | 469 | size -= temp; |
474 | next += temp; | 470 | next += temp; |
diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c index 444c69c447be..5f1a19d1497d 100644 --- a/drivers/usb/misc/usbtest.c +++ b/drivers/usb/misc/usbtest.c | |||
@@ -192,8 +192,6 @@ static struct urb *simple_alloc_urb ( | |||
192 | { | 192 | { |
193 | struct urb *urb; | 193 | struct urb *urb; |
194 | 194 | ||
195 | if (bytes < 0) | ||
196 | return NULL; | ||
197 | urb = usb_alloc_urb (0, GFP_KERNEL); | 195 | urb = usb_alloc_urb (0, GFP_KERNEL); |
198 | if (!urb) | 196 | if (!urb) |
199 | return urb; | 197 | return urb; |