[PATCH] PCI: start paying attention to a lot of pci function return values

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2 files changed, 22 insertions, 6 deletions

diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
index 7b9e54c39678..cbb451d227d2 100644
--- a/drivers/usb/core/hcd-pci.c
+++ b/drivers/usb/core/hcd-pci.c
@@ -260,8 +260,10 @@ int usb_hcd_pci_suspend (struct pci_dev *dev, pm_message_t message)
                 retval = pci_set_power_state (dev, PCI_D3hot);
                 if (retval == 0) {
                         dev_dbg (hcd->self.controller, "--> PCI D3\n");
-                        pci_enable_wake (dev, PCI_D3hot, hcd->remote_wakeup);
-                        pci_enable_wake (dev, PCI_D3cold, hcd->remote_wakeup);
+                        retval = pci_enable_wake (dev, PCI_D3hot, hcd->remote_wakeup);
+                        if (retval)
+                                break;
+                        retval = pci_enable_wake (dev, PCI_D3cold, hcd->remote_wakeup);
                 } else if (retval < 0) {
                         dev_dbg (&dev->dev, "PCI D3 suspend fail, %d\n",
                                         retval);
@@ -335,8 +337,20 @@ int usb_hcd_pci_resume (struct pci_dev *dev)
                                 dev->current_state);
                 }
 #endif
-                pci_enable_wake (dev, dev->current_state, 0);
-                pci_enable_wake (dev, PCI_D3cold, 0);
+                retval = pci_enable_wake (dev, dev->current_state, 0);
+                if (retval) {
+                        dev_err(hcd->self.controller,
+                                "can't enable_wake to %d, %d!\n",
+                                dev->current_state, retval);
+                        return retval;
+                }
+                retval = pci_enable_wake (dev, PCI_D3cold, 0);
+                if (retval) {
+                        dev_err(hcd->self.controller,
+                                "can't enable_wake to %d, %d!\n",
+                                PCI_D3cold, retval);
+                        return retval;
+                }
         } else {
                 /* Same basic cases: clean (powered/not), dirty */
                 dev_dbg(hcd->self.controller, "PCI legacy resume\n");
@@ -376,7 +390,7 @@ int usb_hcd_pci_resume (struct pci_dev *dev)
                 usb_hc_died (hcd);
         }
 
-        pci_enable_device(dev);
+        retval = pci_enable_device(dev);
         return retval;
 }
 EXPORT_SYMBOL (usb_hcd_pci_resume);
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 149b13fc0a71..2507e898af09 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -549,7 +549,9 @@ static int ehci_start (struct usb_hcd *hcd)
                 hcd->can_wakeup = (port_wake & 1) != 0;
 
                 /* help hc dma work well with cachelines */
-                pci_set_mwi (pdev);
+                retval = pci_set_mwi(pdev);
+                if (retval)
+                        ehci_dbg(ehci, "unable to enable MWI - not fatal.\n");
         }
 #endif