diff options
author | Jeff Dike <jdike@addtoit.com> | 2006-10-02 05:17:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-02 10:57:14 -0400 |
commit | b68e31d0ebbcc909d1941f9f230c9d062a3a13d3 (patch) | |
tree | b32902e5de02081cbb9eca49d7bb0b444e2b4f23 /drivers/usb | |
parent | ed97bd37efd8ff7398d3a7eedf4bcbf245f5dad3 (diff) |
[PATCH] const struct tty_operations
As part of an SMP cleanliness pass over UML, I consted a bunch of
structures in order to not have to document their locking. One of these
structures was a struct tty_operations. In order to const it in UML
without introducing compiler complaints, the declaration of
tty_set_operations needs to be changed, and then all of its callers need to
be fixed.
This patch declares all struct tty_operations in the tree as const. In all
cases, they are static and used only as input to tty_set_operations. As an
extra check, I ran an i386 allyesconfig build which produced no extra
warnings.
53 drivers are affected. I checked the history of a bunch of them, and in
most cases, there have been only a handful of maintenance changes in the
last six months. serial_core.c was the busiest one that I looked at.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/class/cdc-acm.c | 2 | ||||
-rw-r--r-- | drivers/usb/gadget/serial.c | 2 | ||||
-rw-r--r-- | drivers/usb/serial/usb-serial.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index ca90326f2f5c..71288295df2f 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c | |||
@@ -1120,7 +1120,7 @@ static struct usb_driver acm_driver = { | |||
1120 | * TTY driver structures. | 1120 | * TTY driver structures. |
1121 | */ | 1121 | */ |
1122 | 1122 | ||
1123 | static struct tty_operations acm_ops = { | 1123 | static const struct tty_operations acm_ops = { |
1124 | .open = acm_tty_open, | 1124 | .open = acm_tty_open, |
1125 | .close = acm_tty_close, | 1125 | .close = acm_tty_close, |
1126 | .write = acm_tty_write, | 1126 | .write = acm_tty_write, |
diff --git a/drivers/usb/gadget/serial.c b/drivers/usb/gadget/serial.c index b893e3118e1b..489a85e58bca 100644 --- a/drivers/usb/gadget/serial.c +++ b/drivers/usb/gadget/serial.c | |||
@@ -271,7 +271,7 @@ static unsigned int use_acm = GS_DEFAULT_USE_ACM; | |||
271 | 271 | ||
272 | 272 | ||
273 | /* tty driver struct */ | 273 | /* tty driver struct */ |
274 | static struct tty_operations gs_tty_ops = { | 274 | static const struct tty_operations gs_tty_ops = { |
275 | .open = gs_open, | 275 | .open = gs_open, |
276 | .close = gs_close, | 276 | .close = gs_close, |
277 | .write = gs_write, | 277 | .write = gs_write, |
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index 0222d92842b8..8006e51c34bb 100644 --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c | |||
@@ -1015,7 +1015,7 @@ void usb_serial_disconnect(struct usb_interface *interface) | |||
1015 | dev_info(dev, "device disconnected\n"); | 1015 | dev_info(dev, "device disconnected\n"); |
1016 | } | 1016 | } |
1017 | 1017 | ||
1018 | static struct tty_operations serial_ops = { | 1018 | static const struct tty_operations serial_ops = { |
1019 | .open = serial_open, | 1019 | .open = serial_open, |
1020 | .close = serial_close, | 1020 | .close = serial_close, |
1021 | .write = serial_write, | 1021 | .write = serial_write, |